Commit Graph

831 Commits

Author SHA1 Message Date
Willem Melching
47aec23fb3 modeld: sync based on frame timestamp (#23901)
* sync based on frame ts

* log extra frame id

* ints only

* update ref

* no rounding errors
old-commit-hash: 492398826f
2022-03-07 10:46:15 +01:00
Shane Smiskol
6303d97278 controlsd: fix vCruise jumping on pcmCruise cars (#23388)
* clean up v_cruise_kph

fix

fix

* Revert "clean up v_cruise_kph"

This reverts commit 211b5c3dbe073414ef5c39b19d6d2c6e8de2cf0b.

* always update vCruise and don't init if pcmCruise

* revert change

* update refs
old-commit-hash: 274885fc4d
2022-03-03 05:23:14 -08:00
Jonathan Frey
0d5d9a43d3 Longitudinal MPC set qp tolerance to 1e-3 (#23899)
* initialize solverExecutionTime longitudinal_planner

* test_onroad: improve timing evaluation

* longitudinal MPC: set qp_tol to 1e-3

* update ref

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
old-commit-hash: ab371f888a
2022-03-02 21:38:40 -08:00
Jonathan Frey
aa549592f7 remove trivial terminal constraint and associated CasADi generated functions (#23898)
* remove trivial terminal constraint and associated CasADi generated functions

* Update refs

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
old-commit-hash: 1801baba68
2022-03-02 20:53:21 -08:00
George Hotz
6b52bc6c13 model: mse err from 0.02-> 0.000056 (#23891)
* mse err from 0.028070712 -> 5.8073703e-05

* build with weights fixup

* need thneed lib also

* don't break for binaries

* static analysis says i need init

* check the bias

* load_dlc_weights

* nicer scons

* tested scons

* fix static

* pylint issue

* new ref

* a few more asserts

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
old-commit-hash: 8d6f49aecf
2022-03-02 20:52:17 -08:00
Vivek Aithal
5bad0f4400 locationd, paramsd: Check conditions before updating kalman filters (#23789)
* update filters only when all messages are alivbe and valid

* update message valid and fix unit test

* update refs

* move check outside loop

* modify fake message fn in test

* deprecate inputsOK and resolve PR comments

* avoid double looped list comprehension

* follow import conventions

* modify paramsd valid to only be invalid in case of commIssue

* update refs
old-commit-hash: 7e6903b58f
2022-03-02 01:01:29 -08:00
Shane Smiskol
79d5f584d8 Update Santa Fe 2019 route (#23888)
* new santa fe route, mid-drive to parking lot

* bump
old-commit-hash: 8eab496ce3
2022-03-01 13:47:53 -08:00
Jonathan Frey
baab5d7a7b Cython acados and minor (#23835)
* acados_ocp_solver_pyx.pyx: implement get_stats for timings and ints

* long_mpc: use acados timers

* acados_ocp_solver_pyx.pyx: fix dynamics_get

* acados_ocp_solver_pyx.pyx: get statistics

* use acados_ocp_solver_pyx.pyx from commaai/cython2 branch

* acados_ocp_solver_pyx.pyx: implement store_iterate

* acados_ocp_solver_pyx.pyx: implement get_residuals

* acados_ocp_solver_pyx.pyx: fix set() for empty fields

* acados_ocp_solver_pyx.pyx: load_iterate

* cython acados: add print_statistics

* test_following_distance: fix typo

* test_longitudinal: unique names for test maneuvers

* longitudinal MPC: comments for evaluation

* longitudinal MPC: add comments to eval acados residuals

* long_mpc: use qp_solver_cond_N = 1

* long MPC: comments, simplify set_cur_state

* update acados version in build script

* longitudinal mpc: weigh a_change in 1 place only

* update ref

* Update ref

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
old-commit-hash: d09dffb7cd
2022-02-25 14:16:44 -08:00
Adeeb Shihadeh
9bd6dbea43 Subaru: remove Impreza CAN fingerprints (#23841)
* Subaru: remove Impreza CAN fingerprints

* fix process replay

* update refs
old-commit-hash: 04b2545ec0
2022-02-23 15:44:17 -08:00
Adeeb Shihadeh
ca0cb66a09 Honda: revert to button enable on Nidec (#23828)
* Honda: revert to button enable on Nidec

* fix test

* bump panda
old-commit-hash: c483a9724d
2022-02-22 22:36:21 -08:00
Adeeb Shihadeh
4ab3f4c5de adjust comma two model timing thresholds after bigmodel
old-commit-hash: c98d9791f0
2022-02-22 13:16:23 -08:00
HaraldSchafer
fc042cd85a Fix tici bigmodel (#23817)
* Fix bigmodel on tici: cam intrinsics arent static

* Give TICI route own name for import

* Make function useable in offline test

* typo

* change tici ecam focal to trained focal

* No shadow variable

* Fixed ref

* Force update this time

* Update model replay ref commit
old-commit-hash: 48154703a7
2022-02-21 19:57:04 -08:00
Willem Melching
69588ca191 onroad_test: increase camerad cpu usage after debayer changes
old-commit-hash: ccdf069c8c
2022-02-21 16:18:01 +01:00
Willem Melching
dc16307917 longitudinal planner: disable change cost when stopped. not engaged or gas pressed (#23639)
* disable change cost completely on standstill and gas press

* cleanup

* set accel to zero

* clean up logic around standstill

* update ref
old-commit-hash: 428d412c1f
2022-02-21 16:14:41 +01:00
Adeeb Shihadeh
bd6d3bfc0b paramsd cpu usage has been increasing
old-commit-hash: 12cd852fc0
2022-02-19 17:10:29 -08:00
Willem Melching
ad5ccabce3 bigmodel (#23684)
* Added wide cam vipc client and bigmodel transform logic

* Added wide_frame to ModelState, should still work normally

* Refactored image input into addImage method, should still work normally

* Updated thneed/compile.cc

* Bigmodel, untested: 44f83118-b375-4d4c-ae12-2017124f0cf4/200

* Have to initialize extra buffer in SNPEModel

* Default paramater value in the wrong place I think

* Move USE_EXTRA to SConscript

* New model: 6c34d59a-acc3-4877-84bd-904c10745ba6/250

* move use extra check to runtime, not on C2

* this is always true

* more C2 checks

* log if frames are out of sync

* more logging on no frame

* store in pointer

* print sof

* add sync logic

* log based on sof difference as well

* keep both models

* less assumptions

* define above thneed

* typo

* simplify

* no need for second client is main is already wide

* more comments update

* no optional reference

* more logging to debug lags

* add to release files

* both defines

* New model: 6831a77f-2574-4bfb-8077-79b0972a2771/950

* Path offset no longer relevant

* Remove duplicate execute

* Moved bigmodel back to big_supercombo.dlc

* add wide vipc stream

* Tici must be tici

* Needs state too

* add wide cam support to model replay

* handle syncing better

* ugh, c2

* print that

* handle ecam lag

* skip first one

* so close

* update refs

Co-authored-by: mitchellgoffpc <mitchellgoffpc@gmail.com>
Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 85efde269d
2022-02-19 16:06:31 -08:00
Shane Smiskol
1f5570a96d Longitudinal control: interpolate longitudinal plan (#23787)
* interpolate longitudinal actuator delay

rename

* formatting

* interpolate v_target most importantly!

* fix interpolation and rename

* nicer setup

* left in from testing

* update refs
old-commit-hash: 2c7845fce0
2022-02-18 00:45:00 -08:00
Willem Melching
849bbc8a2f process replay: fix branch name alert (#23783)
* env is modified after start

* update ref
old-commit-hash: 14260c01c6
2022-02-17 16:47:42 +01:00
Adeeb Shihadeh
ddde46c503 keep the new alert consistent for process replay
old-commit-hash: f59adbeaaa
2022-02-16 23:47:02 -08:00
Adeeb Shihadeh
693b66c1e0 add branch name to startup master alert (#23782)
* add branch name to startup master alert

* still orange

* update refs
old-commit-hash: ff965c772b
2022-02-16 20:27:07 -08:00
ClockeNessMnstr
c12656f397 Longitudinal: add Kf to carParams (#23752)
* sane_kf

* long_kf + cereal

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 9535dc606d
2022-02-16 15:38:22 +01:00
George Hotz
37349c0fef add thneed optimizer (#23772)
* add thneed optimizer

* local work group opt

* kernels and final mods

* release files

* build system touchups

* fix kernel path, rand inputs for self test

* broken since extra is gone

* update model replay ref

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 90beaebefb
2022-02-15 15:32:00 -08:00
Vivek Aithal
1329847be0 controlsd: Fix Toyota steer angle sensor race condition (#23747)
* fix steer angle race condition

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 3e915cf628
2022-02-11 13:54:17 +01:00
Shane Smiskol
1cd3c05a70 Honda: fix brake pressed signal (#23683)
* or brake_switch

* remove car exceptions

* Revert "remove car exceptions"

This reverts commit cad6a552aa4a17c69616014d3e9333d30c1fadd3.

* does have ts noise, use updated

* bump panda for tests

* bump

* messsssy draft

* clean up

* clean up

* bump

* CS: process all messages at once, like we do during real openpilot usage

* handle multiple messages updated in one cycle

* bump

* bump

* use less confusing, but equivalent cp.vl

* Update selfdrive/test/test_models.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* no msg

* bump opendbc

* Update selfdrive/car/honda/carstate.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* same test logic

* add brake_switch_prev to class

* need to set previous brake switch when not lagging (most of the time)

* need to compare

* only update previous if updated this cycle

rm

* need to maintain previous active state

* move brake_switch

* bump opendbc

* bump

* bump

* bump

* bump

* bump

* bump

* bump opendbc

* rename

* oops

* bump opendbc

* bump

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 209bfe536b
2022-02-10 13:04:37 -08:00
Vivek Aithal
1eb13fdc65 paramsd: fix VehicleModelInvalid errors (#23726)
* bound steerratio, stiffness std

* remove start steer_ratio limits after looking at data

* reduce sf obs noise

* update refs

* update refs

* add comment explaining change
old-commit-hash: 8a2cbfe00b
2022-02-09 17:37:28 -08:00
Willem Melching
5a78f1d29c hide localizerMalfunction alert (#23730)
* hide localizerMalfunction alert

* update ref
old-commit-hash: 8effa2d878
2022-02-08 22:22:03 -08:00
Adeeb Shihadeh
8343e21ea7 reduce shutdownd CPU usage (#23723)
* reduce shutdownd CPU usage

* sync

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 4c766934be
2022-02-07 18:50:54 -08:00
Adeeb Shihadeh
3522f8dfad small test_models.py speedup
old-commit-hash: 48e97b7872
2022-02-07 16:10:20 -08:00
Jafar Al-Gharaibeh
5b2973b308 Mazda CX-5 2022 Car port (#23704)
* Mazda CX5 2022 FW

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* CX-5 2022: No lockout and steer down to zero

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* CX-5 2022: No dashcam!

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* CX-5 2022: add to supported cars

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Mazda: stick with 800 max torque for now

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update docs/CARS.md

* Apply suggestions from code review

* Mazda: set car models where needed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Mazda: set minSteerSpeed per car

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* unused

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* cleanup

* Update selfdrive/car/mazda/interface.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 341f5a4ae0
2022-02-04 23:34:37 -08:00
Adeeb Shihadeh
5d29eb6386 update refs
old-commit-hash: af33998335
2022-01-30 20:46:40 -08:00
Adeeb Shihadeh
97ea3c8ff2 controlsd: only add startup event until initialized (#23671)
* controlsd: only add startup event until initialized

* update refs

* update again
old-commit-hash: 602f92fc0e
2022-01-30 20:38:05 -08:00
Adeeb Shihadeh
12dcbe8617 test car models improvements (#23668)
* run on all routes

* min segment length

* invalid

* revert that
old-commit-hash: c8429f913e
2022-01-30 11:17:51 -08:00
Adeeb Shihadeh
f4a10c631f test car models: fix all panda safety mismatches (#23616)
* remove tolerance

* fix nissan mismatches

* warm up

* remove additional bosch check

* another honda exception

* little more

* Update selfdrive/test/test_models.py
old-commit-hash: d2735d73fc
2022-01-29 22:14:27 -08:00
Adeeb Shihadeh
a96bed88da Honda: fix controls mismatch for stock PCM configs (#23662)
* Honda: fix controls mismatch for stock PCM configs

* ready to remove

* bump panda
old-commit-hash: 5219554b85
2022-01-29 17:01:26 -08:00
Adeeb Shihadeh
71da8d1250 No actuation while in pre-enabled state (#23658)
* No actuation while in pre-enabled state

* update refs
old-commit-hash: 72e00a0768
2022-01-28 16:03:44 -08:00
Shane Smiskol
fadba4b34d CANParser: remove default values (#23642)
* draft

* remove rest

* bump

* update radar interfaces

* do rest and formatting

* bump

* fix mising check

* try this

* Revert "try this"

This reverts commit 0d26d9a072f87dbc897ed525b70fb1db9cb04a06.

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 3645186d7c
2022-01-27 17:06:18 -08:00
Willem Melching
9f202e63f5 clip steer saturation counter to steerLimitTimer (#23638)
* clip steer saturation counter to steerLimitTimer

* update ref
old-commit-hash: ee71fd2fcc
2022-01-27 12:31:36 +01:00
Adeeb Shihadeh
ed3eef90b1 Toyota: Prius V 2017 support (#23636)
* Add Toyota Prius Alpha support

* Fix opendbc link

* Update interface.py

* v

* revert opendbc

Co-authored-by: CT921 <tim.chen242@gmail.com>
Co-authored-by: 【TIM】 <90225659+CT921@users.noreply.github.com>
old-commit-hash: 2240b802be
2022-01-26 22:57:26 -08:00
Adeeb Shihadeh
c6e3e83a01 update refs
old-commit-hash: 013cccf6a8
2022-01-26 17:46:12 -08:00
Willem Melching
6101a6caca INDI: replace internal rate limit by actuatorsOutput (#23243)
* INDI: replace internal rate limit by actuatorsOutput

* update ref
old-commit-hash: cf9eee4272
2022-01-26 17:45:05 +01:00
Willem Melching
179f5ac2e7 compare_logs: catch typeError (#23632)
old-commit-hash: 5ac32705d0
2022-01-26 17:13:32 +01:00
Shane Smiskol
beeb0442ce base LatControl class (#21967)
* base LatControl class, move sat check out of pid.py

clean up

clean up

* fix

* global variable for min control speed

* nicer name

* unify latcontrol class init arguments

* add to release files

* saturated if close to limit

* move angle mode saturation checks into class

* check_saturation function takes in current saturated status

undo

* apply latcontrol_angle's active checking to all controllers

* clean up

* move those back

* make abstract baseclass

* add test for saturation

* keep clip

* update ref

* fix static analysis

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 9de8f8cd8c
2022-01-26 17:10:41 +01:00
vanillagorillaa
455fd17008 Honda: Merge Pilot_2019 into Pilot (#23590)
* merge pilot

* these weren't on the 2019 pilot

* add non essential ECUs
old-commit-hash: 4f827e2e9e
2022-01-24 21:19:40 -08:00
Adeeb Shihadeh
badf4dff4f Toyota: move gas pedal definitions into common DBC (#23582)
* Toyota: move gas pedal definitions into common DBC

* add rest of cars

* auto detection

* cleanup

* update refs
old-commit-hash: b18c4eeb82
2022-01-24 15:43:10 -08:00
Adeeb Shihadeh
70f1418256 remove community features toggle (#23214)
* remove community features toggle

* bump cereal

* little more

* update refs
old-commit-hash: 3e9cb7fa12
2022-01-24 14:49:47 -08:00
Willem Melching
cb45784238 process replay: disable alive checks for cpp replay
old-commit-hash: c51561c2ca
2022-01-24 12:06:43 +01:00
Ryan
0dbb4fb3b0 Add more type hinting (#23595)
* Add more type hinting.

* Revert joystick_alert changes.

* Add typing to statsd.

* Update selfdrive/statsd.py

* Update selfdrive/test/test_fingerprints.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: aa9e635311
2022-01-21 15:11:16 -08:00
Willem Melching
962201fff1 Ensure controlsd can engage again in process replay (#23556)
* hacks to make process replay engage again

* dont change that

* enable engagement check again

* chmod +x

* first working regen

* proper logMonoTime

* fix video framerate consistency

* mpc is valid again

* proper alive checks

* revert loggerd change

* ensure engaged in regen, fix managerState, peripheralState

* ubloxRaw is unused

* add submaster config for gm

* regen all services we can run without HW

* fix loggerd

* loggerd: matroska without the extension

* update ref
old-commit-hash: d3d10e014a
2022-01-21 13:13:34 +01:00
Harald Schafer
490f9efc7d Update refs for PR:#23584)
old-commit-hash: 920829875f
2022-01-20 14:24:36 -08:00
Jonathan Frey
6f4c93238f work on acados lateral MPC (#23558)
* lat_mpc: make v_ego, rotation_radius parameters instead of states

* lat_mpc: remove rotation_radius argument, since it is part of the parameters

* lat_mpc: use qp_solver_cond_N = 1

slightly faster and in line with case study in Fig. 2/ 3 in Frison2016 - https://cdn.syscop.de/publications/Frison2016.pdf
An Efficient Implementation of Partial Condensing for Nonlinear Model Predictive Control

* adapt test_lateral_mpc to formulation with parameters

* lat_mpc: set parameters in reset() and copy values

* acados_ocp_solver_pyx: make options_set useable

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 0681474840
2022-01-18 09:49:48 -08:00