Commit Graph

28 Commits

Author SHA1 Message Date
DevTekVE
7ddaf52b2b CI: adjust allow 1 retry for first time contributor and fork and skip sync lfs on fork PRs (#647)
* Update workflow condition to skip forked PRs during sync

This change ensures the LFS maintenance workflow does not run for pull requests originating from forked repositories. It enhances efficiency by avoiding unnecessary sync actions in these cases.

* Modified retry conditions in GitHub workflow file

Adjusted the retry conditions in the GitHub workflow setup file. The updated condition allows for a second attempt if the pull request originator is a 'FIRST_TIME_CONTRIBUTOR' from a forked repository. This modification lends more flexibility to first-time contributors by providing them with an additional chance to pass the tests.

* test

* test2

* test3

* Fix conditional logic for retry check in workflow script

The condition now correctly checks if the pull request is not from a fork using 'false' instead of 'true'. This ensures proper validation of retry attempts based on the contributor and repository source.

* Fix placement of event JSON logging in workflow script

Moved the `toJSON(github.event)` logging statement to ensure it runs after retry logic validation. This improves the logical flow of the script and maintains appropriate debugging output.

* Add debug logs for PR metadata and run attempt values

This change introduces debug logs to output key PR metadata, such as fork status, author association, and the GitHub run attempt value. These logs will aid in debugging and provide better visibility into workflow execution.

* Add debug log for PR fork and author association check

This change adds a debug log to display the evaluation of the fork and author association condition in the workflow. It helps in troubleshooting PR handling logic and ensures better visibility into the condition being assessed.

* Fix logical negation for fork checks in workflow script

Correct the evaluation of fork status using proper negation syntax. This ensures accurate logic in pull request conditions, improving the reliability of the workflow execution.

* Add log for first-time contributor check in workflow

This adds a debug statement to log whether the PR author is a first-time contributor. It helps improve observability and makes it easier to debug workflows involving author associations.

* Simplify log output in GitHub action script

Removed unnecessary debug echo statements to streamline the script and improve readability. Retained essential logic to handle retries and enforce restrictions on test flakiness.

* Simplify retry logic for pull request contributors.

Updated the condition to correctly identify and handle retries for first-time contributors and forked repositories. This ensures a clearer and more accurate retry policy in the workflow.

* Refine workflow conditions for PR checks and retries

Adjusted conditional logic in `lfs-maintenance.yaml` to improve readability and ensure proper handling of draft PRs. Updated retry logic in `setup/action.yaml` to reflect correct author association for stricter validations.
2025-03-06 15:02:29 +01:00
DevTekVE
a51ed062ca CI: allow 1 retry for first time contributor and fork and skip sync lfs on fork PRs (#646)
* Update workflow condition to skip forked PRs during sync

This change ensures the LFS maintenance workflow does not run for pull requests originating from forked repositories. It enhances efficiency by avoiding unnecessary sync actions in these cases.

* Modified retry conditions in GitHub workflow file

Adjusted the retry conditions in the GitHub workflow setup file. The updated condition allows for a second attempt if the pull request originator is a 'FIRST_TIME_CONTRIBUTOR' from a forked repository. This modification lends more flexibility to first-time contributors by providing them with an additional chance to pass the tests.
2025-03-06 10:24:14 +01:00
Maxime Desroches
1bbace7dff ci: fix retry color (#34094)
* color

* fix

* fix
2024-11-22 20:42:57 -08:00
Maxime Desroches
3ac9208364 ci: increase timeout on cache misses + switch some caches to github (#34056)
* cache

* test ns

* try this

* try

* try now?

* bp

* bp agian

* fix

* remove

* test

* try

* fix

* fix

* regen cache

* fix
2024-11-18 21:16:15 -08:00
Adeeb Shihadeh
2ac776cfda CI: disable retries on Actions (#33960)
* no retries

* red
2024-11-07 16:25:29 -08:00
Maxime Desroches
1b836bdb86 Ubuntu 24.04 (#32624)
* noble build

* workflow

* symlink

* map only for noble

* sym

* add qt to cppcheck

* cppcheck noreturn in non void funct

* get kaitai header

* kaitai header

* syntax

* try new pyopencl

* try this version

* install lsb-core manually

* support old 20.04 lsb-core

* try arm

* try latest pyopencl

* revert

* use pocl icd

* no lock

* no arm pyopencl

* new intel opencl runtime

* pin filelock

* undo

* glsl version

* new version

* build test

* remove test

* new metadrive

* remove glsl restrictions

* <optional>

* Update .github/workflows/tools_tests.yaml

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* cache

* new cache

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 5c4ea14a3c
2024-06-18 03:30:32 +00:00
Justin Newberry
aba5ee6a44 CI: auto-cache add option to save cache (#31076)
* save cache option

* inputs
old-commit-hash: bbbe94bc3e
2024-01-19 12:43:47 -08:00
Justin Newberry
11b807cd32 CI: use namespace.io (#31064)
* namespace

* mkdir

* fix

* restore only

* restore

* v3

* disable provenance
old-commit-hash: 35ed8a0886
2024-01-18 22:13:19 -08:00
Justin Newberry
d6922d3522 Revert "CI: use namespace.so" (#31060)
old-commit-hash: 23cbfe9eb3
2024-01-18 17:35:24 -08:00
Justin Newberry
d792c3c5bb CI: use namespace.so (#31056)
* namespace

* mkdir

* fix

* restore only

* restore

* v3
old-commit-hash: 9ee0a8a2b1
2024-01-18 17:17:53 -08:00
Justin Newberry
2a934cf3c8 CI: disable registry caching (#30474)
* Revert "CI: separate image for docker cache (#30413)"

This reverts commit ce7c4abe37343b78c3a0da66ec784fd71a46e53a.

* Revert "CI: enable buildx for registry cache (#30473)"

This reverts commit 528b1be03ac407184f19b8d4901cdc5a7c96e7eb.
old-commit-hash: 291c04163a
2023-11-15 18:21:57 -08:00
Justin Newberry
48ac234374 CI: enable buildx for registry cache (#30473)
* just registry cache

* enable buildx
old-commit-hash: edf90f3e76
2023-11-15 17:53:00 -08:00
Adeeb Shihadeh
e69eeb7344 move remaining big files into LFS (#30053)
old-commit-hash: e185e5ffcd
2023-09-25 21:53:03 -07:00
Adeeb Shihadeh
e14996e079 CI: login to docker hub on BuildJet (#29961)
* CI: login to docker hub on BuildJet

* shell

* try quotes

* forward

* try this

* can't believe this is broken

* try

* fix process replay
old-commit-hash: 4b7b234b9e
2023-09-18 15:53:16 -07:00
Kacper Rączy
f8c6ebd3ad docker: multiarch images (amd64/aarch64) (#29691)
* arch specific tags

* merge multiarch script

* arm64 build and merge jobs

* update tag script

* casual ci test

* change image to 2204

* docker -v test

* arch specific naming

* Remove test_buildjet

* build -arch images only when CURRENT_ARCH_BUILD is set

* support new tags in tag_multiarch

* Toggle CURRENT_ARCH_BUILD on in ci

* Docker common

* Fix condition

* Fix path to docker_common

* Add more stuff to common

* Add build_arm job

* composite job for building

* Run checkout before build composite

* add shell arg

* move timeout to selfdrive_tests

* TARGET ARCHITECTURE var

* Support TARGET_ARCHITECTURE in workflow

* Rewrite to Single build job with matrix

* Remove shebang from docker_common

* Attempt for fix build matrix

* Remove setup arch

* build matrix for docker push

* Use 2vcpu for arm build

* 2vcpu for docker_push too

* temporarly unlock docker_push

* Remove requirement for target arch when pushing

* Unset target architecture in docker_push cl

* fix sha tags

* Rename action to compile-openpilot

* move push_image line to tag_multiarch step

* arch suffix for scons cache

* cache_key_prefix for setup-with-retry

* Re-disable docker_push on non-master

* Add newlines
old-commit-hash: 1344a93a35
2023-09-08 14:46:39 -07:00
Justin Newberry
e468072f1f CI: retry setup on failure (#29785)
* try a setup action

* should be uses

* fix that formatting

* try conclusion

* continue on error

* try without hyphens

* only when failure

* make it optional

* continue on error

* those don't fail anymore

* what about 3 failures

* remove stuff for debugging

* cleanup

* review suggestions

* change that too

* fix pj
old-commit-hash: 917f71d446
2023-09-06 11:11:15 -07:00
Adeeb Shihadeh
68dd600872 CI: use buildjet for process replay (#29277)
* squash for pr

* backoff to 4vcpu

* review suggestions

* simplify

---------

Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
Co-authored-by: Justin Newberry <justin@comma.ai>
old-commit-hash: d35beffbce
2023-08-25 18:50:21 -07:00
Justin Newberry
643a13f27e CI: use local scons cache instead of building a separate image (#29634)
* use local

* added ci_sim

* revert scons

* dont need these anymore

* same for sim

* fix dockerfiles
old-commit-hash: c46965fc27
2023-08-25 16:06:17 -07:00
Justin Newberry
e128aedc63 CI: move cache dir to workspace directory (#29622)
* comma dir

* mkdir

* fix issues

* test

* fix that

* fix

* do the other ones too

* missed that

* fix

* fix pr comments by moving into two different directories

* fix location

* fix that

* only change current

* fix
old-commit-hash: c0b9458a45
2023-08-25 01:41:04 -07:00
Justin Newberry
de7257c22c CI: Normalize file permissions (#29584)
* normalize file permissions

* comment

* add comment

* remove that

* shell

* should be on the top
old-commit-hash: da7504e1e7
2023-08-23 23:50:51 -07:00
Justin Newberry
e54655626d CI: Docs rebuild base image (#29566)
* docs rebuild base image

* fix order
old-commit-hash: 2e4f8e6608
2023-08-23 15:33:23 -07:00
Justin Newberry
7205b92bb6 CI: use scons cache mount for building simulator and docs (#29436)
* build docker image with scons cache

* use setup

* scons cache

* added the dockerfile

* add the shell

* docs use cache

* dont pull lfs for docs

* simulator too

* dont pull the cache image

* fix inputs

* inputs

* booleans aren't supported

* bool not supported

* bool isnt supported

* fix

* readonly cache

* fix sim cache too

* respect readonly

* gitignore and move to correct folder

* also copy old

* move to tools/ci

* move to selfdrive/test

* just make the cache writable, it's discarded anyway

* minimize diff in this pr
old-commit-hash: 197460e061
2023-08-21 15:11:31 -07:00
Justin Newberry
edbd5d330e CI: use setup script for docs and simulator (#29434)
* use setup

* dont pull lfs for docs

* fix inputs

* bool not supported

* bool isnt supported
old-commit-hash: ad00595ba5
2023-08-16 17:59:42 -07:00
Justin Newberry
afa33bee18 CI: move cache to home directory (#29347)
move cache to home dir
old-commit-hash: ace4d78e31
2023-08-11 15:45:38 -07:00
Justin Newberry
f8cd844e7c CI: use default caching action (#29339)
old-commit-hash: a0f399677e
2023-08-11 14:03:10 -07:00
Adeeb Shihadeh
eec2ca1e8b CI speedup (#26096)
* CI speedup

* use the new stuff

* push

* no regressions

* try that

* don't let this slip

* fix modeld tests

* fix linter

* modernize prebuilt

* cleanup

* fix those

* increase a bit
old-commit-hash: 00494a44f4
2022-10-16 15:54:36 -07:00
Jeroen
8e260b430f CI: remove redundant env variables in 'openpilot env setup' (#25721)
old-commit-hash: 1544734a54
2022-09-10 12:02:27 -07:00
Adeeb Shihadeh
fca5728055 CI: Actions cleanup + speedup (#25514)
* actions cache cleanup

* release build cleanup

* fetch dpeth
old-commit-hash: 71e76c3d0f
2022-08-21 19:14:36 -07:00