From 8d7315fa280a588d208d19343aae97343ccdecee Mon Sep 17 00:00:00 2001 From: DevTekVE Date: Wed, 22 Jan 2025 11:35:12 +0100 Subject: [PATCH] ci: Add support for "settings_network" and "settings_network_advanced" scene in UI tests (#609) * Add support for "settings_network" scene in UI tests Updated the workflow and test script to include the "settings_network" scene. Introduced a new setup function for "settings_network" and registered it in the scene-to-function mapping. This ensures proper handling and testing of network settings in the UI. * Static analysis lol * Add support for "settings_network_advanced" scene Extend UI tests and workflow to include the "settings_network_advanced" scene. Updated the YAML workflow and test script to handle this new scene for comprehensive coverage. --- .github/workflows/ui_preview.yaml | 2 +- selfdrive/ui/tests/test_ui/run.py | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ui_preview.yaml b/.github/workflows/ui_preview.yaml index 3e8c2be4ba..140240dc9c 100644 --- a/.github/workflows/ui_preview.yaml +++ b/.github/workflows/ui_preview.yaml @@ -86,7 +86,7 @@ jobs: run: >- sudo apt-get install -y imagemagick - scenes="homescreen settings_device settings_software settings_sunnylink settings_toggles settings_sunnypilot settings_sunnypilot_mads settings_trips settings_developer offroad_alert update_available prime onroad onroad_disengaged onroad_override onroad_sidebar onroad_wide onroad_wide_sidebar onroad_alert_small onroad_alert_mid onroad_alert_full driver_camera body keyboard keyboard_uppercase" + scenes="homescreen settings_device settings_network settings_network_advanced settings_software settings_sunnylink settings_toggles settings_sunnypilot settings_sunnypilot_mads settings_trips settings_developer offroad_alert update_available prime onroad onroad_disengaged onroad_override onroad_sidebar onroad_wide onroad_wide_sidebar onroad_alert_small onroad_alert_mid onroad_alert_full driver_camera body keyboard keyboard_uppercase" A=($scenes) DIFF="" diff --git a/selfdrive/ui/tests/test_ui/run.py b/selfdrive/ui/tests/test_ui/run.py index 0a9f3a3e44..929c04727a 100644 --- a/selfdrive/ui/tests/test_ui/run.py +++ b/selfdrive/ui/tests/test_ui/run.py @@ -40,6 +40,14 @@ def setup_homescreen(click, pm: PubMaster, scroll=None): def setup_settings_device(click, pm: PubMaster, scroll=None): click(100, 100) +def setup_settings_network(click, pm: PubMaster, scroll=None): + setup_settings_device(click, pm) + click(278, 405) + +def setup_settings_network_advanced(click, pm: PubMaster, scroll=None): + setup_settings_network(click, pm) + click(1913, 90) + def setup_settings_toggles(click, pm: PubMaster, scroll=None): setup_settings_device(click, pm) click(278, 632) @@ -212,6 +220,8 @@ CASES = { "prime": setup_homescreen, "pair_device": setup_pair_device, "settings_device": setup_settings_device, + "settings_network": setup_settings_network, + "settings_network_advanced": setup_settings_network_advanced, "settings_toggles": setup_settings_toggles, "settings_software": setup_settings_software, "settings_developer": setup_settings_developer,