From 7f035bae3966c6fb2648ea43c01177c8faa46766 Mon Sep 17 00:00:00 2001
From: James Vecellio-Grant <159560811+Discountchubbs@users.noreply.github.com>
Date: Thu, 21 Aug 2025 18:04:57 -0700
Subject: [PATCH] ui: bugfix visibility for developer panel (#1131)

* yes

idk

move up

* patch

* updates

* Update developer_panel.cc

* Update developer_panel.cc

* Update developer_panel.cc

---------

Co-authored-by: Jason Wen <haibin.wen3@gmail.com>
---
 .../qt/offroad/settings/developer_panel.cc           | 12 ++++++------
 .../sunnypilot/qt/offroad/settings/developer_panel.h |  3 +++
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/selfdrive/ui/sunnypilot/qt/offroad/settings/developer_panel.cc b/selfdrive/ui/sunnypilot/qt/offroad/settings/developer_panel.cc
index 5c9f0ff99e..58193f9fe8 100644
--- a/selfdrive/ui/sunnypilot/qt/offroad/settings/developer_panel.cc
+++ b/selfdrive/ui/sunnypilot/qt/offroad/settings/developer_panel.cc
@@ -47,17 +47,17 @@ DeveloperPanelSP::DeveloperPanelSP(SettingsWindow *parent) : DeveloperPanel(pare
   addItem(errorLogBtn);
 
   QObject::connect(uiState(), &UIState::offroadTransition, this, &DeveloperPanelSP::updateToggles);
+
+  is_release = params.getBool("IsReleaseBranch");
+  is_tested = params.getBool("IsTestedBranch");
+  is_development = params.getBool("IsDevelopmentBranch");
 }
 
 void DeveloperPanelSP::updateToggles(bool offroad) {
-  bool is_release = params.getBool("IsReleaseBranch");
-  bool is_tested = params.getBool("IsTestedBranch");
-  bool is_development = params.getBool("IsDevelopmentBranch");
   bool disable_updates = params.getBool("DisableUpdates");
 
   prebuiltToggle->setVisible(!is_release && !is_tested && !is_development);
   prebuiltToggle->setEnabled(disable_updates);
-
   params.putBool("QuickBootToggle", QFile::exists("/data/openpilot/prebuilt"));
   prebuiltToggle->refresh();
 
@@ -66,6 +66,7 @@ void DeveloperPanelSP::updateToggles(bool offroad) {
          "it immediately removes the prebuilt file so compilation of locally edited cpp files can be made. "
          "<br><br><b>To edit C++ files locally on device, you MUST first turn off this toggle so the changes can recompile.</b>")
     : tr("Quickboot mode requires updates to be disabled.<br>Enable 'Disable Updates' in the Software panel first."));
+  prebuiltToggle->showDescription();
 
   enableGithubRunner->setVisible(!is_release);
   errorLogBtn->setVisible(!is_release);
@@ -74,7 +75,6 @@ void DeveloperPanelSP::updateToggles(bool offroad) {
 
 void DeveloperPanelSP::showEvent(QShowEvent *event) {
   DeveloperPanel::showEvent(event);
-  updateToggles(!uiState()->scene.started);
   AbstractControlSP::UpdateAllAdvancedControls();
-  prebuiltToggle->showDescription();
+  updateToggles(!uiState()->scene.started);
 }
diff --git a/selfdrive/ui/sunnypilot/qt/offroad/settings/developer_panel.h b/selfdrive/ui/sunnypilot/qt/offroad/settings/developer_panel.h
index d63fe18d04..42b3bd83b8 100644
--- a/selfdrive/ui/sunnypilot/qt/offroad/settings/developer_panel.h
+++ b/selfdrive/ui/sunnypilot/qt/offroad/settings/developer_panel.h
@@ -21,6 +21,9 @@ private:
   ParamControlSP *prebuiltToggle;
   Params params;
   ParamControlSP *showAdvancedControls;
+  bool is_development;
+  bool is_release;
+  bool is_tested;
 
 private slots:
   void updateToggles(bool offroad);