* rising edge of resume
* fix test
* comment
* todo fix tests
* fix test
* we want to test the transition from btn prev to btn cur, not unpressed to x to y
* range
* Revert "GM: enable on rising edge of resume (#1155)"
This reverts commit 5aa33e1b2f.
* allow set/resume to any other button (except cancel)
* explicit test
* This is a test of both PRs combined
* Revert "This is a test of both PRs combined"
This reverts commit c7fdc3b00c12da64763c371f8cf017faa0273b1d.
* fix test
* GM camera: use ECM brake pressed bit
* back to ECMEngineStatus
* length 8
* common gmcamera class
* move to longitudinal base
* Revert "move to longitudinal base"
This reverts commit 67abe4c86b0e5e00432ab0ab80a8db6061f3cc3e.
* fix
* Allow brake TX on PT bus
* Initial Panda GM cam harness support
* Complete rewrite / simplification
* Add param for cam harness (default is OBD2)
- Forward btw 0 and 2
- Filter LKAS and optionally ACC from cam
* Add param for stock ACC
- Allows ACC on PT bus when set, not otherwise
- Allows ACC from cam when set, not otherwise
* Add temporary WIP EPS timing workaround in ifdef
* Remove keepalive; regen == braking
* Fix MISRA violations
* EPS timing opt-in by param
* Minor clean up
* remove timing code for readability
fix and formatting
* we only need to send one message if cam harness and stock long
* Simplify params
* Removed dup brake msg
* revised params, split 3-ways
* add test
* clean up a bit, no need to send ACC yet
like this
* split out button enable and pcm enable into seperate tests
* some formatting
some formatting
* GM CAM uses PCM cruise for controls_allowed
* fix gas safety tests
* misra
* fix static analysis
comment
* fix brake pressed
* Add OP VOACC override stock cam
* Add VOACC safetyparam to init.py
* openpilot long safety
* do this in another PR
* add back
* add safety tests
* rename
* struct for safety
* not used
* temporary fault fix
* adjust max gas
* allow PSCMStatus in long mode
* stash
* fix max gas
* fix and clean up tests
* clean up longitudinal tests into a common class
* fix pylint
* subclass
* clean that up
* rm
* blocking
* comment
* comment
* lower case
* brake bus
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* Match openpilot brake check
* comment
* simple
* Update test
* doesn't take an int
* msg varies in size by platform
* 2 extra bytes of zeros on Escalade
* label platforms
* space
* it was only checking a specific bit
* same check as openpilot
* reset on init
* unsigned
* should fix conflicts
* common
* comment
* Add missing function
* Tests
* the alternative is a mess
typo
typo
* draft
* finish common
* works but you need RegenSafetyTest before all other classes
* Revert "works but you need RegenSafetyTest before all other classes"
This reverts commit 256f3be9a86e2412220d473037d64b84167ae98d.
* This works too
* need parameterized, subtests nor super() calls correctly reset state
* Fix test and comment
* comment
* another fix...
* subclass
* ABC
* order
* fix static analysis
* can do this
* Revert "can do this"
This reverts commit 6bc63a345a2d63019a640092dd9538203e8b213d.
* this is nicer, no pylint errors
* Update tests/safety/common.py
* underscore
* dynamically detect and add tests
* simpler
* only for safety modes with a regen message
* check attr
* Revert "check attr"
This reverts commit bc37a7eedd2269bb3bc77d96762f0f0df6890991.
* need to check at test time not class init time
* Allow brake TX on PT bus
* Initial Panda GM cam harness support
* Complete rewrite / simplification
* Add param for cam harness (default is OBD2)
- Forward btw 0 and 2
- Filter LKAS and optionally ACC from cam
* Add param for stock ACC
- Allows ACC on PT bus when set, not otherwise
- Allows ACC from cam when set, not otherwise
* Add temporary WIP EPS timing workaround in ifdef
* Remove keepalive; regen == braking
* Fix MISRA violations
* EPS timing opt-in by param
* Minor clean up
* remove timing code for readability
fix and formatting
* we only need to send one message if cam harness and stock long
* Simplify params
* Removed dup brake msg
* revised params, split 3-ways
* add test
* clean up a bit, no need to send ACC yet
like this
* split out button enable and pcm enable into seperate tests
* some formatting
some formatting
* GM CAM uses PCM cruise for controls_allowed
* fix gas safety tests
* misra
* fix static analysis
comment
* fix brake pressed
* Add OP VOACC override stock cam
* Add VOACC safetyparam to init.py
* Revert "Add VOACC safetyparam to init.py"
This reverts commit 2e46f8746f31c399823d9fae9fb9e77e6fee6eea.
* Revert "Add OP VOACC override stock cam"
This reverts commit a4b096cc1e7ee572b22e5f4422b9a6d43f94479c.
* better comments
* better comments
better comments
fix
* move non-base msg definitions to subclass
* various comments
* TODO: add button safety
* add button safety
* use new pcm_cruise_check
* revert regen braking change
* only cancel button allowed
* Apply suggestions from code review
* Update board/safety/safety_gm.h
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* fix suggestion
* Fix tests
* Revert "Fix tests"
This reverts commit 500577921f32be24934acc80af98aab3af86d028.
* this is a much simpler fix, do full fix in another PR
* tx button safety
Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* rename to torque_cmd_msg
* Move most of the driver torque tests into common.DriverTorqueSteeringSafetyTest
* fix static analysis so far
* HDA2 just works
* TODO: Subaru
* Subaru
* Move Mazda steering constants into class
* rm line
* split into classes
* move test_against_torque_driver into common driver torque tests
* rename to match all other tests
* fix linter
* revert changes
* check steer_req
* think this is clearer on first glance
* add test
* also test recovery
* Update tests/safety/test_toyota.py
* Update tests/safety/test_toyota.py
* move
* test implemented for Toyota
* fix Toyota interceptor
* use hasattr
* do Honda (still need Nidec ACC_HUD safety)
* add longitudinal_allowed to ACC_HUD (Nidec w/ no pedal
* rx not needed
* add base test for longitudinal
* update name
* stash
* do GM
* use gas_pressed_prev
* do tesla safety
* add full tests
* add get_longitudinal_allowed for simpler tests
* remove unnecessary tests and revert honda/hyundai
* fix honda after revert
* make sure releasing gas allows longitudinal again
* clean up
* clean up
* Just check longitudinal allowed
* don't need to reset detection
* use prev and add brake detection
* only on gas
* make sure we don't change current_controls_allowed braking behavior
* clean up tests
* use current_controls_allowed for honda & GM
* this is pretty much tested in common
* fix up tests and move common tests
* revert
* better place
* add for body
* _brake_msg and _gas_msg were confusing
* use class inheritance to define test specific safety variables
* Revert "use class inheritance to define test specific safety variables"
This reverts commit 734efd96f3f66c2cff62674a6510c1c4b08f22cd.
* common function to set up each test
fix honda
* Revert "common function to set up each test"
This reverts commit fe4e71b3c64c6dd9717ea4f188abef7114cbfce8.
* rename related function
* formatting
* consistent name
* revert this change
* alternative experiences
* not unsafe
* more renames
more renames
* not yet true
* I think we import from panda now
* update comments and test
* not needed
* bump health pkt version
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* fix W391
* E262
* E703
* W293
* some E
* E231
* some more E
* E225
* more E
* E252
* no tabs
* more tabs
* E701
* uds.py
* almost all of them
* only e265 left
* not sure why this is triggering on commented out code
* ignore esptool
* Add pre commit checks
* untested but should work
* fix typo in dockerfile
* add sqlite
* add pylintrc to ignore usb1 members
* Typo in stage name
* Move to requirements
* Started whitelisting messages
* Also toyota and cadilalc fix
* bug fixes and better checks. Need to figure out a solution for honda
* Whitelist also for subaru
* Added Chrysler as well to whitelist
* And Hyundai too
* now all supported cars should have a whitelist of messages
* Fix linter
* This should fix process replay
* Honda too is now whitelisted
* struct typedef
* Had forgot GM
* had a wrong addr for GM whitelist
* This should fix all the tests
* bump panda
* relay malfunction handling. WIP
* more cars to relay_malfunctions
* fixed safety tests
* minor change
* Fix linter
* all cars now have a relay_malfunction safety check
* added relay_malfunction safety test for fwd hooks
* added proper regression tests for relay malfunction to all cars
* temp patch to not fail regression in honda bosch
* also addr 0x194 is some nidec honda is steer control
* proper relay check for honda bosch too
* Added pyflakes and Pylint for python
* Actually run linter in CI
* some simple pyflakes changes
* Add flake8 to panda reqs for linter test
* flake8 errors are fixed
* run flake8 in regression tests
* meant to run flake8
* hack to ignore unused import
* bug
* fix bugs in tucan_loopback
* Another fix by using set_safety_mode
* added pylintrc file
* more fixes and enabled pylint as well
* Fix pylint in circleci
* added linter to readme
