* rising edge of resume
* fix test
* comment
* todo fix tests
* fix test
* we want to test the transition from btn prev to btn cur, not unpressed to x to y
* range
* Revert "GM: enable on rising edge of resume (#1155)"
This reverts commit 5aa33e1b2f.
* allow set/resume to any other button (except cancel)
* explicit test
* This is a test of both PRs combined
* Revert "This is a test of both PRs combined"
This reverts commit c7fdc3b00c12da64763c371f8cf017faa0273b1d.
* fix test
* GM camera: use ECM brake pressed bit
* back to ECMEngineStatus
* length 8
* common gmcamera class
* move to longitudinal base
* Revert "move to longitudinal base"
This reverts commit 67abe4c86b0e5e00432ab0ab80a8db6061f3cc3e.
* fix
* HKG: Car Port for Genesis GV70 2023
* Revert "HKG: Car Port for Genesis GV70 2023"
This reverts commit 01bfda6dff4d8d2de4fd9b485b3f352e3e038000.
* 0x1a0 rx check
* Wrong one oops
* Check 0x1a0 based on param
* no need
* getting a bit messy, clean up soon!
* clean up
* clean up
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* more complete tests
* use parameterized_class
* make clear this only tests EV right now
* fix python linter
* rename reference
* clean up and fix python linter again
* VW MQB: Longitudinal safety
* disregard ACC_13 for now
* abstraction cleanup
* fix long control flag name
* quick hack
* VW MQB: Cleanup message counter handling
* various cleanup
* try without ACC_04
* follow DBC updates
* bump Docker opendbc ref
* additional main switch and cancel handling/testing
* pacify linter
* style
* handle the overlap tests like HKG CANFD
* update replay route
* commonize elements between MQB and PQ
* Apply suggestions from code review
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* proper use of globals/conventions
* make these global
* this is better for now
* better comment on accel boundary scaling
* spelling error
* reset on init
* try bumping openpilot
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Allow brake TX on PT bus
* Initial Panda GM cam harness support
* Complete rewrite / simplification
* Add param for cam harness (default is OBD2)
- Forward btw 0 and 2
- Filter LKAS and optionally ACC from cam
* Add param for stock ACC
- Allows ACC on PT bus when set, not otherwise
- Allows ACC from cam when set, not otherwise
* Add temporary WIP EPS timing workaround in ifdef
* Remove keepalive; regen == braking
* Fix MISRA violations
* EPS timing opt-in by param
* Minor clean up
* remove timing code for readability
fix and formatting
* we only need to send one message if cam harness and stock long
* Simplify params
* Removed dup brake msg
* revised params, split 3-ways
* add test
* clean up a bit, no need to send ACC yet
like this
* split out button enable and pcm enable into seperate tests
* some formatting
some formatting
* GM CAM uses PCM cruise for controls_allowed
* fix gas safety tests
* misra
* fix static analysis
comment
* fix brake pressed
* Add OP VOACC override stock cam
* Add VOACC safetyparam to init.py
* openpilot long safety
* do this in another PR
* add back
* add safety tests
* rename
* struct for safety
* not used
* temporary fault fix
* adjust max gas
* allow PSCMStatus in long mode
* stash
* fix max gas
* fix and clean up tests
* clean up longitudinal tests into a common class
* fix pylint
* subclass
* clean that up
* rm
* blocking
* comment
* comment
* lower case
* brake bus
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* h90d safety
* quicker rate
* update comment
* support multi frames?
* stash
* stash
* might work?
* stash
* clean up
* revert that
* add test
* fixup tests
* clean up
* remove test
* try to combine tests
* Revert "try to combine tests"
This reverts commit f147955b94119eca0abd1b605844ab5002fb0305.
* seems simpler
* more explicit
* shouldn't be needed
* no hyundai stuff
* no line
* consecutively
* comment
* comment
* comment
* revert
* comment
* check earlier
check earlier
* ensure we don't set a negative value
* add todo comments
* for loop
* Match openpilot brake check
* comment
* simple
* Update test
* doesn't take an int
* msg varies in size by platform
* 2 extra bytes of zeros on Escalade
* label platforms
* space
* allow sending steering buttons msg to camera
The DBC lists both the IPMA and PCM as receiving modules for the `CcAslButtnCnclPress` and `CcAsllButtnResPress` signals used to cancel/resume ACC.
Sending resume to both buses is confirmed to work by three testers, now it's just down to tweaking openpilot to get high reliability.
* add test for both buses
* only send TJA to bus 2
* it was only checking a specific bit
* same check as openpilot
* reset on init
* unsigned
* should fix conflicts
* common
* comment
* Add missing function
* Tests
* the alternative is a mess
typo
typo
* draft
* finish common
* works but you need RegenSafetyTest before all other classes
* Revert "works but you need RegenSafetyTest before all other classes"
This reverts commit 256f3be9a86e2412220d473037d64b84167ae98d.
* This works too
* need parameterized, subtests nor super() calls correctly reset state
* Fix test and comment
* comment
* another fix...
* subclass
* ABC
* order
* fix static analysis
* can do this
* Revert "can do this"
This reverts commit 6bc63a345a2d63019a640092dd9538203e8b213d.
* this is nicer, no pylint errors
* Update tests/safety/common.py
* underscore
* dynamically detect and add tests
* simpler
* only for safety modes with a regen message
* check attr
* Revert "check attr"
This reverts commit bc37a7eedd2269bb3bc77d96762f0f0df6890991.
* need to check at test time not class init time
* toyota steer fault safety
* fix
* alternative safety
* no comment
* should be good
* same behavior, a bit simpler
* better tests
* fix comment
* update safety comment
* const is actual number of messages
* Fix bug
* misra
* Fix test
* clean up logic a bit
clean up logic a bit
fix
* fix
fix
* clean up tests
* unsigned
* forgot to rename message when merged
* Comments
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update names
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* rename rest of variables
* real time checks
* clean up safety tests
* revert
* add this
* clean up
* better name
* use common steering checks
* reverse order
* make common
* re-organize the safety
* clean up safety_toyota
* more clean up
* add comment back
* 19
* recover
* some variable name clean up
* rename and reset `valid_steering_msg_count`, another recover message
* move comment
* remove reset_toyota_timer, minor test clean up
* common test
* use init_tests
* threshold used to be: frame you can cut steer on, now it's min num of valid frames (next frame you can cut, 18+1)
* Update tests/safety/test_toyota.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* fix realtime
* Update board/safety/safety_toyota.h
* Apply suggestions from code review
* Update board/safety/safety_toyota.h
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
