diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 80bb697e..9ba57906 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,6 +1,6 @@ repos: - repo: https://github.com/pre-commit/pre-commit-hooks - rev: v4.5.0 + rev: v5.0.0 hooks: - id: check-ast - id: check-yaml @@ -9,29 +9,33 @@ repos: - id: check-executables-have-shebangs - id: check-shebang-scripts-are-executable - repo: https://github.com/codespell-project/codespell - rev: v2.3.0 + rev: v2.4.1 hooks: - id: codespell + args: + - -L tge,stdio exclude: '\.dbc$' -- repo: https://github.com/pre-commit/mirrors-mypy - rev: v1.11.1 - hooks: - - id: mypy +# TODO: too slow. replace with ty when it's ready +#- repo: https://github.com/pre-commit/mirrors-mypy +# rev: v1.11.1 +# hooks: +# - id: mypy - repo: https://github.com/astral-sh/ruff-pre-commit - rev: v0.5.7 + rev: v0.11.9 hooks: - id: ruff - repo: https://github.com/MarcoGorelli/cython-lint - rev: v0.16.0 + rev: v0.16.6 hooks: - id: cython-lint - id: double-quote-cython-strings -- repo: https://github.com/cpplint/cpplint - rev: 1.6.1 - hooks: - - id: cpplint - args: - - --quiet - - --counting=detailed - - --linelength=240 - - --filter=-build,-legal,-readability,-runtime,-whitespace,+build/include_subdir,+build/forward_decl,+build/include_what_you_use,+build/deprecated,+whitespace/comma,+whitespace/line_length,+whitespace/empty_if_body,+whitespace/empty_loop_body,+whitespace/empty_conditional_body,+whitespace/forcolon,+whitespace/parens,+whitespace/semicolon,+whitespace/tab,+readability/braces +# TODO: enable this and fix all the errors +#- repo: https://github.com/cpplint/cpplint +# rev: 2.0.2 +# hooks: +# - id: cpplint +# args: +# - --quiet +# - --counting=detailed +# - --linelength=240 +# - --filter=-build,-legal,-readability,-runtime,-whitespace,+build/include_subdir,+build/forward_decl,+build/include_what_you_use,+build/deprecated,+whitespace/comma,+whitespace/line_length,+whitespace/empty_if_body,+whitespace/empty_loop_body,+whitespace/empty_conditional_body,+whitespace/forcolon,+whitespace/parens,+whitespace/semicolon,+whitespace/tab,+readability/braces diff --git a/opendbc/can/packer_pyx.pyx b/opendbc/can/packer_pyx.pyx index fb214617..2d633dee 100644 --- a/opendbc/can/packer_pyx.pyx +++ b/opendbc/can/packer_pyx.pyx @@ -21,7 +21,7 @@ cdef class CANPacker: cdef string cpp_dbc_name if isinstance(dbc_name, str): - cpp_dbc_name = dbc_name.encode('utf-8') + cpp_dbc_name = dbc_name.encode("utf-8") else: cpp_dbc_name = dbc_name with nogil: diff --git a/opendbc/can/parser_pyx.pyx b/opendbc/can/parser_pyx.pyx index 6815ad51..ca8f475c 100644 --- a/opendbc/can/parser_pyx.pyx +++ b/opendbc/can/parser_pyx.pyx @@ -63,7 +63,7 @@ cdef class CANParser: cdef string cpp_dbc_name if isinstance(dbc_name, str): - cpp_dbc_name = (dbc_name).encode('utf-8') + cpp_dbc_name = (dbc_name).encode("utf-8") else: cpp_dbc_name = dbc_name # Assume bytes cdef int cpp_bus = bus diff --git a/opendbc/car/honda/interface.py b/opendbc/car/honda/interface.py index d92bcc24..29cf923c 100755 --- a/opendbc/car/honda/interface.py +++ b/opendbc/car/honda/interface.py @@ -72,7 +72,7 @@ class CarInterface(CarInterfaceBase): # Civic Type R is missing 0x191 and 0x1A3 elif candidate == CAR.HONDA_CIVIC_2022 and all(msg not in fingerprint[CAN.pt] for msg in (0x191, 0x1A3)): ret.transmissionType = TransmissionType.manual - # New Civics dont have 0x191, but do have 0x1A3 + # New Civics don't have 0x191, but do have 0x1A3 elif candidate == CAR.HONDA_CIVIC_2022 and 0x1A3 in fingerprint[CAN.pt]: ret.transmissionType = TransmissionType.cvt diff --git a/test.sh b/test.sh index e3a6e7f4..1c01373d 100755 --- a/test.sh +++ b/test.sh @@ -11,8 +11,7 @@ scons -j8 # *** lint *** # TODO: pre-commit is slow; replace it with openpilot's "op lint" -#pre-commit run --all-files -ruff check . +pre-commit run --all-files # too many false positives atm :( #ty check .