Commit Graph

237 Commits

Author SHA1 Message Date
Ewout ter Hoeven
55390d273f Convert format strings strings to f-strings (#23241)
* Convert all text strings to f-strings

Reformats all the text from the old "%-formatted" and .format(...) format to the newer f-string format, as defined in PEP 498. This requires Python 3.6+.

Flynt 0.69 was used to reformat the strings. 120 f-strings were created in 51 files.

F-strings are in general more readable, concise and performant. See also: https://www.python.org/dev/peps/pep-0498/#rationale

* revert pyextra changes

* revert ublox.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-12-16 14:58:17 +01:00
Dean Lee
f042962933 put logcat in bootlog (#23217)
* put logcat in boot log

* continue

* use std::unique_ptr

* Revert "use std::unique_ptr"

This reverts commit c671f8ca7160691791bade508c4a8eb5cdb73fb8.
2021-12-14 11:54:54 -08:00
Dean Lee
4aa291c406 Use std::unique_ptr to manage memory (#23168)
* use unique_ptr

* trigger ci

* move down loggerdstate
2021-12-13 14:16:53 +01:00
Dean Lee
cfad1f35e8 RawLogger: fix wrong pts (#23205) 2021-12-13 11:46:52 +01:00
Dean Lee
9decd3d8a2 util: move all functions into util namespace (#23203) 2021-12-12 14:42:23 -08:00
Adeeb Shihadeh
5f36b48199 loggerd: fix delayed exit from main thread 2021-12-07 18:22:00 -08:00
Willem Melching
2e0c73fc0c Remove Raw Upload toggle (#23143)
* Remove Raw Upload toggle

* fix tests
2021-12-07 11:25:40 +01:00
Adeeb Shihadeh
f71a03f967 increase loggerd per-cycle service limit to 200 2021-12-06 22:08:17 -08:00
Adeeb Shihadeh
baf1a77ca2 loggerd: don't let a single service clog up the main thread 2021-12-06 19:31:11 -08:00
Dean Lee
ddc612e9f6 LogCameraInfo: remove unused variables (#23142) 2021-12-06 14:25:28 +01:00
Dean Lee
480fb54926 move struct LogCameraInfo into loggerd.h (#23129) 2021-12-04 21:08:55 -08:00
grekiki
6951b3271d Python: Replace more lists with generators (#23116)
* Replace lists with generators v2

* Replace set with {}

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Replace more set() with {}

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-12-03 22:57:19 -08:00
Dean Lee
348d2d2b0d rename yuv streams (#23071)
* rename yuv streams

* bump cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-11-29 18:14:59 -08:00
Willem Melching
f7c46c6949 Do not run code on version.py import (#23063)
* Do not run code on version.py import

* fix athena
2021-11-29 19:38:55 +01:00
Willem Melching
a2f32fd3e1 Clear loggerd locks once on boot (#23060)
* add test for clear_locks

* move to bootlog

* simplify test
2021-11-29 12:30:28 +01:00
Dean Lee
1d323e0fd6 loggerd: add test case for trigger_rotate (#23038)
* test rotate

* remove global LoggerdState
2021-11-26 14:53:09 +01:00
Dean Lee
b5eb02181c loggerd: add test case for sync_encoders (#23020) 2021-11-24 13:34:16 -08:00
Dean Lee
75dd0d6296 loggerd: split loggerd.cc into three files 2021-11-23 17:53:49 -08:00
Adeeb Shihadeh
e13630dfee faster jenkins (#22973)
Co-authored-by: Comma Device <device@comma.ai>
2021-11-18 23:43:09 -08:00
Willem Melching
23a1f47817 uploader: switch to upload_url v1.4 (#22966) 2021-11-18 16:23:50 +01:00
Willem Melching
77b334a698 swaglog.py: respect LOGPRINT env variable (#22950)
* swaglog.py: respect LOGPRINT env variable

* only change handler that prints

* keep usefull manager prints

* only print running list

* revert process changes

* fix test
2021-11-18 16:05:06 +01:00
Adeeb Shihadeh
ea761cbbd5 loggerd: trigger rotate on frame id instead of frame count (#22848)
Co-authored-by: Comma Device <device@comma.ai>
2021-11-13 15:38:10 -08:00
Willem Melching
fa0cbe5d40 Put journal and nvme stats in bootlog (#22849)
* Run commands and put output in bootlog

* log nvme

* fix indent

* cereal without event

* use regular array
2021-11-10 16:07:22 +01:00
Dean Lee
0bd9aed82c loggerd/RawLogger: fix memory leak in encode_frame (#22826) 2021-11-08 15:27:51 -08:00
Willem Melching
45c506bb17 wshadow: fix comma three build 2021-11-02 17:27:34 +01:00
Mayfield
5246f0231e enable wshadow (#22756)
* enable wshadow (#22714)

* fix replay

* more build fixes

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-11-02 17:08:53 +01:00
Dean Lee
2b4a477fbc replay: improve segment download and merge (#22654)
* no-cache mode

* fix test cases build error

* space

* don't create cache dir in no-cache mode

* fix errors in test cases

* no_local_cache_

* set the number of connections by chunk_size

* use size_t instead of int64_t

* add test case for no-cache mode

* rename variables

* fix SIGSEGV

* cleanup

* faster decompressBZ2

* always decompress bz2

* add test cases

* prepare for python interface

* fix test cases build error

* continue

* camera_replay: cache remote file

* protected inheritance

* single option name

* TODO

* test_case for LogReader&FrameReader

* fix wrong require

* test case for FileReader

* cleanup test

* test:fix wrong filename

* check cached file's checksum

* fix mkdir permissions err

cleanup filereader

* remove initialize libav network libraries.

dd

* abort all loading if one failed

* cleanup tests

* use threadpool to limit concurrent downloads

* cache more segments

* merge 3 segments for replay

* one segment uses about 100M of memory

* use segments_need_merge.size()

* shutdown

* fix stuck if exit replay  before keyboard thread started

* load one segment at a time

* small cleanup

* cleanup filereader

* space

* tiny cleanup

* merge master

* cleanup test cases

* use util:create_directories

* cleanup framereader
2021-11-01 11:55:56 +01:00
Dean Lee
652c42da2c util: add safe write functions (#22160)
* add safe write functions

* log error

* bzfile safe_fopen&safe_flush

* update test_case

* trigger ci

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-10-29 13:23:31 +02:00
Dean Lee
1f39d8cee6 util: add new function create_directories with unit tests (#21871)
* util::create_directories

* check bool ret

* don't assume mask

* rename with_umask to no_umask

* remove umask

* rebase master

* rebase master

* 0755
2021-10-29 12:27:35 +02:00
Dean Lee
18caf3535b loggerd: fix concurrency issues in sync encoders (#22590)
* sync_encoders

* add variable camera_synced

* cleanup
2021-10-29 12:21:02 +02:00
Adeeb Shihadeh
5b331fd6f5 don't set core affinity on PC (#22706) 2021-10-26 21:51:46 -07:00
Willem Melching
89f311714c loggerd: set encodeIdx.valid if frame id is correct (#22634)
* loggerd: set encodeIdx.valid if frame id is correct

* check valid flag in test

* test cleanup

* bump cereal
2021-10-26 16:00:43 +02:00
Adeeb Shihadeh
76bd932cf5 loggerd: always run encoders (#22649)
* loggerd: always run encoders

* fix raw logger

* bump loggerd cpu usage
2021-10-21 16:37:03 -07:00
Adeeb Shihadeh
84de248fa7 tici: affine loggerd to efficiency cores (#22581) 2021-10-18 13:21:24 -07:00
Dean Lee
d28b98c602 replay : move utility functions into separate file (#22414)
* move functions into util

* read bz2 into stream

* pre-decompress log in the download thread

* cleanup logreader

* cache sha256 path

* use readBZ2file in test_logger

* Revert "cache sha256 path"

This reverts commit 60459d3ea09a2c80f4560cf95b1ce7d6af59f06d.

* use macro

* use ostringstream

* cleanup readBZ2File

* move precise_nano_sleep into util
2021-10-04 15:39:59 +02:00
Robbe Derks
3ccf712ac9 small typo 2021-09-24 10:23:41 +02:00
Adeeb Shihadeh
0f8c6f130b add log docs 2021-09-23 14:41:35 -07:00
ntegan1
54b5972cf6 Upload when on ethernet (#22188)
in addition to when on wifi

Co-authored-by: ntegan <nick@egan.gg>
2021-09-10 12:05:12 -07:00
Willem Melching
377fe84948 remove loggerd todo about encodeIdx decimation 2021-09-08 12:16:16 -07:00
Dean Lee
8bca70878f loggerd: remove obsolete ethernetsniffer.py (#22139) 2021-09-06 12:11:19 -07:00
Dean Lee
5a8ca8b449 loggerd: remove obsolete testraw.cc (#22138) 2021-09-06 12:10:12 -07:00
Willem Melching
48035e9535 Disable encoder sync logic if only one rotate camera present (#22107)
* disable sync logic if only one rotate camera

* consistent brackets
2021-09-01 23:08:06 -07:00
Willem Melching
a93271a518 Ensure that first segment starts with all cameras on the same frameId (#22096)
* test that segment starts with the same frame id

* improve test

* add sync logic

* atomic max

* review comments
2021-09-01 14:28:50 -07:00
Dean Lee
f02c8d0e2c Handle EINTR for all syscalls that can return it (#21948) 2021-08-31 16:22:56 -07:00
Dean Lee
d9baaf7eb9 loggerd: create encoder threads from cameras_logged (#21875) 2021-08-30 19:33:00 -07:00
Dean Lee
935cbd3139 LoggerState: test cases (#21855)
* test multiple threads writing to log

* fix typo

* use util::getenv

* check INIT_DATA and SENTINEL

* test END_OF_SEGMENT

* add comment

* test multiple threads logging and rotation

* cleanup

* update

* LoggerHandle:quick fix

* cleanup

* revert test_loggerd.py

* refactor test case

* check lock file

* check refcnt after close

* test_runner.cc

d

* int eixt_signal
2021-08-30 17:12:09 -07:00
Willem Melching
dddab597bc Less open file permissions (#21922)
* Less open file permissions

* add test back

* remove params test for permissions

* remove umask

* bump cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-08-28 18:25:05 -07:00
Adeeb Shihadeh
54a4eeb0fc Revert "tici: give loggerd rt priority (#21503)"
This reverts commit 7e2752c878.
2021-08-22 16:57:53 -07:00
Adeeb Shihadeh
7e2752c878 tici: give loggerd rt priority (#21503)
* give loggerd rt priority

* assert

* little more

Co-authored-by: Comma Device <device@comma.ai>
2021-08-20 21:27:31 -07:00
Dean Lee
c6a34dd9f7 capnp:Text::Reader: use implicit conversion from string (#21980) 2021-08-19 13:49:08 -07:00