Commit Graph

120 Commits

Author SHA1 Message Date
Adeeb Shihadeh
8068df0b2a alerts: escalate soft disable alert near disengagement (#23198)
* alerts: escalate soft disable alert if resulted in disengagement

* show 0.5s before disengagement
2021-12-11 17:07:37 -08:00
Adeeb Shihadeh
07b971d473 alerts: handle min duration properly (#23191)
* alerts: handle min duration properly

* add active

* tests

* cleanup test

* update refs
2021-12-10 19:20:07 -08:00
Adeeb Shihadeh
4627d201b6 alert text simplification (#23186)
* alert text simplification

* little more

* user triggered

* little more

* less annoying ldw

* Update selfdrive/controls/lib/events.py

* update refs

* revert
2021-12-10 15:21:37 -08:00
Adeeb Shihadeh
3b367e6872 Newer sounds (#23091)
* new prompt sound

* padding

* prompt distracted

* debug

* fix spelling

* lower min volume

* better volume at low speeds

* revert debug

* revert that

* fix tests

* update refs

Co-authored-by: Comma Device <device@comma.ai>
2021-12-02 00:28:25 -08:00
Adeeb Shihadeh
e679d05d9e New sounds (#22652)
* new engage/disengage + amp config

* first family

* cleanup audible alerts

* tici isn't special

* fix up debug cycle alerts

* these were better

* extend range

* use distracted sound

* log scaling

* getting closer

* slightly louder

* prompt

* update tests

* update refs

* fix c2 test

* resolve todo

* adjust tolerance

* revert for now

* should work

Co-authored-by: Comma Device <device@comma.ai>
2021-11-30 19:47:33 -08:00
Adeeb Shihadeh
5296ca8d73 improve crc camera error (#22943) 2021-11-16 22:57:22 -08:00
Adeeb Shihadeh
833399e941 alerts: make soft disables an orange alert (#22925) 2021-11-16 13:11:32 -08:00
Adeeb Shihadeh
3302239013 put cruiseMismatch event in logging only mode 2021-11-15 21:16:54 -08:00
Adeeb Shihadeh
5265c36de7 alert cleanup (#22919) 2021-11-15 16:14:31 -08:00
Adeeb Shihadeh
308219c5b1 alerts: use repeating warning2 sound for steerSaturated (#22874) 2021-11-11 11:55:34 -08:00
Adeeb Shihadeh
327464fb84 increase engagement alerts duration 2021-11-10 22:11:14 -08:00
Adeeb Shihadeh
035bc0c20f controlsd: alert on cruise mismatch for >1s (#22841)
* controlsd: alert on cruise mismatch for >1s

* bump cereal

* update refs

* bump allowed soundd cpu

* bump cereal
2021-11-10 13:01:42 -08:00
Adeeb Shihadeh
c5d6b85c90 alerts: use a single duration for sound, text, and HUD (#22856)
* alerts: use a single duration for sound, text, and HUD

* little cleanup

* update refs
2021-11-10 11:54:12 -08:00
Adeeb Shihadeh
93ba52c76c controlsd: optimize alert management (#22846)
* controlsd: optimize alert management

* little cleanup

* dataclass is nice

* fix tests

* update refs

* sort by start frame

* update refs

Co-authored-by: Comma Device <device@comma.ai>
2021-11-10 10:54:18 -08:00
Adeeb Shihadeh
445a5aaca4 soundd: don't loop controls unresponsive sound infinitely (#22839)
* soundd: don't loop controls unresponsive sound infinitely

* update tests

* actually fix
2021-11-09 16:58:21 -08:00
Mayfield
8c501f0265 alerts: show min enable speed in "speed too low" alert (#22755)
* alerts: show min enable speed in "speed too low" alert

* commonize display speed construction
2021-11-02 14:10:07 +01:00
Adeeb Shihadeh
3312bf6d15 lower profile below steer speed alert (#22740) 2021-10-29 13:39:12 -07:00
Adeeb Shihadeh
897492d27c more specific no fw startup alert 2021-10-21 16:24:01 -07:00
Willem Melching
f4e2537b12 Split pandaState into peripheralState and pandaState (#22385)
* publish peripheralState from boardd

* refactor consumers

* rename thread

* peripheralState has panda type too

* add to process replay

* fix device build

* properly remove hardware unsupported alert

* latest peripheralState

* remove pandaState from thermal_monitor

* put that back

* add back harness check

* fix cloudlog

* needs pandaState

* Update selfdrive/thermald/tests/test_power_monitoring.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* dont conflate

* Update selfdrive/thermald/tests/test_power_monitoring.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* pigeon is peripheral

* cleanup

* less global

* comment

* move rtc to peripheral_control_thread

* better diff?

* whitespace

* get msg

* bump cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-10-04 11:30:11 +02:00
Adeeb Shihadeh
2fe91e6085 change reverse gear event from immediate to user disable (#22337) 2021-09-24 10:27:51 -07:00
Willem Melching
88d248a5af Remove fuzzy fingerprint startup alert (#22328)
* deprecate fuzzy fingerprint startup alert

* bump cereal
2021-09-23 17:15:33 -07:00
Adeeb Shihadeh
1c750975fc reduce startup alert duration to 10s (#22163)
* reduce startup alert duration to 10s

* update refs

* update refs

* update refs
2021-09-07 13:40:31 -07:00
Adeeb Shihadeh
fc8b571a84 alert for per-core cpu usage (#21983)
* thermald: per-core cpu usage

* add alert

* better alert text

* list

* fix process replay
2021-08-19 19:14:51 -07:00
HaraldSchafer
c0cacc7d2f Remove HUD alert from green DM alert (#21942) 2021-08-16 22:30:51 -07:00
HaraldSchafer
aa689176fc Cleaner lane change alerts (#21857)
* less is more

* small

* remove HUD warnings

* update ref

* safe

* update refs

* update again

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-08-05 14:23:27 -07:00
Adeeb Shihadeh
fb028041cd remove alert for stock fcw (#21834) 2021-08-02 21:59:03 -07:00
HaraldSchafer
049a1bca34 Better localizer unstable alert (#21660)
* use canonical language

* filter out when gps signal is flaky

* Update selfdrive/locationd/locationd.cc

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-07-20 19:20:00 -07:00
Adeeb Shihadeh
092c728e76 fix unnecessary harsh steering unavailable alerts (#21541) 2021-07-10 01:53:14 -07:00
HaraldSchafer
2aadf8beb2 Remove DM high std alert (#21501)
* cleaner

* no face and high stds is the same

* change test

* final clean

* need to deprecate
2021-07-07 17:08:55 -07:00
Adeeb Shihadeh
8dce135279 update speedTooHigh alert sound (#21484) 2021-07-04 19:23:09 -07:00
Adeeb Shihadeh
8e36a7d07c fix warning -> userPrompt 2021-06-28 21:46:26 -07:00
Adeeb Shihadeh
880435f6a2 make speed too high alert orange 2021-06-28 21:42:25 -07:00
Chris McCammon
317afa335f steer unavailable below speed audible alert (#21209) 2021-06-17 14:10:24 -07:00
ShaneSmiskol
ae77f693a2 Fixup joystick (#21129)
* some common changes

* rename to joystick

* add alert and update controlsd to work with joystick

* update joystickd

* Update Joystick readme

* assume we have inputs

* only send gb or steer when engaged_toggle is true

* Update instructions

* fix --ip

* Easier to understand at a glance

* much better

* -a

* receive events and send msg in same loop

* always import

* Update selfdrive/controls/lib/events.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/controls/lib/events.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* combine logic and clean up

* use argparse

* outdated, and use normal class

* rm

* bit of a refactor

* refactor part 2 / 3

* much better (3 / 3)

* Simplify

* bump cereal and update readme

* capitalize

* Update tools/joystick/joystickd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update tools/joystick/joystickd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* make joystick abstraction class clearer

* use interp, clearer without comments

* no need to use apply_deadzone

* more explicit

* define btns and axes once

* split function by use_keyboard again, but simpler

* we can use handle_button as a reset function

* need to flip sign

* remove

* invert axes map for kb, easier to read the button mapping

* apply changes from review

* new lateral log for debug mode

* bump

* add saturated

* static alert

* joystick_mode

* conditionally subscribe

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* move params instantiation

* Spoof active and enabled

* Only allow car to engage

* no startup alert if joystick

* Update controlsd.py

* Should be orange not enabled, green enabled

* no more button states

* should work

* blue

* submaster conflates, so only send when we have an update

* final change

* remove msg

* clean up a bit

sort of clean up

clean up a bit

remove msg

* this was right

* Apply suggestions from code review

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* lowercase

* suggestions from code review

* forgot laptop

* bump to latest

* fixes

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: vanillagorillaa <31773928+vanillagorillaa@users.noreply.github.com>
2021-06-11 14:33:17 -07:00
Willem Melching
ec17fad41a Alerts documentation (#21172)
* Alerts documentation

* fingerprinting

* comment not necessary

* spelling

* openpilot

* Apply suggestions from code review

Co-authored-by: Chris McCammon <chrismccammon123@gmail.com>

* Apply suggestions from code review

Co-authored-by: Chris McCammon <chrismccammon123@gmail.com>
2021-06-09 10:58:01 +02:00
CrispinFlowerday
7458e143e3 Subaru: show LDW on dash for correct lane (#20934)
* Emit correct alerts for LDW Left & Right on Subarus

This change switches the ldw event to use VisualAlert.ldw and
alters all cars to use the prior behaviour for that alert, except
global subarus - they emit the correct warning to the dash

* Remove whitespace, and add comment about not overwriting stock alerts

Co-authored-by: Crispin Flowerday <crispin@theflowerdays.com>
2021-06-07 15:06:28 -07:00
Adeeb Shihadeh
d4ab1f1e27 startup alert for no fw returned (#21177) 2021-06-07 14:15:09 -07:00
speedking456
24b6b4a341 Add chime to lane changed blocked alert (#21159)
* Update carcontroller.py

* Lane change blocked orange + audible alert

* Actually make it make sound

* Update carcontroller.py

* leave priority the same
2021-06-07 01:38:08 -07:00
Adeeb Shihadeh
f2a9b13498 bump cereal 2021-06-04 16:06:57 -07:00
HaraldSchafer
1c926d23da Many localizer resets alert (#21116)
* add excessive reset

* add alert

* add event
2021-06-03 09:26:53 -07:00
Adeeb Shihadeh
12ed986333 per camera alerts (#20992)
* per camera alert

* bump cereal

* cleanup

* space
2021-05-21 14:53:30 -07:00
Adeeb Shihadeh
2defc730db alert for errors in camera stack (#20932)
* camera error alert

* check crcs

* cleanup

* bump cereal

Co-authored-by: Comma Device <device@comma.ai>
2021-05-19 21:28:16 -07:00
Adeeb Shihadeh
e694f0b4d6 boardd: set can and pandaState valid flags (#20899)
* boardd: set can and pandaState valid flags

* add event

* bump cereal

* consistency
2021-05-14 21:26:02 -07:00
Willem Melching
b38e57eb2b Improve community feature alert text (#20803) 2021-05-03 11:59:01 +02:00
Adeeb Shihadeh
f9a961f6fb delay controls start (#20761)
* delay controls start

* shouldn't need this stuff anymore

* only delay board

* bail after 2s

* fix loopback test

* fix process replay

* update refs

* bump cereal

Co-authored-by: Comma Device <device@comma.ai>
2021-04-30 13:55:17 -07:00
Adeeb Shihadeh
836668f105 less harsh steering unavailable alert when overriding (#20718)
* less harsh steering unavailable alert when overriding

* just steer

* 1s

* orange

* update refs
2021-04-20 21:01:28 -07:00
Willem Melching
e4f73fbda5 Fuzzy match on ECU FW versions (#20687)
* Fuzzy match on 3+ ECUs

* reuse dict

* exclude some shared ecus to be sure

* show alert for fuzzy match

* use title case

* require community toggle

* refactor

* do both exact and fuzzy in test script

* update test script

* add fuzz test and lower matches to >= 2

* strip alert length

* sort mismatches

* add fw tests to test_startup

* bump cereal
2021-04-20 12:00:36 +02:00
Adeeb Shihadeh
2fa1b2572d Alerts update (#20567)
* steer temp unavailable should be a soft disable

* no mute

* these should be no entries

* sound

* better name

* deprecated

* make vehicleModelInvalid a soft disable

* update refs

* bump cereal

* bump cereal

* update refs
2021-04-07 12:18:58 -07:00
Adeeb Shihadeh
367aec54d1 show persistent dashcam mode alert (#20483)
* always show dashcam mode alert

* show persistent dashcam mode alert

* lowest

Co-authored-by: Comma Device <device@comma.ai>
2021-03-25 21:37:38 -07:00
Willem Melching
2ca5bf9992 make vehicleModelInvalid a NoEntry 2021-03-15 12:15:27 +01:00