Commit Graph

33 Commits

Author SHA1 Message Date
Dean Lee
9decd3d8a2 util: move all functions into util namespace (#23203) 2021-12-12 14:42:23 -08:00
Willem Melching
fa0cbe5d40 Put journal and nvme stats in bootlog (#22849)
* Run commands and put output in bootlog

* log nvme

* fix indent

* cereal without event

* use regular array
2021-11-10 16:07:22 +01:00
Dean Lee
ff33ca3413 util: remove function to_hex (#22792) 2021-11-04 16:18:01 +01:00
Dean Lee
8da3cd3cdd util:: remove unused funtion base_name (#22759) 2021-10-31 13:10:27 -07:00
Dean Lee
652c42da2c util: add safe write functions (#22160)
* add safe write functions

* log error

* bzfile safe_fopen&safe_flush

* update test_case

* trigger ci

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-10-29 13:23:31 +02:00
Dean Lee
1f39d8cee6 util: add new function create_directories with unit tests (#21871)
* util::create_directories

* check bool ret

* don't assume mask

* rename with_umask to no_umask

* remove umask

* rebase master

* rebase master

* 0755
2021-10-29 12:27:35 +02:00
Adeeb Shihadeh
84de248fa7 tici: affine loggerd to efficiency cores (#22581) 2021-10-18 13:21:24 -07:00
Dean Lee
83710b14ee fix: util::read_files_in_dir does not always return a correct result (#21883)
* fix bug

* use de->d_type==DT_REG

* Revert "use de->d_type==DT_REG"

This reverts commit ecb38c82305ea23bfec84284aa77be5b5c64957a.
2021-09-01 15:10:59 -07:00
Dean Lee
f02c8d0e2c Handle EINTR for all syscalls that can return it (#21948) 2021-08-31 16:22:56 -07:00
Dean Lee
3a7959b5ff fix: util::file_exists will return false on no permissions (#21880)
* fix bug

* add test case
2021-08-09 11:56:45 +02:00
Dean Lee
fefc70b4ca hw.h: move Hardware-related paths to namespace Path (#21826)
* refactor getenv and path

* apply review
2021-08-04 13:29:03 +02:00
Dean Lee
073b96e5d1 qt/util: new function getDongleId (#21810)
* new function getDongleId

* return std::optional
2021-08-02 11:21:51 +02:00
Dean Lee
11ffbc6936 util/read_files_in_dir: return map by value (#21815) 2021-08-02 10:59:54 +02:00
Willem Melching
86630effcf bump date in time_valid check 2021-06-30 12:18:53 +02:00
Dean Lee
ac71384a28 util.cc: refactor read_file (#21350) 2021-06-22 13:48:41 -07:00
Adeeb Shihadeh
d90d9b2280 util::read_file: fix reading from sysfs and add test case (#21325)
* add sysfs test case

* Revert "util.cc: refactor read_file (#21321)"

This reverts commit 8d5c61eefe.
2021-06-18 01:34:52 -07:00
Dean Lee
8d5c61eefe util.cc: refactor read_file (#21321)
* mode read & open once

* change return statement for better readibility

* apply reviews

* can't open with ate flag
2021-06-17 23:19:41 -07:00
Adeeb Shihadeh
7dec206437 Revert "util.cc: refactor read_file (#21295)"
This reverts commit 190a845505.
2021-06-17 15:02:48 -07:00
Dean Lee
190a845505 util.cc: refactor read_file (#21295)
* mode read & open once

* change return statement for better readibility

* apply reviews

* Update selfdrive/common/util.cc

* fix

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-06-17 14:03:07 -07:00
Dean Lee
a873a23e0d common/util.cc: add unit test, fix bug in util::read_file (#21251)
* add test case for util

* fix bug in read_file

* gitignore test_util

* better test

* referer

* more

* more test

* REQUIRE size

* apply reviews

* only test binary

* simplify the test

* read  non-permission

* debug print

* remove /etc/shadow

* test read directory

* Update selfdrive/common/tests/test_util.cc

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-06-16 11:01:13 +02:00
Willem Melching
e85fa7f1c9 UI: check if dongle id is valid before calling API (#21275) 2021-06-15 14:10:44 +02:00
Dean Lee
e4e669bb0f add space after function name and if statement (#21225) 2021-06-11 10:17:52 +02:00
Dean Lee
ee46672d3c Passing arguments by reference (#21205) 2021-06-09 14:09:02 +02:00
Dean Lee
c53cb5d570 Use C++ header files instead of C header files. (#21192)
* use cstring instead of string.h

* use cstdio instead of stdio.h

* remove inttypes.h

* use cstdlib instead of stdlib.h

* use cstdint instead of stdint.h

* #include <cstddef>

* cstdlib

* use cmath

* remove stddef.h

* use cassert

* use csignal

* use ctime

* use cerror

* rebase master
2021-06-08 13:46:22 -07:00
Dean Lee
65e0b1e699 Cleanup util.h (#20849)
* cleanup util.h

* fix build error:omx_encoder.cc:408: undefined reference to do_exit

* fix build error

* rebase master

* move helper functions back to util

* ExitHandleHelper->ExitHandlerHelper

* std::clamp

* struct ExitHandlerHelper to class

* rebase master

* cleanup

* restore ExitHandler

* prefer cassert
2021-06-01 16:53:12 +02:00
Dean Lee
c08ee575f8 read_files_in_dir: closedir before return (#20903) 2021-05-14 17:33:46 -07:00
Willem Melching
4742f55749 store all files in /sys/fs/pstore in bootlog (#20875)
* store all files in /sys/fs/pstore in bootlog

* whitespace

* fix bootlog test
2021-05-12 11:15:54 +02:00
Dean Lee
7222d0f20d Cleanup selfdrive/ includes (#20822)
* cleanup include path

* continue

* format includes

* fix testraw.cc

* remove include path from SConstruct

* regroup

* rebase master

* almost done

* apply review

* rename FileReader.xx to filereader.xx

* rename Unlogger.x->unlogger.x

* rename FrameReader.xx -> framereader.xx

* apply reviews

* ui.h

* continue

* fix framebuffer.cc build error:mv util.h up

* full path to msm_media_info

* fix qcom2 camerad

Co-authored-by: Comma Device <device@comma.ai>
2021-05-08 22:15:17 -07:00
Adeeb Shihadeh
d90136c1d0 ate sets failbit on some platforms 2021-04-13 14:40:40 -07:00
Comma Device
6f21993915 fix reading procfs files 2021-04-13 13:56:08 -07:00
Dean Lee
fe2f63849a util.cc: reduce two read_file functions into one (#20655)
* no need to malloc one extra byte

* combine two read_file into a faster one

* cleanup #include

* use resize

* apply suggestions from review

* space

* rebase master
2021-04-13 11:43:43 -07:00
Willem Melching
a94ba4fb8b Add watchdog check to manager (#20277)
* this should work but doesnt

* Only offroad

* works

* make it work offorad

* reduce diff

* cleanup

* need util

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-03-08 19:17:46 -08:00
Dean Lee
595830135b merge utilpp.h into util.h (#19710) 2021-01-10 14:57:32 -08:00