Commit Graph

65 Commits

Author SHA1 Message Date
Ewout ter Hoeven
55390d273f Convert format strings strings to f-strings (#23241)
* Convert all text strings to f-strings

Reformats all the text from the old "%-formatted" and .format(...) format to the newer f-string format, as defined in PEP 498. This requires Python 3.6+.

Flynt 0.69 was used to reformat the strings. 120 f-strings were created in 51 files.

F-strings are in general more readable, concise and performant. See also: https://www.python.org/dev/peps/pep-0498/#rationale

* revert pyextra changes

* revert ublox.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-12-16 14:58:17 +01:00
Willem Melching
4f1eb4278a Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
2021-12-16 13:08:20 +01:00
Jason Young
8a4ab7f46d VW MQB: Audi Q3 Mk2 (#23128) 2021-12-04 18:55:02 -08:00
Jason Young
819b7a120a VW MQB: Longitudinal prereqs (#23004) 2021-11-22 14:01:42 -08:00
Jason Young
ef38117219 VW MQB: Volkswagen T-Roc Mk1 (#22967) 2021-11-18 14:52:59 -08:00
Jason Young
053404c878 VW MQB: Volkswagen Polo Mk6 (#22811)
* VW MQB: Volkswagen Polo Mk6

* add to RELEASES
2021-11-07 11:10:52 -08:00
Jason Young
68333dce60 VW MQB: Volkswagen Taos Mk1 (#22653)
* VW MQB: Volkswagen Taos Mk1

* add test route
2021-10-21 20:26:33 -07:00
Robbe Derks
91987f38d4 Make pandaState and safetyMode a list (#22454)
* wip: move to pandaStates

* bump cereal

* wip: SafetyMode struct

* move to safetyMode

* fix typo

* this can be None

* fix potential empty pandaStates list

* fix thermald

* fix controlsd

* rename safetyModes to safetyConfigs

* update process_replay

* fix test_models

* bump cereal
2021-10-08 17:54:34 +02:00
Jason Young
f03ee4599e VW MQB: Fix min steer speed alerts (#22358) 2021-09-27 15:00:55 -07:00
Jason Young
0630c42602 VW MQB: Improve auto network location detect (#22351) 2021-09-27 10:12:26 -07:00
Adeeb Shihadeh
649af76fd4 remove community supported cars from community features (#22330)
* remove community supported cars from community features

* remove bosch and hkg long

* remove test case

* update refs
2021-09-23 17:34:52 -07:00
Jason Young
c51eba3fd6 VW MQB: Min steer speed support, other cleanup (#22324)
* VW MQB: Min steer speed support, other cleanup

* simplify

* more correct

* fix README
2021-09-23 15:12:57 -07:00
Jason Young
37acee843e VW MQB: Volkswagen Arteon Mk1 (#22297)
* VW MQB: Volkswagen Arteon Mk1

* add test route

* update release notes
2021-09-21 14:38:40 -07:00
Jason Young
869ae44ad3 VW MQB: Volkswagen Transporter/California T6.1 (#22283)
* VW MQB: Volkswagen Transporter/California T6.1

* reformat values

* update CARS

* add test route

* assume SWB for now

* Update RELEASES

* update platform comments
2021-09-20 13:41:39 -07:00
Jason Young
b7e74f3b24 VW MQB: Škoda Kamiq Mk1 (#22240)
* VW MQB: Škoda Kamiq Mk1

* footnote about the China market Kamiq
2021-09-15 11:29:37 -07:00
Jason Young
d5e6dd3d5b VW MQB: Škoda Karoq Mk1 round 2 (#22190)
* VW MQB: Škoda Karoq Mk1

* Update README

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-09-10 14:41:31 -07:00
Jason Young
5a4d03da29 VW MQB: Fixes for network location detection (#22174)
* VW MQB: Fixes for network location detection

* apply review suggestion

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* FP back to 100ms; VIN state poll at 50Hz

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-09-09 17:49:31 -07:00
Adeeb Shihadeh
82bd060a68 Revert "VW MQB: Škoda Karoq Mk1 (#22133)"
This reverts commit 04c50e5c0c.
2021-09-06 20:50:02 -07:00
Jason Young
04c50e5c0c VW MQB: Škoda Karoq Mk1 (#22133) 2021-09-06 19:56:50 -07:00
HaraldSchafer
1ac89f14aa Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-08-30 09:32:52 -07:00
Jason Young
b764261db2 VW MQB: Volkswagen T-Cross Mk1 (#21709)
* add support for 2021 VW T-Cross

* revert laika change

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-07-25 13:38:33 -07:00
Jason Young
4beda8e33c VW MQB: Auto network location detection (#21671)
* auto network location detection

* re-run CI after process_replay timeout fix

* different ext can bus ID handling
2021-07-25 13:31:15 -07:00
Jason Young
df0b92bbcd VW MQB: Cleanup and prep for gateway integration (#21667)
* cleanup and scoping fixes

* static analysis feels sad without this

* remove extra read of clutch switch signal

* don't check Motor_14 unless it's needed

* collect short CP/CS aliases together
2021-07-21 00:32:48 -07:00
Adeeb Shihadeh
c72d163e14 deprecate CP.enableCamera (#21509)
* deprecate CP.enableCamera

* more removal

* one more

* update refs
2021-07-07 14:59:18 -07:00
Jason Young
57cf9b1f39 VW MQB: Volkswagen Touran Mk2 (#21263)
* Add 2017 VW Touran (BIRB)

* Update README

* Autogratitude

* Add test route for VW Touran
2021-06-15 12:09:04 -07:00
Jason Young
db83cd7f84 VW MQB: Audi Q2 Mk1 (#21165)
* Add 2018 Audi Q2 (breckler)

* Update README

* Add test route

* Summarized autogratitude

* Revert "Summarized autogratitude"

This reverts commit e308e2afc1f4020528e1643f5da4976715a366da.
2021-06-07 01:34:22 -07:00
Jason Young
3a2893f11a VW MQB: Fix bug with HCA state handling (#21104)
* Improved HCA state and fault handling

* Apparently opendbc does an upper() on everything

* Update EPS HCA init state

* Make initial state "ready"
2021-06-04 19:12:42 -07:00
Jason Young
34b6c56021 VW MQB: SEAT Leon Mk3 (#21048)
* Add 2020 SEAT Leon (exclamation point ai)

* Add SEAT Leon to README

* Fix Leon model-year

* Add SEAT Leon test route

* thanks me!
2021-05-28 13:53:50 -07:00
Jason Young
4de1655d20 VW MQB: Škoda Octavia Mk3 (#21013)
* Add Skoda Octavia (cben, Saber422)

* Add Skoda Octavia to README

* Add to test_routes.py

* Remove non-viable test route

* Add test route for Octavia
2021-05-26 17:08:33 -07:00
Jason Young
28a28834b7 Allow openpilot engaged while in manumatic (#20999) 2021-05-24 18:10:39 +02:00
Jason Young
cca887f195 VW MQB: Volkswagen Atlas Mk1 (#20881)
* Add support for VW Atlas

* Add test route for VW Atlas

* Add Atlas to README
2021-05-11 15:00:31 -07:00
Samuel Keeley
f7ea2cd761 VW lane lines visual indicator changes (#20676)
* Improve VW HUD with laneless and LDW

* No longer depend on laneless param

* update behavior

* update note

* update test route to make CI happy\?

* Revert "update test route to make CI happy\?"

This reverts commit 21aeecacd578ee287eda52cb674a51611092f272.

* always show lane visibility

* notes

* notes

* spelling

* reality

* remove notes

Co-authored-by: Ambroos Vaes <ambroos@fb.com>
2021-04-27 11:40:19 -07:00
Adeeb Shihadeh
6c7ed8f2e4 enforce message checks in can parser (#20742)
* enforce message checks in can parser

* nissan

* vw

* hkg

* subaru

* toyota

* honda bosch

* gm

* honda nidec

* bump opendbc

* not all tss2 have bsm

* toyota fixes

* honda fixes

* vw fix

* fix subaru

* fix long tests

* update refs

* crv bsm
2021-04-25 12:52:16 -07:00
Jason Young
48fa8ffb33 VW MQB: Update to Audi A3 Mk3 (#20489)
* Add A3 and A3 e-tron FPv2

* Update README

* Catch up with model renaming

* Trim duplicate FW values

* Add 2014 A3 (bankster)

* Update model-year range

* Revert more model name changes

* Revert more model name changes

* More FW for 2017 A3 e-tron (fastzeek)

* Update A3 models and packages in README

* Update A3 packages again

* AUDI_A3 -> AUDI_A3_MK3

* Update test route reference

* CAN valid should pass for VW now

* Update process_replay route

* Expand tested A3 range (we have known 2014-15,17)

* Revert "CAN valid should pass for VW now"

This reverts commit 73a4b4886f572045ada05cd13e60790ca3e17a94.

* revert route changes and update refs

* update refs again

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-03-30 14:49:46 -07:00
Jason Young
e181fd7f0a VW MQB: Misc bugfixes and cleanup (#20540)
* Add LDW->SWA signal pass-through

* GC currently unused ACC_06 and LDW_02 signal data

* Split out Jetta GLI

* Pass in camera CAN parser now that we use it

* GC unused CarController param, camelCase->PEP8

* CAN valid should pass for VW now

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-03-30 13:59:17 -07:00
Jason Young
9c0bd99a4d VW MQB: Update to Volkswagen Golf Mk7 (#20498)
* Import all Golf FW values, update naming

* Update test reference drive

* Update supported years and models

* Sort and dedupe Golf SRS and fwdRadar FW

* Add 2016 Golf SportsVan (Calle), sort FW values

* Expand README to include all Golf variants

* Alphabetize README
2021-03-28 21:04:51 -07:00
Jason Young
85d0d521bd VW MQB: Škoda Superb Mk3 (#20500)
* Add 2018 Skoda Superb (johndoe)

* Propitiate test_fw_fingerprint unit test
2021-03-26 16:42:39 -07:00
Jason Young
5da6fced2b VW MQB: Volkswagen Passat Mk8 (#20493)
* Add VW Passat

* Add Passat legacy FP

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-03-26 15:03:41 +01:00
Jason Young
9ef0eee6b1 Add 2020 Skoda Scala (#20494)
Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-03-26 15:02:29 +01:00
Jason Young
32b59ba114 VW MQB: SEAT Ateca Mk1 (#20492)
* Add SEAT Ateca

* Add test route for Ateca

* Add Ateca to README

* Pull unnecessary comments
2021-03-26 15:01:31 +01:00
Jason Young
c253554b35 VW MQB: VW Jetta Mk7, Škoda Kodiaq Mk1 (#20487)
* Add VW Tiguan (jyoung8607)

* Update README and test_processes

* Moving test route to correct place

* Moving test route to correct place

* Fix candidate expression

* Add ignored fingerprints list

* Yo dawg I heard you like fingerprints..

* Support for Jetta, Passat, Kodiaq

* Add support clarity for MQB vs NMS Passat

* Remove Passat till we get a route

* Remove fwdRadar dupe FW

* fp

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-03-25 23:34:20 -07:00
Jason Young
430951e1cd VW MQB: Volkswagen Tiguan Mk2 (#20484)
* Add VW Tiguan (jyoung8607)

* Update README and test_processes

* Moving test route to correct place

* Moving test route to correct place

* Fix candidate expression

* Add ignored fingerprints list

* Yo dawg I heard you like fingerprints..
2021-03-25 21:48:14 -07:00
Jason Young
e7fc11c7fb VW MQB: UDS fingerprinting support (#20271)
* FPv2 support for MQB

* Comment touch-ups

* Trim extra newlines

* Add Atlas and Tiguan

* Update submodule ref

* Revert "Add Atlas and Tiguan"

This reverts commit a47bc1bca7a5b72df44578051379859eefa5fb39.

* Curb my enthusiasm

* Drop ABS/ESP from UDS fingerprinting for now

* Use multi-query to grab SW build ID and parameterization

* Resolve merge oops

* Resolve merge conflicts

* Make Ecu.fwdCamera optional for VW

* Where'd that come from?

* Propitiate process replay checks until ready for model dump

* FW values for Audi A3 Prestige

* Revert "Make Ecu.fwdCamera optional for VW"

This reverts commit 56852b99

* Don't try to FP fwdCamera for VW

* Remove FW comments

* Simplify RX offset handling

* Corrected scoping for MQB trans detection

* Add default response_offset

* Remove explicit list of MQB vehicles for now

* Deal with pylint warning

* Clarify and simplify comments

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-03-25 16:06:59 -07:00
Jason Young
bee0cc6dac VW MQB: Support for other transmission types (#20253)
* Support pieces for e-Golf and manual trans

* Support pieces for e-Golf and manual trans

* Support pieces for e-Golf and manual trans

* Support pieces for e-Golf and manual trans

* Support pieces for e-Golf and manual trans

* Support pieces for e-Golf and manual trans

* Support pieces for e-Golf and manual trans

* Fix comment typo

* TRANS->TransmissionType, GEAR->GearShifter

* TRANS->TransmissionType, GEAR->GearShifter
2021-03-09 15:39:58 +01:00
Samuel Keeley
962ad654ae Audi A3 8v support (#19873)
* audi a3 8v support

* segment

* AUDI -> VOLKSWAGEN

* remove comment

* remove values

* remove from test_models

* update readme, only tested on 2015

* replace with a route which was running this code

* empty commit to make tests run

* try one which is definitely uploaded

* A3 -> AUDI_A3
2021-01-23 18:43:59 -08:00
Igor
093456cc40 Parametrize MIN_CAN_SPEED in car interfaces (#2684)
* Parametrize MIN_CAN_SPEED in car interfaces

* fixed instance in planner.py

* fix typo

* var name change

* changed var name to minSpeedCan for consistency with other uses of CAN in the capnproto files

* added default value to get_std_params, removed unneeded instances from car interface files

* Revert PEP8 autoformat corrections

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-12-04 11:09:34 +01:00
Adeeb Shihadeh
47c21f10f5 grey panda is unsupported (#2458) 2020-11-03 19:56:25 -08:00
Adeeb Shihadeh
9ee1cc9b82 Run CI tests in parallel (#1962)
* run car model unit tests in parallel

* remove refs to deleted file

* run with coverage

* that wasn't necessary

* as builder

* need a new route for this one too
2020-08-02 00:30:09 -07:00
Adeeb Shihadeh
892e1162c0 Car cleanup (#1924)
* cleanup car code

* more pruning

* little more

* less pylint disables

* radar stuff

* fix

* udpate refs

* fix honda bosch

* fix test
2020-07-25 15:07:27 -07:00
Willem Melching
843a64c72f Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
2020-06-02 16:29:32 -07:00