Commit Graph

78 Commits

Author SHA1 Message Date
Willem Melching
4f1eb4278a Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
2021-12-16 13:08:20 +01:00
Harald Schafer
16bf562806 Add TSS2 prius to TSS2 long tunes 2021-12-07 16:06:43 -08:00
Willem Melching
e6180738fd add CarParams.wheelSpeedFactor (#23079)
* add CarParams.wheelSpeedFactor

* Fudge speed for Lexus RX

* should have been the TSS2 model

* bump cereal

* refactor into function

* update refs
2021-12-03 14:57:53 +01:00
HaraldSchafer
316a10bb6b add tss2 highlander to tss2 tune (#23107) 2021-12-02 14:01:17 -08:00
Erich Moraga
5abe293f61 Fix comment typo: steerRation -> steerRatio (#23058) 2021-11-28 19:15:36 -08:00
Erich Moraga
d630ec9092 Add Lexus RC support (#22941)
* Add f/w firmware for Lexus RC under LEXUS_IS

`@ph33rl355#0529`  2020 Lexus RC F Track Edition  DongleID/route 32696cea52831b02|2021-11-16--23-12-02

Doesn't seem to need a full port, per user feedback...
https://discord.com/channels/469524606043160576/524327905937850394/910400788319326229

* Update CARS.md

* Separated Lexus RC from IS... still using IS DBC

* match lexus IS for now

* Update wheelbase to match published specs

I'm hesitant to touch `mass`, even though I know it's different from the IS.

* Add TOYOTA.LEXUS_RC test route

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-11-22 14:22:28 -08:00
HaraldSchafer
06844821c5 Cleanup toyota tuning (#22859)
* start cleanup

* start lateral

* finish lateral

* add file

* typo

* add enu

* remove whitespace

* cleanup safetyparam

* typo
2021-11-17 12:06:39 +01:00
Adeeb Shihadeh
70c1f19304 pedal: only send command while actuators active (#22942) 2021-11-16 22:38:23 -08:00
cydia2020
944578ad09 Toyota: gate enableDsu on no smartDSU (#22711) 2021-10-27 11:29:34 -07:00
Robbe Derks
91987f38d4 Make pandaState and safetyMode a list (#22454)
* wip: move to pandaStates

* bump cereal

* wip: SafetyMode struct

* move to safetyMode

* fix typo

* this can be None

* fix potential empty pandaStates list

* fix thermald

* fix controlsd

* rename safetyModes to safetyConfigs

* update process_replay

* fix test_models

* bump cereal
2021-10-08 17:54:34 +02:00
Willem Melching
1e62b09e5d Use CP.vEgoStopping and clean up CP.startAccel (#22199)
* use CP.vEgoStopping and clean up

* update ref
2021-09-11 17:13:30 -07:00
Willem Melching
f941111dcd Clean up PID controller ACCEL_MIN/ACCEL_MAX (#22148)
* use ISO 15622:2018 limits in PID controller

* allow more for nidec

* limit PID inputs

* CP is not needed

* add GM

* not used

* update ref

* fix honda bosch
2021-09-06 17:29:32 -07:00
HaraldSchafer
1ac89f14aa Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-08-30 09:32:52 -07:00
Adeeb Shihadeh
c47b646b84 Revert lateral tuning change for some TSS2 Rav4 (#21715) 2021-07-25 13:46:48 -07:00
Adeeb Shihadeh
c72d163e14 deprecate CP.enableCamera (#21509)
* deprecate CP.enableCamera

* more removal

* one more

* update refs
2021-07-07 14:59:18 -07:00
Ross Fisher
f40e75edf8 Rav4 TSS2 has two different steering racks (#21429)
Split tuning on eps fwVersion \x02 only. See https://github.com/commaai/openpilot/pull/21429#issuecomment-873652891 for findings.

Unify Rav4 & Rav4 Hybrid

Average mass between ICE & Hybrid

Co-Authored-By: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-07-06 19:48:04 +02:00
John Belmonte
6d2069b762 Car port: Toyota Alphard (#21382) 2021-06-24 12:10:19 -07:00
Greg Hogan
8071111f59 default carParams.stoppingControl to True (#21248)
* hyundai has full brake control

* set default stoppingControl to True

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-06-15 14:00:57 +02:00
ShaneSmiskol
ebc294296a Toyota: Only use gas interceptor under 19 mph (#21101)
* pedal improvements

* pedal tuning under 19 mph, stock tuning above

* Correctly set tuning, and a temporary reference script

* looking good

* use minEnableSpeed

* minEnableSpeed will always be -1 if pedal since it's used for lockout

* add hysteresis around 19 mph for enabling pedal use

* parameterize minAccSpeed (enable speed is -1 when stop and go to allow engage, acc is min limit for acc commands)

* fix Prius later, 5 mph gap around switch speed

* define min_acc_speed in interface and CC

* use pedal gains up to 22 mph, and correctly use hysteresis above the switch speed

* only check this if pedal

* consolidate comment

* Change BP to switch tuning at 19 mph, define global constant

* Start at interceptor status

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update releases

* typo

* transition tuning from 19 to +3 mph

* change cmd names and update tuning comment

* Update RELEASES.md

* calculate new pedal gains

* little more clear

* even clearer

* same comment convention and hardcode new pedal tune

* bump cereal

* weird, got added in with the rebase

* three possible long tunings: pedal, improved non-pedal, and default non-pedal

* update refs

* future note: don't add submodules when rebasing!

* update refs

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-06-03 15:11:10 -07:00
Adeeb Shihadeh
2183582216 fix missing semicolon 2021-06-01 15:58:26 -07:00
Robert Hanna
6d8c985801 Add LEXUS_ESH_TSS2 to improved longitudinal tune (#21016)
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-06-01 15:52:16 -07:00
Adeeb Shihadeh
2680537b4b Merge Lexus UXH into TSS2 Corolla Hybrid (#21100) 2021-06-01 14:56:53 -07:00
jbates9011
909b848fa3 Car Port: Toyota Avalon Hybrid 2019 (#21082)
* Add 2019 Avalon Hybrid

* Rename variable

* Update values.py

Remove AVALONH fingerprint due to pending deprecation

* Add Avalon Hybrid 2019

* Add Avalon Hybrid 2019

* Update test_routes.py for Avalon Hybrid 2019

Co-authored-by: ShaneSmiskol <shane@smiskol.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-06-01 14:51:28 -07:00
ShaneSmiskol
07e4129edc Split Avalon 2016-18 and Avalon 2019+ (#21058)
* start to separate Avalon 2019+

* reverts #20824 (2020)...

and removes fw from a 2020 avalon

* revert 2020 fw from #20241

* revert 2021 fw from #19790

* bump opendbc, add smartDsu

* Add only removed fw from listed PRs above and from jryan's 2020

* bump opendbc to master

* comment out any non-original avalon fw

* new fw

* these 2016 (5 byte EPS_STATUS msg) Avalon fws are correct. comment out any 2019+ fw I haven't seen yet

* Add to release files

* these are good too

* nothing on 7e0 yet

* both have their engines on one address

* validated remaining fws! some from adeeb's, chris's, and kumar's PRs

* Add test route for Avalon 2019

* horrible

* Duplicate

* use nodsu dbc. Only difference is the addition of some signals that don't work, and max of BRAKE_PRESSURE is different

* Enablem 2019 Avalon test route
2021-06-01 12:41:24 -07:00
brianhaugen2
6089c95a35 Car port: LEXUS UX 2019 (#20998)
* adding port for 2019 lexus ux 250h

* update README

* added route to test_routes

* added CAR.LEXUS_UXH_TSS2 to IGNORED_FINGERPRINTS
changed test route to a complete route (that will be uploaded)

* unused

* add fw

* forgot h

Co-authored-by: Brian Haugen <brian.haugen@toyota.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-05-23 14:53:29 -07:00
Goesreallyfast
68e2c65b1a LEXUS NX 300 2020 Car Port (#20769) 2021-04-28 19:28:29 -07:00
Adeeb Shihadeh
6c7ed8f2e4 enforce message checks in can parser (#20742)
* enforce message checks in can parser

* nissan

* vw

* hkg

* subaru

* toyota

* honda bosch

* gm

* honda nidec

* bump opendbc

* not all tss2 have bsm

* toyota fixes

* honda fixes

* vw fix

* fix subaru

* fix long tests

* update refs

* crv bsm
2021-04-25 12:52:16 -07:00
Adeeb Shihadeh
a19d94ae2d Toyota: use FW query for DSU detection (#20615)
* Toyota: use FW query for DSU detection

* make sure we have at least some fw responses

* bool

* add test to test_startup

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-04-20 14:32:34 +02:00
vanillagorillaa
1f968521e4 Toyota Mirai TSS2.5 Port (#20534)
* Mirai TSS2 initial commmit

* Clean up

* proper formatting of FW versions

* Mirai test route

* Just Mirai
2021-03-31 11:10:15 -07:00
Adeeb Shihadeh
a0a5abc7ad Toyota: fix DSU detection on no DSU cars (#20120)
* Toyota: fix DSU detection on no DSU cars

* in
2021-02-19 22:12:31 -08:00
Igor
a910bc3f33 Add RAV4_TSS2 and RAV4H_TSS2 to Improved long tune (#20079) 2021-02-16 15:11:25 +01:00
Igor
18382f7819 Toyota interface.py: Create separate section for custom long tune (#20021)
* Move custom long tune section

* Move default tune to else statement
2021-02-08 10:07:37 +01:00
Igor
745b91ee57 Longitudinal tune for Corolla TSS2 (#2746) 2021-02-01 13:43:42 +01:00
Harald Schafer
1a14cca2a5 matches real data better 2021-01-14 21:24:57 -08:00
Willem Melching
e959155ddd update Corolla TSS2 wheelbase 2021-01-07 16:30:03 +01:00
Igor
0a65e87394 Add indi breakpoints (#19664)
* Added BP, V to latcontrol_indi

* hyundai

* toyota

* Tests for INDI outerLoopGain
2021-01-07 15:55:46 +01:00
Willem Melching
e4cf43c6fc Move all CarControllerParams into values.py (#19663)
* toyota

* use scale from values.py

* nissan

* subaru

* honda

* gm

* toyota combine into CarControllerParams

* nissan refactor

* chrysler refactor

* mazda refactor

* hyundai refactor

* subaru refactor
2021-01-06 11:20:44 +01:00
Igor
d632cddabb Toyota interface.py refactor. Move default long tune before candidate check. (#19652) 2021-01-05 11:58:53 +01:00
alancyau
ff0be15bbc Car Port: 2021 Camry Hybrid TSS 2.5 (#19649)
* Add 2021 Camry Hybrid FW

* Fixed

* update

* update

* update

* fpv1

* Update README with 2021 Camry Hybrid

* Test route added test_car_models.py

* fix merge conflict

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-01-04 16:00:00 -08:00
Mohammed Nasir
5696880ebe Car Port: Lexus ESH 2018 (#19624)
* add support for Lexus ES300h 2018

* reusing CT200h DBC

* skipping route test for now

* Update values.py

* Update values.py

* added fingerprint 2.0

* added test route

* disabling test for now

* reenabled route test

* fixes

* readability

* syntax fix

* Update carstate.py

* Update carstate.py
2021-01-03 14:13:54 -08:00
Adeeb Shihadeh
402d401e12 Car Port: 2021 Toyota Camry (TSS 2.5) (#2721)
* 2021 camry port

* tss2 adas

* test route
2020-12-17 13:29:50 -08:00
Igor
093456cc40 Parametrize MIN_CAN_SPEED in car interfaces (#2684)
* Parametrize MIN_CAN_SPEED in car interfaces

* fixed instance in planner.py

* fix typo

* var name change

* changed var name to minSpeedCan for consistency with other uses of CAN in the capnproto files

* added default value to get_std_params, removed unneeded instances from car interface files

* Revert PEP8 autoformat corrections

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-12-04 11:09:34 +01:00
Adeeb Shihadeh
818bd8a591 trim trailing whitespace 2020-11-05 14:11:41 -08:00
Adeeb Shihadeh
47c21f10f5 grey panda is unsupported (#2458) 2020-11-03 19:56:25 -08:00
Adeeb Shihadeh
4d0745504b Car Port: Lexus NX300 (#2481)
* Adding 2018 Lexus NX 300

* adding test model

* Update README.md

adding lexus nx 300 to readme

* update route

* add nx dbc to release files

* fix readme

* add to release notes

Co-authored-by: matt12eagles <matt12eagles@gmail.com>
2020-11-03 15:43:52 -08:00
Kumar
2a6765580c Car Port: Prius 2021 TSS2 (#2163) 2020-10-22 13:39:44 -07:00
Adeeb Shihadeh
6bc6db5f7a don't show giraffe alert with relay (#2335)
* who has a giraffe still?

* not black
2020-10-13 12:42:04 -07:00
Shane Smiskol
23b38a878b Update 17 Corolla safetyParam (#2175) 2020-09-16 11:40:19 +02:00
Adeeb Shihadeh
892e1162c0 Car cleanup (#1924)
* cleanup car code

* more pruning

* little more

* less pylint disables

* radar stuff

* fix

* udpate refs

* fix honda bosch

* fix test
2020-07-25 15:07:27 -07:00
Adeeb
165bcf1f31 Fix speed too low (#1627)
* fix speed too low

* bump ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-06-02 17:31:59 -07:00