Jafar Al-Gharaibeh
fc7d152dca
Mazda: CX-5 and 3 FW ( #23267 )
...
* Mazda 3 2017 fw
dongle id: f7fec643f5178df8
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* Mazda CX-5 2020 FW
dongle id: f4b488f06d3b7711
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
2021-12-18 14:47:04 -08:00
Willem Melching
4f1eb4278a
Log actuators after applying rate limits in CarController ( #23230 )
...
* return actuators from carcontroller
* log it
* pass to latcontrol
* chrysler
* gm
* honda
* more brands
* rest of the brands
* gm cleanup
* hyundai cleanup
* update ref
* rename field
* fix subaru
* add types
* more subaru fixes #23240
* consistent whitespace
* bump cereal
2021-12-16 13:08:20 +01:00
Willem Melching
e6180738fd
add CarParams.wheelSpeedFactor ( #23079 )
...
* add CarParams.wheelSpeedFactor
* Fudge speed for Lexus RX
* should have been the TSS2 model
* bump cereal
* refactor into function
* update refs
2021-12-03 14:57:53 +01:00
Adeeb Shihadeh
f0f7359f6a
mazda: capitalize CX9 like all others cars
2021-11-24 11:53:10 -08:00
Jafar Al-Gharaibeh
787dde003e
Mazda: fix typo in CX-5 fw ( #22957 )
2021-11-17 13:49:10 -08:00
Jafar Al-Gharaibeh
2492a11661
Mazda: add three new FW FP ( #22939 )
2021-11-16 21:10:16 -08:00
Jafar Al-Gharaibeh
b18661a3a6
Mazda: fix occasional main cruise disable ( #22807 )
...
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
2021-11-10 21:25:41 -08:00
Jafar Al-Gharaibeh
2621e5301d
Mazda: disable hud alerts until we find a way to silence audible alerts ( #22808 )
...
* Mazda: disable hud alerts for now until we find a way to silence audible warnings
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* Mazda: add hud alert for steer lockout
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* show when above min steer speed
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
2021-11-09 15:24:18 -08:00
Jafar Al-Gharaibeh
8c38e9c49e
Mazda: fix occasional steer fault at initial lkas enable ( #22806 )
...
* Mazda: fix occasional steer fault at initial lkas enable
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
2021-11-08 14:40:26 -08:00
Adeeb Shihadeh
2252c6bba7
Mazda: move CX-9 out of dashcam mode ( #22717 )
...
* move cx9 out of dashcam
* no alc below 28
* process replay route
2021-10-31 22:02:36 -07:00
Adeeb Shihadeh
40b7962b93
Mazda: fix up cruise cancellation ( #22750 )
...
* also cancel on cruiseControl.cancel
* set counter in button msg
2021-10-30 13:37:52 -07:00
Adeeb Shihadeh
1848fed6e2
Mazda: send dash alerts ( #22730 )
...
* Mazda: send dash alerts
* no actuators
* ldw
* send alerts
* test
* use cam parser
* add generic toggle
* wip
* revert some stuff
* try that
* steer required works
* cleanup
* bump panda
* little more cleanup
* no lane lines
Co-authored-by: Comma Device <device@comma.ai >
2021-10-30 10:56:30 -07:00
Adeeb Shihadeh
f9b6b03f5d
Mazda: car state cleanup + comments
2021-10-29 14:40:58 -07:00
Adeeb Shihadeh
4bbeb27f9b
Mazda: allow engaging below min LKAS speed ( #22737 )
...
* Mazda: allow engagement below minimum LKAS speed
* bump panda
* bump panda
2021-10-29 13:07:52 -07:00
Adeeb Shihadeh
2b4a655f36
Mazda: fix blinker states ( #22718 )
...
* Mazda: fix blinker states
* not lamp
* back to lamp to fix convenience blinkers
2021-10-28 14:05:12 -07:00
Jafar Al-Gharaibeh
ca1f96ac72
Mazda: Fix OP steer warning in cars with lockout ( #22612 )
...
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
2021-10-20 21:36:22 -07:00
Jafar Al-Gharaibeh
c898939423
Mazda: fix disabling cruise main on after cancelling cruise ( #22193 )
...
On some disengagement events (brake/gas/etc) OP may occasionally
ends up disabling the main cruise control where the driver has
to press the main cruise button before they can engage ACC again.
Try to detect this situation and automatically turn on cruise
when that happens.
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
2021-10-10 14:24:57 -07:00
Jafar Al-Gharaibeh
d19ac7e49b
Mazda: Fix steer lockout issue in CX-9 2021 ( #22506 )
...
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
2021-10-10 14:19:43 -07:00
Jafar Al-Gharaibeh
2dff0597b7
Mazda: Add CX-9 2021 GT firmware ( #22509 )
...
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
2021-10-10 10:08:18 -07:00
Robbe Derks
91987f38d4
Make pandaState and safetyMode a list ( #22454 )
...
* wip: move to pandaStates
* bump cereal
* wip: SafetyMode struct
* move to safetyMode
* fix typo
* this can be None
* fix potential empty pandaStates list
* fix thermald
* fix controlsd
* rename safetyModes to safetyConfigs
* update process_replay
* fix test_models
* bump cereal
2021-10-08 17:54:34 +02:00
Jafar Al-Gharaibeh
b170c1f4e1
Mazda: use cruise speed signal from PCM ( #22345 )
...
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
2021-09-24 16:58:32 -07:00
Adeeb Shihadeh
649af76fd4
remove community supported cars from community features ( #22330 )
...
* remove community supported cars from community features
* remove bosch and hkg long
* remove test case
* update refs
2021-09-23 17:34:52 -07:00
Jafar Al-Gharaibeh
cb63a89dd0
Mazda 3/CX-5 FW ( #22087 )
...
* Mazda 3 2017 FW
dongle-id: 2f26dfe847d7c138
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* CX-5 fw
dongle id: 769d87694463b543
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
2021-08-30 22:14:49 -07:00
Jafar Al-Gharaibeh
a949a49d5e
Batch of Mazda FW ( #22037 )
...
* Mazda CX-9 2021 fw
dongle-id: 09190764dd71c810
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* Mazda CX-5 2017 FW
dongle-id: ec9d14ccafd6a5bd
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* Mazda 6 2021 FW
dongle-id: afdcf7eee0222886
* Mazda CX-5 2019 Diesel FW
dongle-id: a90d564521cb048e
Co-authored-by: Shubham Arora <shubhama1903@gmail.com >
Co-authored-by: srbaumruk205 <72043516+srbaumruk205@users.noreply.github.com >
2021-08-25 11:16:26 -07:00
Jafar Al-Gharaibeh
ff704e18b7
Car Port: Mazda CX-9 2021 ( #20864 )
...
* Mazda CX-9 no steer lockout, and newer cars can use more torque
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* Mazda CX-9 2021 test route
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* cleanup
* more cleanup
* don't show community features alert if dashcam only
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
2021-07-10 23:50:03 -07:00
Jafar Al-Gharaibeh
e0ed92c03f
Mazda: Latest FP2 FW roundup ( #21529 )
...
* Mazda CX-5 2020 FW
dongle-id: 7158b1c81c34b73a
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* Mazda CX-9 2018 fw
dongle-id: b7ac84ce9191f3cb
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* Mazda CX-9 2019 fw
dongle id: 30453440af4c0a5a
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* Mazda CX-5 2019 FW
dongle-id: a9a9badda9265c17
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
2021-07-10 13:16:14 -07:00
Adeeb Shihadeh
c72d163e14
deprecate CP.enableCamera ( #21509 )
...
* deprecate CP.enableCamera
* more removal
* one more
* update refs
2021-07-07 14:59:18 -07:00
Jafar Al-Gharaibeh
43ead46a46
Add Mazda CX-5 2018 fw ( #21403 )
...
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
2021-06-29 15:43:00 -07:00
Jafar Al-Gharaibeh
56fbf66c20
Add Mazda 6 and new FW for other models ( #21167 )
...
* Add support for Mazda6
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* New FWs and Mazda 6 test route
Change Mazda to MAZDA
Mazda6 test route
CX-5 2018 FW
CX-5 2019 Australia FW
CX-9 2016 FW
Mazda3 2014 FW
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
2021-06-06 14:40:57 -07:00
Jason Young
83ca5a0d29
Cleanup carstate quoting styles ( #21109 )
...
* carstate quoting style: VW
* carstate quoting style: Chrysler
* carstate quoting style: Ford
* carstate quoting style: GM
* carstate quoting style: Honda
* carstate quoting style: Hyundai
* carstate quoting style: Mazda
* carstate quoting style: Nissan
* carstate quoting style: Subaru
* carstate quoting style: Soulless Appliances
* Sorry Honda!
2021-06-02 15:51:54 +02:00
Willem Melching
0f13a80e0b
Mazda: remove CAN fingerprints ( #21067 )
2021-05-28 16:53:12 +02:00
Jafar Al-Gharaibeh
824f93303d
Mazda FP 2.0 support ( #20879 )
...
* Mazda FP 2.0 support
ECU FW for CX-5 2017 and Mazda3 2017
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* Use standard UDS request/reponse, fix missing arg.
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* Add CX-5 FW test
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* update/add FW FP
Current suported models:
CX-5 2017/2021
CX-9 2019/2020
Mazda3 2017/2018
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* Add Cx-9 2019 FW FP
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* Remove comments, remove TESTER_PRESENT_REQUEST from Mazda
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* add transmission ecu to startup test
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
2021-05-28 15:50:58 +02:00
ShaneSmiskol
551091bcfa
Deprecate brakeLights field ( #20954 )
...
* remove all references to CS.brakeLights
* unused red
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
2021-05-18 17:48:02 -07:00
Jafar Al-Gharaibeh
426faa02f0
Mazda 3 2014 Fingerprint ( #20735 )
...
* mazda: don't passthrough unused signals
Some older models do have these, newer models don't.
Either way, they all work just fine if set to zero.
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* mazda: improve auto resume after full stop. Thanks number1pete
Auto resume doesn't always work after a full stop.
sending RES presses at a higher rate fixes the issue.
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* Add Mazda 3 2014 fingerprint
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* Merge mazda 3 fingerprints
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
2021-04-23 17:25:58 -07:00
Adeeb Shihadeh
312b681a46
cereal cleanup part 2 ( #20092 )
...
* car stuff
* thermal
* Revert "car stuff"
This reverts commit 77fd1c65ebd01abfa8493ae12c9e6b14f7ada976.
* panda state
* camera stuff
* start deg
* most is building
* builds
* planner + controls run
* fix up paramsd
* cleanup
* process replay passes
* fix webcam build
* camerad
* no more frame
* thermald
* ui
* paramsd
* camera replay
* fix long tests
* fix camerad tests
* maxSteeringAngle
* bump cereal
* more frame
* cereal master
2021-02-16 21:39:32 -08:00
Willem Melching
e4cf43c6fc
Move all CarControllerParams into values.py ( #19663 )
...
* toyota
* use scale from values.py
* nissan
* subaru
* honda
* gm
* toyota combine into CarControllerParams
* nissan refactor
* chrysler refactor
* mazda refactor
* hyundai refactor
* subaru refactor
2021-01-06 11:20:44 +01:00
Igor
093456cc40
Parametrize MIN_CAN_SPEED in car interfaces ( #2684 )
...
* Parametrize MIN_CAN_SPEED in car interfaces
* fixed instance in planner.py
* fix typo
* var name change
* changed var name to minSpeedCan for consistency with other uses of CAN in the capnproto files
* added default value to get_std_params, removed unneeded instances from car interface files
* Revert PEP8 autoformat corrections
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
2020-12-04 11:09:34 +01:00
Adeeb Shihadeh
47c21f10f5
grey panda is unsupported ( #2458 )
2020-11-03 19:56:25 -08:00
Adeeb Shihadeh
a81a18205e
type hints for alerts and fix community feature alert ( #2196 )
...
* fix startup alert for community features
* type hints for alerts
* more type hints
* fix dashcam only alerts
* more type hints
2020-09-17 22:06:31 -07:00
Jafar Al-Gharaibeh
6c292c3f0c
Split car identities to CX5, CX9, and Mazda3 ( #2097 )
...
Add test routes for CX9 and Mazda3
CX9: "10b5a4b380434151|2020-08-26--17-11-45"
Mazda3: "74f1038827005090|2020-08-26--20-05-50"
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
2020-09-09 16:02:26 -07:00
Adeeb Shihadeh
892e1162c0
Car cleanup ( #1924 )
...
* cleanup car code
* more pruning
* little more
* less pylint disables
* radar stuff
* fix
* udpate refs
* fix honda bosch
* fix test
2020-07-25 15:07:27 -07:00
Jafar Al-Gharaibeh
d5d0e75070
Mazda BSM ( #1830 )
...
* Mazda BSM support
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* Add Mazda3 2017 and CX-9 2016 Fingerprints
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
2020-07-06 10:25:17 -07:00
Adeeb
367155168a
Update Flake8 config ( #1624 )
...
* update flake8 checks
* add E502
* no whitespace warnings
* fix violations
* no W391
Co-authored-by: Jason Young <jason@comma.ai >
2020-06-03 16:13:34 -07:00
Jafar Al-Gharaibeh
73db079199
Fix rounding of minSteerSpeed in events ( #1620 )
...
I thought I was missing a rounding in Mazda code, but it turned
out to be a missing rounding after the recent event refactoring
Python3 interpreter:
>>> print(" %d %d" % (1.6,1.4))
1 1
>>> print(" %d %d" % (round(1.6),round(1.4)))
2 1
>>> print(" %d %d" % (int(round(1.6)),round(1.4)))
2 1
>>> print(" %d %d" % (int(round(1.6)),int(round(1.4))))
2 1
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
2020-06-03 14:01:32 -07:00
Adeeb
165bcf1f31
Fix speed too low ( #1627 )
...
* fix speed too low
* bump ref
Co-authored-by: Willem Melching <willem.melching@gmail.com >
2020-06-02 17:31:59 -07:00
Willem Melching
843a64c72f
Make pylint more strict ( #1626 )
...
* make pylint more strict
* cleanup in progress
* done cleaning up
* no opendbc
2020-06-02 16:29:32 -07:00
Jafar Al-Gharaibeh
41fbce5906
Mazda: Slower rate for ACC cancel msg to avoid cruise disable ( #1615 )
...
* Slower rate for ACC cancel msg to avoid cruise disable
Sending ACC cancel message at 10hz may end up disabling
main cruise state. That is because stoc ACC use the same
signal for both functions. If cruise is already enabled
the signal canceles it, otherwise cruise is disabled.
10hz seems to be still fast in some cases not allowing
the state to sync up between OP and the Stock state.
5hz avoids that issue. Also, the resume message was also
updated to 5hz as that seems to work better as well.
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
* Round up 27.96 to 28mph
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com >
2020-06-01 02:04:47 -07:00
Adeeb Shihadeh
f3dcf861c7
enable flake8 E303: too many blank lines
2020-05-31 17:21:11 -07:00
Adeeb Shihadeh
efd5dffb1e
enable flake8 E231: missing whitespace after comma
2020-05-31 12:49:11 -07:00
Adeeb
6051061ff8
Flake8 E22X ( #1607 )
...
* e221
* e225
* bump opendbc
2020-05-31 00:48:47 -07:00