Commit Graph

39 Commits

Author SHA1 Message Date
Willem Melching
4f1eb4278a Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
2021-12-16 13:08:20 +01:00
Adeeb Shihadeh
0283942a95 Honda: use new Bosch LKAS_HUD messages (#23000)
* Honda: use new Bosch LKAS_HUD messages

* enum value

* better name

* flip that
2021-12-05 13:51:33 -08:00
Adeeb Shihadeh
b07ddad6ed comma pedal: rename create_gas_command -> create_gas_interceptor_command 2021-11-20 20:13:58 -08:00
Adeeb Shihadeh
70c1f19304 pedal: only send command while actuators active (#22942) 2021-11-16 22:38:23 -08:00
Harald Schafer
0e4058d0ec remove unused line in honda carcontroller 2021-10-07 11:18:55 -07:00
HaraldSchafer
e5da7cc04b no throttle when not enabled (#22474) 2021-10-07 11:15:08 -07:00
Willem Melching
6c29a4c7fb Honda Bosch longitudinal tuning (#22407)
* revert changes to standstill logic

* start with mostly open loop

* Revert "revert changes to standstill logic"

This reverts commit d737d858e7708aedaf09cfc068b85398161e9bbe.

* proper clipping

* less lag

* less gas command

* start gas from -0.2

* controls should take care of that

* use CarControllerParams

* switch to braking sooner

* Revert "switch to braking sooner"

This reverts commit cf11dae334ccb369f625d4b13b7cd4176156a446.

* 2.5x more P

* use active

* engage on rising edge

* Revert "engage on rising edge"

This reverts commit c972956cb460eedaff3d0169a40673a6ea933385.

* update ref
2021-10-07 16:37:02 +02:00
Adeeb Shihadeh
4c0b82308d honda nidec: fix no acceleration with pedal (#22368) 2021-09-28 16:31:12 -07:00
Adeeb Shihadeh
3b8fa4b7fd controls: only send cruise cancel while cruise is enabled (#22359)
* controls: only send cruise cancel while cruise is enabled

* cleanup

* might actually do something

* update refs

* update refs again

* update refs
2021-09-28 12:30:50 -07:00
HaraldSchafer
4e939a9648 NIDEC pedal, good gas/brake transition (#22314)
* need gas to combat windbrake

* coasting deadzone

* no pcm gas and no pedal when braking
2021-09-24 11:24:49 -07:00
HaraldSchafer
74b6c87254 cleanup old nidec accel override logic (#22181)
* cleanup old nidec accel override logic

* add ref without deprecated fields

* no more override
2021-09-10 10:34:18 -07:00
HaraldSchafer
449a28b9aa Speed only ACC control for NIDEC Odyssey (#22156)
* speed only nidec control

* mergeable
2021-09-06 21:11:26 -07:00
Willem Melching
21ae64868e put LongControlState in CarControl.Actuators (#22154) 2021-09-06 18:45:59 -07:00
Harald Schafer
054c912b9a need to add gas here 2021-09-03 14:01:24 -07:00
HaraldSchafer
ebf2a2279d Prevent PID windup on Honda NIDEC (#22112)
* add higher set speed

* freeze when close to cruise

* dont bias this

* higher set speed

* start high

* 2mph might be needed

* better condition

* limit accel windup like this

* wrong name
2021-09-02 14:16:44 -07:00
HaraldSchafer
c93f3b10f7 no more old nidec (#22104) 2021-09-02 12:05:03 -07:00
HaraldSchafer
68066168be Treat ILX braking like other Nidec hondas (#22078) 2021-08-30 13:47:13 -07:00
HaraldSchafer
1ac89f14aa Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-08-30 09:32:52 -07:00
Adeeb Shihadeh
9e03aa0b92 Honda cleanup (#22008)
* cleanup magic numbers

* long tuning

* indentation

* remove noqa

* little more
2021-08-22 00:27:48 -07:00
HaraldSchafer
e364ca2896 honda nidec safe windbrake interp (#21972) 2021-08-19 19:59:29 +02:00
HaraldSchafer
1c6c56a9df Remove acura (#21946)
* treat acura like nidec

* treat acura like nidec
2021-08-17 11:44:22 -07:00
HaraldSchafer
da73249fc2 Retune nidec long (#21941)
* retune civic

* add a deadzone

* large diffs may not be ok

* typo

* seems smooth

* improve pedal

* back to normal

* new ref

* new ref
2021-08-16 17:06:19 -07:00
Harald Schafer
cae0819e8b whitespace 2021-08-11 21:11:44 -07:00
HaraldSchafer
a8f3e2b3c2 Change long control honda pilot, ridgeline, honda fit, civic, ilx (#21886)
* not used

* just use gas

* allow gas

* try 0

* typo

* set to default

* set default

* makes more sense

* downtune and cleanup

* max accel always

* that is needed to smooth gas to brake

* try downtuning low speed

* try from default

* nidec is not bosch

* air resistance exists

* more smoothing

* wind brake sooner

* Civic experiments2 (#21862)

* control on throttle

* throttle modifier

* get acura in line

* try set speed control again (#21870)

* new acura function

* put back

* put back

* make linter happy

* define wind_brake once

* Civic experiments (#21908)

* remove civic

* start from scratch

* data drivenm

* the data does not lie

* data collection

* data driven

* limit

* final candidate

* fix windbrake

* Civic experiments (#21910)

* remove civic

* start from scratch

* data drivenm

* the data does not lie

* data collection

* data driven

* limit

* final candidate

* fix windbrake

* add acura control

* more cleanup

* cleanup

* update ref

* clip

* seems to fault

* always continuous

* new ref
2021-08-11 18:32:37 -07:00
arfy slowy
d74def61f8 fix: spelling typos (#21861)
* fix: typo spelling grammar

* revert

* Update selfdrive/locationd/calibrationd.py

* more revert

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-08-05 12:05:49 -07:00
Adeeb Shihadeh
cb7e96f99d rename enableCruise -> pcmCruise (#21546) 2021-07-10 13:56:11 -07:00
Willem Melching
a8fac002ae Honda Bosch longitudinal prerequisites (#21217)
* untested changes

* set compute_gb

* community feature for good measure

* add code for rolling backwards

* init needs CarParams

* stay in elm mode until carParams is written

* fix tester present bus number

* fix can errors

* fix enableCruise flag

* print when radar disable is done

* move retry logic to controlsd

* move lookup table into carcontroller params

* cleanup brake error values

* make init return

* that should be 1

* floats

* back to no failure handling

* try simplify knockout

* bump panda

* Move flags to panda

* add warnings

* Revert "try simplify knockout"

This reverts commit 4f496245791ea6bd041d4412b96035c6b434b91c.

* add note about LoC.long_control_state

* update ref
2021-06-22 16:28:11 +02:00
CrispinFlowerday
7458e143e3 Subaru: show LDW on dash for correct lane (#20934)
* Emit correct alerts for LDW Left & Right on Subarus

This change switches the ldw event to use VisualAlert.ldw and
alters all cars to use the prior behaviour for that alert, except
global subarus - they emit the correct warning to the dash

* Remove whitespace, and add comment about not overwriting stock alerts

Co-authored-by: Crispin Flowerday <crispin@theflowerdays.com>
2021-06-07 15:06:28 -07:00
ShaneSmiskol
483678adb1 Honda - Don't send cancel cmd when using comma pedal (#20922)
* cancel is never true if cruise isn't enabled and pedal

* This is probably better

* comment

* want to see if this fails

* see what Actions says about this

* nice! just as a sanity test real quick

* Revert "nice! just as a sanity test real quick"

This reverts commit 2d86d1c32eca5ca8efb9b5d15483c65ce51c777a.

* Revert "see what Actions says about this"

This reverts commit c908488854ec391cc2ec0c2684739b94c5e526cc.

* Revert "want to see if this fails"

This reverts commit 2d515f37215095cedb790433429487d991630a9b.

* specify the fix

* No bitwise

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-05-18 10:41:24 +02:00
Willem Melching
e4cf43c6fc Move all CarControllerParams into values.py (#19663)
* toyota

* use scale from values.py

* nissan

* subaru

* honda

* gm

* toyota combine into CarControllerParams

* nissan refactor

* chrysler refactor

* mazda refactor

* hyundai refactor

* subaru refactor
2021-01-06 11:20:44 +01:00
Adeeb Shihadeh
47c21f10f5 grey panda is unsupported (#2458) 2020-11-03 19:56:25 -08:00
Greg Hogan
0902575e34 pre-reqs for honda bosch longitudinal control (#1458)
* pre-reqs for honda bosch longitudinal control

* openpilot_longitudinal_control -> radar_disabled

* fix chrysler test

* review feedback

* little cleaner

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-09-29 00:04:15 -07:00
Adeeb Shihadeh
6466ec982a enable flake8 E502: backslash is redundant between brackets 2020-05-31 17:41:18 -07:00
Chris Souers
0f530be2b4 Static 0xe5 on Honda Bosch (#1420)
* Recreate a static 0xe5 and send to radar

* remove unneeded declaration

* Update ref_commit
2020-04-28 14:12:46 -07:00
Chris Souers
035397cd31 Adds 2016 CR-V Executive (Euro version of Touring trim) (#1097)
Co-authored-by: Ted Slesinski <ted_slesinski@epam.com>
2020-03-13 11:48:08 -07:00
Adeeb
13f60eae91 Abstract CarInterface init (#1131)
* abstract CarInterface init

* unused

* subaru

* gm cleanup

* vw

* typo

* carcontroller

* more cleanup

* fix vw
2020-02-19 20:37:07 -08:00
Greg Hogan
57c44e3705 WIP: Honda Steering Improvements (#983)
* move honda steer params to CarParams

* use breakpoints/values from firmware

* remove comment

* civic fw mod max included deadzone

* civic bosch needs to be separate

* script to measure steering accuracy

* civic tuning

* update cr-v values

* cleanup

* averaging over 10 samples was silly

* update stock civic and cr-v tuning

* remove comment

* update replay expected results
2020-02-19 13:28:01 -08:00
rbiasini
0c67143c92 Carstate returns capnp struct (#1115)
* Before abstraction, adding speed init from VW as well

* strting to abstract carstate class

* fix bug and update lock?

* revert pipfile change

* another bug

* fix linter

* bug fix

* remove a bunch of diplicated kf code

* better to not have class vars. will abstract __init__ anyway later

* abstract common instance vars in carstate init and a generic gear parser static method

* abstract gear parser for chrysler

* abstract gm gear parser too

* remove unnecessary random vars

* Chrysler: carstate returns capnp struct directly

* revert ref commit

* test ref

* WIP

* more WIP

* ops, missed this conflict

* ford as well

* not sure why this got deleted

* no need to copy

* remove copy

* remove copy import

* remove unnecessary intermediate variable

* remove obsolete comments

* GM: have carstate returning capnp struct directly

* Honda carstate also outputing capnp struct

* hyundai too now returns capnp from carstate

* ops, not meant this

* Subaru carstate also returning capnp

* Toyota: capnp struct as output of carstate

* fix bool

* minor simplififcation in Honda

* no need to negate

* VW carstate returning capnp struct (#1118)

* VW carstate also returning capnp struct

* fixed typo

* Remove unused blinker button (#1119)

* remove unused blinker button

* ops, this wasn't meant

* remove blinker button for VW as well

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-02-18 15:28:15 -08:00
George Hotz
71ead9adea selfdrive/car 2020-01-17 10:58:43 -08:00