Commit Graph

70 Commits

Author SHA1 Message Date
Willem Melching
4f1eb4278a Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
2021-12-16 13:08:20 +01:00
Willem Melching
e6180738fd add CarParams.wheelSpeedFactor (#23079)
* add CarParams.wheelSpeedFactor

* Fudge speed for Lexus RX

* should have been the TSS2 model

* bump cereal

* refactor into function

* update refs
2021-12-03 14:57:53 +01:00
Robbe Derks
91987f38d4 Make pandaState and safetyMode a list (#22454)
* wip: move to pandaStates

* bump cereal

* wip: SafetyMode struct

* move to safetyMode

* fix typo

* this can be None

* fix potential empty pandaStates list

* fix thermald

* fix controlsd

* rename safetyModes to safetyConfigs

* update process_replay

* fix test_models

* bump cereal
2021-10-08 17:54:34 +02:00
Adeeb Shihadeh
649af76fd4 remove community supported cars from community features (#22330)
* remove community supported cars from community features

* remove bosch and hkg long

* remove test case

* update refs
2021-09-23 17:34:52 -07:00
Adam Boeglin
b5daca3881 Added fingerprint for 2018 Jeep Trackhawk (#21976)
* Added fingerprint for 2018 Jeep Trackhawk

When connecting the Comma3 to my Trackhawk with the latest jvePilot beta, it showed the error "Car Unrecognized: Dashcam Mode".

Obtaining this fingerprint resolved the issue. I don't know if it works with any other model years.

* merge fingerprints

* add missing vals

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-09-02 15:12:43 -07:00
HaraldSchafer
1ac89f14aa Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-08-30 09:32:52 -07:00
Adeeb Shihadeh
c72d163e14 deprecate CP.enableCamera (#21509)
* deprecate CP.enableCamera

* more removal

* one more

* update refs
2021-07-07 14:59:18 -07:00
Erich Moraga
66035ccac9 Add PACIFICA_2020 fingerprint (#21106) 2021-06-18 15:52:58 -07:00
CrispinFlowerday
7458e143e3 Subaru: show LDW on dash for correct lane (#20934)
* Emit correct alerts for LDW Left & Right on Subarus

This change switches the ldw event to use VisualAlert.ldw and
alters all cars to use the prior behaviour for that alert, except
global subarus - they emit the correct warning to the dash

* Remove whitespace, and add comment about not overwriting stock alerts

Co-authored-by: Crispin Flowerday <crispin@theflowerdays.com>
2021-06-07 15:06:28 -07:00
Jason Young
83ca5a0d29 Cleanup carstate quoting styles (#21109)
* carstate quoting style: VW

* carstate quoting style: Chrysler

* carstate quoting style: Ford

* carstate quoting style: GM

* carstate quoting style: Honda

* carstate quoting style: Hyundai

* carstate quoting style: Mazda

* carstate quoting style: Nissan

* carstate quoting style: Subaru

* carstate quoting style: Soulless Appliances

* Sorry Honda!
2021-06-02 15:51:54 +02:00
Adeeb Shihadeh
c736b7e5bb chrysler pacifica 2020 fingerprint values 2021-05-25 14:23:05 -07:00
TheWizard1328
ed0c8a770f Chrysler Pacifica Fingerprint (#20935)
* Update values.py

* Update values.py

* Update selfdrive/car/chrysler/values.py

* Update values.py

Chrysler Pacifica 2020 fingerprint values added.

* Update values.py

* Update values.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-05-19 20:02:08 -07:00
ShaneSmiskol
551091bcfa Deprecate brakeLights field (#20954)
* remove all references to CS.brakeLights

* unused red

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-05-18 17:48:02 -07:00
xps-genesis
1e473d764a Chrysler BSM info signal (#20694)
* Chrysler BSM info signal

* change to ==1

* add checks to enable bsm

* add fingerprint can id for enableBsm

* gate behind enableBsm

* fix indenatation

* update refs

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-05-04 20:37:39 -07:00
mahlzeit1948
f6d800a89e Fix Chrysler Pacifica weight (#20647)
* Update interface.py

2858 is the gross vehicle weight of the hybrid (maximum weight of vehicle + cargo).
Curb weight for the ICE is 1964 kg, for the hybrid it is 2242 kg

* hybrid & update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-04-11 17:18:31 -07:00
vanillagorillaa
4a5e43cdcc 2021 Pacifica Hybrid values (#20380)
* 2021 Pacifica Hybrid values

* combine all 2019 PacHy fingerprints into one

* Revert "combine all 2019 PacHy fingerprints into one"

This reverts commit a08ede166608ef2b51ab54f2aebbaf0b550e8db1.

* this one isn't needed, fully contained in one below with the new values
2021-03-31 00:57:48 -07:00
qadmus
0d61d8a4b6 int(round()) on apply_steer for correct comparison after rate limiting (#20425) 2021-03-22 13:01:33 +01:00
Drew Hintz
01f20229cb include PACIFICA_2020 in late-model behavior (#20399)
These models need to turn off gone_fast_yet bit at -3 to avoid LKAS
faults.

This was likely an accidental omission from PR #1297
To avoid future similar mistakes, we could define a list of these cars
in values.py instead of having the list in multiple places.
2021-03-18 17:29:36 -07:00
vanillagorillaa
d1b651af7d 2021 pacifica hybrid - additional fingerprint values (#20164)
* 2021 Pacifica Hybrid

* this weird space always gets added

* one more space
2021-02-25 22:20:23 -08:00
Shane Smiskol
700f7db644 Chrysler: Default fingerprint argument to empty fingerprint (#20146) 2021-02-24 15:41:20 +01:00
Adeeb Shihadeh
312b681a46 cereal cleanup part 2 (#20092)
* car stuff

* thermal

* Revert "car stuff"

This reverts commit 77fd1c65ebd01abfa8493ae12c9e6b14f7ada976.

* panda state

* camera stuff

* start deg

* most is building

* builds

* planner + controls run

* fix up paramsd

* cleanup

* process replay passes

* fix webcam build

* camerad

* no more frame

* thermald

* ui

* paramsd

* camera replay

* fix long tests

* fix camerad tests

* maxSteeringAngle

* bump cereal

* more frame

* cereal master
2021-02-16 21:39:32 -08:00
vanillagorillaa
4e99b4c232 Chrysler Pacifica: additional 2020 Fingerprint values (#20032)
* Additional 2020 Values

* space
2021-02-07 17:36:34 -08:00
Chris McCammon
332e01ee91 2021 Pacifica Hybrid fingerprint (#19846)
* Merge fingerprint of 2021 Pacifica Hybrid from b66bf349eecf2fda

* add route information

* remove comment
2021-01-20 13:48:48 -08:00
vanillagorillaa
f005fd0796 Pacifica Fingerprint Addition (#19750)
* Pacifica: Should fix dashcam mode when remote start

* extra indent
2021-01-15 13:40:23 -08:00
vanillagorillaa
937aa829a3 Chrysler non-ACC Fix - Only allow openpilot in ACC mode (#19581)
* initial try, needs to be tested

* Chrysler: Add to CAN parser

* Chrysler: move cruise state by other dash message

* fix messed up force push

* whitespace

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-01-06 12:06:03 -08:00
Willem Melching
e4cf43c6fc Move all CarControllerParams into values.py (#19663)
* toyota

* use scale from values.py

* nissan

* subaru

* honda

* gm

* toyota combine into CarControllerParams

* nissan refactor

* chrysler refactor

* mazda refactor

* hyundai refactor

* subaru refactor
2021-01-06 11:20:44 +01:00
Adeeb Shihadeh
47c21f10f5 grey panda is unsupported (#2458) 2020-11-03 19:56:25 -08:00
Adeeb Shihadeh
1e44b99478 Add missing chrysler can parser checks (#1967)
* add missing chrysler can parser checks

* toyota

* toyota cam

* toyota freqs

* chrysler freqs

* doors

* just chrysler for now

* update refs

* update again
2020-08-02 18:11:42 -07:00
Adeeb Shihadeh
892e1162c0 Car cleanup (#1924)
* cleanup car code

* more pruning

* little more

* less pylint disables

* radar stuff

* fix

* udpate refs

* fix honda bosch

* fix test
2020-07-25 15:07:27 -07:00
Adeeb Shihadeh
35a5b057c1 minor cleanups from LGTM 2020-07-17 23:34:38 -07:00
Adeeb Shihadeh
1ef3b20955 2020 Jeep Grand Cherokee fingerprint
Squashed commit of the following:

commit a1a14048375b4d9c9181b2797621e999738104f8
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Mon Jul 13 16:30:54 2020 -0700

    cleanup

commit cf7d4bb162c5018a05b81dd83f124b3ef7826714
Author: Tunder (Chris in RL) <34691234+Tundergit@users.noreply.github.com>
Date:   Sun Jul 12 21:08:59 2020 -0700

    added missed value

commit b91af6eef1b5d966cf4342475a37129ddb46e8de
Author: Tunder (Chris in RL) <34691234+Tundergit@users.noreply.github.com>
Date:   Sun Jul 12 20:52:41 2020 -0700

    Update values.py

commit d3d564fc76db19eae1464d6d938fdc43aa9b6d4e
Author: Tunder (Chris in RL) <34691234+Tundergit@users.noreply.github.com>
Date:   Fri Jul 10 00:23:35 2020 -0700

    add support for 2020 Grand Cherokee
2020-07-13 17:00:27 -07:00
VirtuallyChris
59cbaf88ef Add missing fp value for Jeep Grand Cherokee 2019 2020-06-24 16:11:59 -07:00
Adeeb
367155168a Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
2020-06-03 16:13:34 -07:00
Willem Melching
843a64c72f Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
2020-06-02 16:29:32 -07:00
Adeeb Shihadeh
6466ec982a enable flake8 E502: backslash is redundant between brackets 2020-05-31 17:41:18 -07:00
Adeeb Shihadeh
f3dcf861c7 enable flake8 E303: too many blank lines 2020-05-31 17:21:11 -07:00
Adeeb Shihadeh
27754a277c enable E261 in flake8: two spaces before inline comment 2020-05-31 14:07:29 -07:00
Adeeb Shihadeh
efd5dffb1e enable flake8 E231: missing whitespace after comma 2020-05-31 12:49:11 -07:00
Adeeb
6051061ff8 Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
2020-05-31 00:48:47 -07:00
Tunder (Chris in RL)
ee371919c1 add missing 2020 pacifica value (#1551) 2020-05-22 10:37:05 -07:00
Adeeb
d976233f69 Alerts + Events refactor (#1466) 2020-05-14 15:21:21 -07:00
George Hotz
1295cfe06c Using lgtm.com and fixing found alerts (#1452)
* lgtm in readme, and mac nui fixes

* call super inits in radars

* unused imports, dup lines

* more radars, more unused imports

* pass CP into RadarInterfaceBase

* more fixups

* unused imports

* delete unused lines

* ugh, new unused import

Co-authored-by: George Hotz <geohot@gmail.com>
2020-05-02 12:07:34 -07:00
Adeeb
337529d5cb Add steerWarning and steerError to carState (#1444)
* Add steerWarning and steerError to carState

* fix gm and hyundai

* update refs
2020-05-01 13:13:12 -07:00
Adeeb
6ff08f8dee Chrsyler: calculate checksum in CAN packer (#1438) 2020-04-30 15:43:59 -07:00
Willem Melching
f7f0a81d13 Remove fake yaw rate from carstate (#1426)
* remove fake yaw rate from carstate

* update ref
2020-04-27 14:10:07 -07:00
donlbooth
912c3ab879 Adding fingerprint for Jeep Grand Cherokee 2019 Trailhawk (#1354)
* Adding fingerprint for Jeep Grand Cherokee 2019 Trailhawk

* Update values.py
2020-04-13 16:17:58 -07:00
Adeeb
8d791d78dd Abstract pcmEnable and pcmDisable events (#1350)
* don't need individual prev state vars since whole CS is copied

* don't need a whole function since toyota alerts were simplified

* better here

* abstract pcmEnable/pcmDisable events

* the flippening came to NEOS

* delete

* unused

* Revert "the flippening came to NEOS"

This reverts commit 91cfb73b2914f637863335f4e5f5952620b3e977.
2020-04-10 16:12:58 -07:00
Drew Hintz
756dbd8e3b add Jeep GC 2019 USA fingerprint from al_nyc (#1339)
* add Jeep GC 2019 USA fingerprint from al_nyc

* merge Jeep GC 2019 USA fingerprint with existing fingerprint
2020-04-10 14:15:50 -07:00
Willem Melching
746f7ed9b1 2020 Chrysler Pacifica (#1297)
* 2020 pacifica support

* Update readme
2020-03-31 15:47:49 -07:00
George Hotz
2ecddbb3b6 Move all non Honda+Toyota to community supported (#1280)
* readme update, still need the gates on the cars themselves

* add community feature gating to other car ports

* promotion note

* from the brand

* readme touchups

* sell the harness

* full ISO

* update ref

Co-authored-by: George Hotz <geohot@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-03-27 10:59:07 -07:00