Commit Graph

82 Commits

Author SHA1 Message Date
Tim Wilson
a40efbdfcc GM camera ACC: always set long tune (#26892)
* GM: set long tune for camera car w/o exp. mode

* same tuning

* update refs

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-01-09 15:01:55 -08:00
Shane Smiskol
3e2a49c6e5 GM: add Bolt EV test route (#26681)
* bolt ev!

* releases

* it's a trim
2022-12-02 22:09:42 -08:00
Shane Smiskol
860f441e2f Car interface: set common params after port (#26613)
* remove pylint exception, _get_params takes no defaults

* clean up

* mock uses it too

* unused

* unused

* fix that

* bump

* Update selfdrive/car/interfaces.py
2022-11-29 11:49:13 -08:00
Shane Smiskol
15383d3016 GM: match stock enabling behavior (#26442)
* add first draft enable button timeout

* use allow_enable

* it doesn't count if brakePressed

* enable on rising edge of resume (matches stock)

* not today

* add comment describing the fault this avoids

* cleaner

* handle incrementing speed

* rename

* add test for not changing speed if enabled changes mid-press

* spacey

* ugh

* bumpo

* need this to fix a fault (draft)

* already have

* this should be cancel

* fine to do for all

* fine to do for all

* bump

* bumpo

* bump to master

* Update selfdrive/car/gm/interface.py

* Update selfdrive/car/gm/interface.py

* Update ref_commit
2022-11-13 21:13:46 -08:00
Shane Smiskol
65f494d845 GM: handle run-away set speed (#26480)
* GM: Handle run-away set speed

* bumpo

* This is a test of both PRs combined

* tempbump

* Revert "tempbump"

This reverts commit b73e04fca25e6a1bac889e44afac6430d5ad7c30.

* Revert "This is a test of both PRs combined"

This reverts commit 22cc0e6900e0f0470f14ed55e7846e4b1d570826.

* fix

* bump

* fix that

* Bump to master

* fix fix
2022-11-12 02:02:30 -08:00
Shane Smiskol
76ac3d4c99 controlsd: resume does not increment speed while cruise standstill (#25470)
* fix runaway set speed for GM

* fix runaway set speed for GM

* Handle resuming to exit standstill generically

* clean that up

* ugh i want to fix all the formatting

* class that manages v_cruise

* better name

* move around

* add depressed_state

* fine to update on pressed change, better name

* cmt

* we need to check CS. button_change_state only works if we exit standstill on rising edge not falling edge

* no defaultdict
2022-11-11 19:43:30 -08:00
Shane Smiskol
e634afb719 GM: fix fault while moving backwards (#26333)
* log signed speed

* bump to master

* need this

* fix

* fix...

* see if this works

* just fault fix (no logging or standstill. tho revisit standstill)

* move

* Revert "move"

This reverts commit c564e74666e3a418ef43a77926c8a38a2bf89511.
2022-11-02 17:55:53 -07:00
Shane Smiskol
2fb7b4ffad GM camera ACC: vision-only ACC behind toggle (#25631)
* put gm camera voacc behind disable radar toggle

* bump panda

* bump panda

* bump panda

* experimental long

* fixes

* car control notes and fixes for Bolt EUV

* might enable stop and go

* consistent name

* min enable speed seems to be around 5 kph

* camera acc can engage under 5 kph if stopped

* comment

* comment

* remove this for now

* only real brake

* comments

* update max brake

* bump

* clean up/fix

* same if

* simplify

* fix

* old comment

* no brake_pressed

* temporary fault fix

* tune longitudinal

* update docs

* bump panda

* GM camera ACC cars have no regen in ACC

* cleaner

* cleaner

* fix

* set max gas

* fixes

* fix LKAS unavailable warning from camera

* only camera

* bump panda

* bump panda

* bump panda

* bump panda

* clean up gmcan

* clean up CC

* flip

* rm

* rm comment

* clean up

* custom starting/stopping probably not needed

* Update selfdrive/car/gm/carcontroller.py

* fix crash

* long tuning

* we need long control state to resume

* CAMERA_ACC_CAR not needed

* no interp on accel

* tuning

* formatting

* formatting

* formatting

* formatting

* formatting

* no need to init ccp

* makes more sense now
2022-11-02 02:46:29 -07:00
Shane Smiskol
0f6f305f2d GM: add longitudinal deadzone (#26323)
* add deadzone

* Update ref_commit
2022-11-02 01:58:15 -07:00
Shane Smiskol
e46d162b1e GM camera ACC: show under enable speed alert (#26148)
* fix the fault more generically

* fix

* need this

* some clean up

* comment and use standstill

* comment

* add comment

* better fix

* rm

* better (for now)

* update docs
2022-10-19 01:28:46 -07:00
Shane Smiskol
4e82f68de2 GM camera ACC: prevent fault when engaging at a stop (#26079)
* prevent bolt fault

* comment

* only for camera ACC

* fixup alert

* bump cereal to master

* use new name

* Update selfdrive/car/gm/interface.py

* Update selfdrive/car/gm/interface.py

* Update selfdrive/car/gm/interface.py

* only care about prevent engagement when we look at PCM
2022-10-14 22:21:53 -07:00
Shane Smiskol
b7dc1968cd GM minSteerSpeed: add some tolerance for Volt (#25809)
* add some tolerance for volts

* add comment

* update refs
2022-09-15 21:21:10 -07:00
Jason Shuler
cfaa1b7d3e GM: Chevy Bolt EV 2022-23 (#25430)
* Chevy Bolt EV w ACC Port

* dashcam

* The website allows you to select the package without ACC

* fix Bolt E(U)V centerToFront

* Update selfdrive/car/gm/values.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-09-15 20:11:53 -07:00
Shane Smiskol
5a80fda819 GM: adjust Bolt EUV centerToFront 2022-09-15 19:24:18 -07:00
Jason Shuler
1aa8c0525e GM: Chevy Equinox 2019-22 (#25431)
* Chevy Equinox Port

* LKAS is not standard on 2019, but it's the same package as ACC. (LKAS standard 2020+)

* 2019 here too

* clean up

* add to untested

* not in docs

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-09-15 17:55:02 -07:00
Adeeb Shihadeh
655a64b603 single longitudinal toggle for e2e and disable radar (#25688)
* single longitudinal toggle for e2e and disable radar

* write disable radar param

* rename

* better param name

* clean that up

* update refs

* update translations

* not live for experimental

* write it out

* vanish
2022-09-07 17:12:49 -07:00
Shane Smiskol
3b602e2844 GM: update minimum steer speed (#25618)
* EUV is 10 kph

* Update ref_commit

* temp

* Revert "temp"

This reverts commit 90ce28b06ba623e7bd1252798af3c285b465e0ec.
2022-09-02 13:41:58 -07:00
Shane Smiskol
452d5e42ec Car docs: add auto-resume column (#25572)
* Move auto resume in sng to car interface

* Update docs

* shorter name, star

* order

* resumes?

* add hidden detail sentence

* good to know this works, but revert

* VW auto resume

* bump cereal to master

* Update ref_commit

* match cereal

* try this

* ?

?

* like this
2022-08-30 17:54:40 -07:00
Jason Shuler
1e9fdff642 GM: Chevy Silverado 2020-21 support (#25429)
* Silverado support

Co-authored-by: Jason Shuler <jshuler@gmail.com>

* Update docs

* Try 2 m/s/s

* Should be good torque values

* Add Silverado test route

* Add to releases

* Send counter

* can't send multiple or it faults

* Send at 33hz, no counter

* try 25hz, don't line up exactly with car's buttons

* never tried 10hz with same counter

* Update selfdrive/car/gm/gmcan.py

* Make same as pcmCruise branch

* update year and package (different packages needed per-trim)

* Update year in releases

* Revert to 21

* We can use this package name again

* wrong one!

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-08-19 16:58:06 -07:00
Shane Smiskol
e3d3fd0230 Common button enable/cancel event creation (#25445)
* handle button presses in create_common_events

* remove from imports

* Handle

* Fix Honda (it hardcodes pcmCruise)

* Update selfdrive/car/volkswagen/interface.py

* Update selfdrive/car/volkswagen/interface.py
2022-08-18 23:40:24 -07:00
Jason Shuler
4ffe9e68db GM: Bolt EUV 2022-23 port (#24875)
* Switch to ECMPRDNL2 for GM gear

* Removing manumatic gear #

* values.py almost complete

* Silverado and Bolt EUV val and CP

* GM controller updated

* Cam hrns supp done (in theory)

* cleanup for new cars

* Remove extra constant

* WS, etc cleanup

* removing the unused

* Fix kpBP typo

* Updated docs

* Skip's PIF tune

* Dropped LKA CAN error patch

* Add silverado sigmoid ff

* CAN Err & LKA latch patch

* Remove EPS fault fix (another PR)

* Remove Silverado (another PR)

* clean up some common params

* Remove Escalade FP

Remove Escalade FP

* comment

* Premier is just a trim

Premier is just a trim

Premier is just a trim

* no footnote: new Bolt is like most other cars, older GM were outliers not at the camera

* clean up

clean up

* bump panda

* bump panda

* bump panda

* bump panda

* bump panda

* remove comments

* try spamming buttons on bus 2

* bump panda

* bumping opendbc w btn rc

* not needed for this port

This reverts commit 6af1f0ba799e075f877d7acc8ca0f117d97da361.

* add button safety

* Send next rc when spamming btns

* forward other signals in message

* missing DriveModeButton

* fill cruiseState.speed

* see if resume works without counter

* try the whole message

* send immediately and at 10Hz

* no resume, back to just button signal

* even holding random buttons it cancels

* Use torque controller with base tune

* stock long GM don't auto-resume yet

* Testing GM zero min steer speed

* Revert latcontrol

* revert opendbc

* latActive is basically lkas_enabled

* Update Bolt torque params

* comment

* clean up

* Add to releases

* Add test route

* Don't specify segment

* bump panda

* bump panda

* no harness for Bolt just yet

* Apply suggestions from code review

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* We support all and 2023

* move safetyParam up to first cam check

* Bump panda and update docs

* Update RELEASES.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-08-12 16:10:34 -07:00
Tim Wilson
2a4020da60 GM: separate EV/ICE gas/brake lookup tables (#25354)
* GM: separate EV/ICE gas/brake lookup tables

* removed blank line

* V are the same

* comment

better ordering

comment

comment

* Add some delay for the laggy brakes

Add some delay for the laggy brakes

* move actuator to only acadia

* start braking at 0 m/s/s

* Revert "start braking at 0 m/s/s"

This reverts commit 55c1dee733aab3dc037fb1705c9bd0ace55c849f.

* add delay for escalade

* revert EV changes

* Update selfdrive/car/gm/carcontroller.py

* comment

* only ACADIA

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-08-08 13:55:40 -07:00
Jason Shuler
4bfbd7ced8 GM: parse low and manumatic gears (#24764)
* Switch to ECMPRDNL2 for GM gear

* Removing manumatic gear #

* formatting

* update refs

* update refs

* line

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-08-03 15:52:12 -07:00
Adeeb Shihadeh
d462a08056 remove CS.steeringRateLimited (#25251)
* remove CS.steeringRateLimited

* bump cereal

* update refs
2022-07-24 14:56:55 -07:00
Shane Smiskol
d2c2154a32 Clean up CarControllers (#25008)
* do VW

* Do the rest

* unused

* ford cc formatting

* final clean ups

* also just return update output
2022-06-30 17:23:12 -07:00
Jason Shuler
9279c02258 GM: prep and cleanup for future ports (#24910)
* Interface radarOffCan set, comments

* pass pcmCruise value to common events

* add transType and networkLoc to iface

* carstate use transtype to detect EV

* ctrl: limit sends by config

* Add clarifying comments for new vals

* clean up

* comment on new line

* these have the same frequency

* remove 25hz

* add to upper comment

* update refs

* update refs

* move into same block

move into same block

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-06-30 15:47:26 -07:00
HaraldSchafer
9283040d84 Rocket league model (#24869)
* dd9a502d-c8e2-4831-b365-804b0ae0739d/600 80041070-d276-4fed-bdb9-0075e5442908/420

* no elementwise op

* 9dabf0fe-2e60-44bf-8d3a-d20a74aca072/600 ae746590-0bb5-4a16-80db-15f02d314f03/300 c4663a12-b499-4c9b-90dd-b169e3948cb1/60

* explicit slice

* some copies are useful

* 1456d261-d232-4654-8885-4d9fde883894/440 c06eba55-1931-4e00-9d63-acad00161be0/700 af2eb6ba-1935-4318-aaf8-868db81a4932/425

* 154f663e-d3e9-4020-ad49-0e640588ebbe/399 badb5e69-504f-4544-a99e-ba75ed204b74/800 08330327-7663-4874-af7a-dcbd2c994ba7/800

* set steer rate cost to 1.0

* smaller temporal size

* Update model reg

* update model ref again

* This did upload somehow

* Update steer rate cost

Co-authored-by: Yassine Yousfi <yyousfi1@binghamton.edu>
2022-06-15 15:29:42 -07:00
HaraldSchafer
3066ad81a8 Car interface: set max lateral torque from table (#24789)
* json

* better naem

* Read from table

* formatting and default to nan

* Generate docs

* Read from table

* this should be the same

* Prius v is full

* test we always set the tunes correctly

add to release files

* Set for all cars

Set for all cars

* Revert tuning changes

Revert tuning changes

* remove that

* fixes

* update ref commit for new maxLateralAccels

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-06-10 17:57:23 -07:00
Jason Shuler
b95c449847 GM: interface cleanup (#24774)
* Move all defaults above models

* Remove reduntant/defaults

* make minEnableSpeed common

* Update selfdrive/car/gm/interface.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-06-07 17:23:08 -07:00
Shane Smiskol
c6bc03311c Car documentation: set steering torque star using car interface (#24709)
* Set good torque using torque controller tuning

* should be equal to

* save lateral accel to car params

* use maxLateralAccel

* always

* same convention

* nan will always evaluate to false

* The great good torque purge

* adjust default friction

* Add data for more cars

* adjust name

* Welcome back, guys. Only adjust good torque if maxLatAccel is set

* Update refs (1.7 is 1.7000001...)
2022-06-03 17:41:20 -07:00
Shane Smiskol
eed6803ccc Button-enable cars: common functions for button events (#24678)
* function for creating button events

* fix

* one line

* alphabetical

alphabetical

* only needed once

* common function for enable events

* add to list

* extend

* fixes

* add type hints

* flip around
2022-06-01 12:03:34 -07:00
Shane Smiskol
5b105facae Add ACC faulted status to carState (#24399)
* add accFaulted bool to carState

* same for VW

* remove import

* bump

* move to common

* bump cereal to master
2022-05-02 18:05:00 -07:00
Adeeb Shihadeh
49c2164814 add alert for CAN bus timeout (#24162)
* add alert for CAN bus timeout

* add alert

* set in interface

* cleanup

* cleanup

* add event

* fix mock

* bump

* bump opendbc

* update refs

* return reader
2022-04-12 22:58:34 -07:00
Shane Smiskol
c8f5b21744 Clean up CarInterface.apply and CarControllers (#24060)
* do tesla

* parentheses

* Do Chrysler

* Make sure Hyundai long never actuates when long inactive

.

* clean up Hyundai

* more clear

* formatting

* Stock sets these to zero

* fix params

* move jerk logic into CC

clean up
2022-04-05 23:38:45 -07:00
Adeeb Shihadeh
bae78dd46b don't read params in car interfaces (#23978) 2022-03-16 15:17:47 -07:00
Adeeb Shihadeh
ae19308e83 add parkingBrake to carState (#23968)
* add parkingBrake to carState

* fix gm
2022-03-14 16:32:20 -07:00
Adeeb Shihadeh
8718a59330 cleanup selfdrive/test (#23967)
* move test routes and test_models

* move fingerprints

* little more

* remove that
2022-03-14 15:46:16 -07:00
Adeeb Shihadeh
5c3f3e44bc break up selfdrive.config (#23959)
* break up selfdrive.config

* add to release files

* fix import order
2022-03-13 21:42:39 -07:00
Shane Smiskol
629399a449 carControl: add long and lat active fields (#23859)
* proof of concept

* actuators packet describes which actuators are active

* bump cereal

* fixes

* not needed for this PR

* Do Toyota

* add back controlsState.active

* bump cereal

* rest of cars

* in actuators

* add active back

* which

* use controlsState.active for now

* will make an issue

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* move local lat_active checks into CC.latActive

* remove redundant checks

* move comment

move comment

* fix joystick mode

* get enabled from carcontrol

* do standstill check in controlsd

* make sure we consider the gas press case for GM

* use CC.actuators

* fix

* capitalization

* Bump cereal

Bump cereal

* make intermediate actuators

* similar convention to before

* clean that up

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-13 20:58:44 -07:00
Shane Smiskol
fccb80e9a5 GM: remove noisy ignition signal (#23698)
* move BUICK_REGAL to dashcamOnly

* bump to master
2022-02-03 12:32:33 -08:00
Adeeb Shihadeh
72e00a0768 No actuation while in pre-enabled state (#23658)
* No actuation while in pre-enabled state

* update refs
2022-01-28 16:03:44 -08:00
Dean Lee
a653461dec check in tuple instead of list (#23477)
* check in tuple instead of list

* Update selfdrive/car/toyota/carcontroller.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Update selfdrive/car/mazda/interface.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2022-01-10 16:36:51 +01:00
kevinharbin
c7fb8f4e32 selfdrive/car/gm/interface.py: fix typo in comment (#23429)
spelling
2022-01-06 15:53:48 +01:00
Adeeb Shihadeh
450656e2a7 GM: move abandoned cars into dashcam only (#23423) 2022-01-05 19:48:06 -08:00
Dean Lee
05b905d140 interfaces/apply: follow capnp best practices (#23371) 2022-01-04 11:34:49 +01:00
Willem Melching
4f1eb4278a Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
2021-12-16 13:08:20 +01:00
Dave
957864019a GMC Acadia: Add lateral feedforward function (#22899)
* GM Acadia lateral tuning

* old tune was not returning to center, nor strong enough. Trying to make P and F equal.

* reduce integral, and eyeball actuator delay

* return PI to openpilot default

* remove default values from acadia

Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>
2021-11-18 15:45:37 -08:00
Jason Young
b49f518782 GM: EPS fault workaround (#22404)
* seems legit

* panda -> loopback

* fix comment

* add some "why" comments for the next guy

* re-test with stock 50Hz rate

* ugly test

* Update selfdrive/car/gm/carstate.py

Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>

* update refs

* Update selfdrive/car/gm/carstate.py

Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-10-28 16:54:12 -07:00
Gibby
46009fa6fd GM: 2016 Escalade ESV (#22670)
* Added 2016 Escalade ESV fingerprint and data.

* Updated CARS.md for GM vehicles

* Uploaded Escalade fingerprint

* Removed part about auto high beams for GM. Seems to work for some.

* Revert other modifications in CARS.md

* Revert other modifications in CARS.md

* Added test route for Escalade

* Added tunning for Escalade to reduce jerky steering

* Apply suggestions from code review

* Update selfdrive/car/gm/interface.py

* cleanup test route

Co-authored-by: Gibby <git@twoitguys>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-10-26 15:59:24 -07:00
qadmus
2e0bc9d365 GM: improved Volt lateral tuning (#22621)
* GM Volt lateral tuning and feedforward function

* improve comments, lower P 5% to 0.17, which matches all my notes over time, 0.18 was a last test change.

* don't justify actuator delay for now

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-10-21 14:10:41 -07:00