Commit Graph

60 Commits

Author SHA1 Message Date
xps-genesis
a3d754a8d8 Car Port: 2020 Hyundai Kona (#2010)
* update KONA car port

* update Kona  Car Port

* ignore kona EV

* add Kona route

* update readme for Hyundia Kona

* remove electric for regular Kona
2020-08-11 13:42:19 -07:00
martinl
c9adc4900b Add preglobal Subaru Forester and Outback (#1993)
* Add preglobal Forester and Outback

* Tests and values cleanup

* Update units in carstate

* Remove ()

* Add OUTBACK_PREGLOBAL_2018 to non_tested_cars

* Add replay route for OUTBACK_PREGLOBAL_2018
2020-08-10 12:31:40 -07:00
xps-genesis
a16a948f9e Car Port: Hyundai Genesis G70 2018 (#2000)
* Car port Genesis G70

* Car port G70

* rebase

* update G70 car port

* Update README.md

* no space

* rebase mistake

* Update values.py

* Update values.py

* Update values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-08-08 22:20:25 -07:00
Adeeb Shihadeh
5e82578a1b Remove non-SCC Hyundai Kona port (#1997) 2020-08-08 11:48:16 -07:00
martinl
e37b8e5d56 Subaru pre-global: add support for Subaru Legacy 2015-18 (#1805)
* Add support for Subaru Legacy 2015-18

* syntax fix

* Add Legacy 2018 FPv1

* Add Subaru Ascent from upstream

* Use GLOBAL_CAR and LEGACY_CAR lists

* Change LEGACY_2015 to LEGACY_PREGLOBAL

* Add LEGACY_CAR to carstate

* Change LEGACY_2015 to LEGACY_PREGLOBAL in test_car_models

* Add missing SafetyModel to Ascent

* Use GLOBAL_CAR and LEGACY_CAR to set safetyModel

* Change LEGACY_CAR to PREGLOBAL_CARS, remove GLOBAL_CAR

* Fix PREGLOBAL_CARS in carstate and subarucan

* Minor cleanups

* Add accelCruise button event

* Change Preglobal Driver Torque limit to match Global

* Match comments to upstream

* Use Steer_Warning and Steer_Error_1 only for Global

* Change mph units to match upstream values

* Increase Preglobal brakePressed  threshold to 2

* Add DashcamOnly to LEGACY_PREGLOBAL

* Fix typo in variable name

* Update README, add create_preglobal_steering_control

* cleanup carcontroller

* cleanup values

* missed that one

* Update STEER_STEP

* Update STEER_MAX

* Add preglobal signal frequency checks

* remove PREGLOBAL_CARS from subarucan

* Remove whitespace

* Use common frequency checks

* cleanup carstate

* cleanup subarucan

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-08-06 21:55:13 -07:00
xps-genesis
6e1bcdcb34 Add Hyundai Veloster 2019 (#1955)
* Add Hyundai Veloster 2019

* Add Hyundai Veloster interface.py

* add route for Hyundia Veloster

* steer ratio fix

* Update interface.py

* new longer route

* space

* ignored fingerprint

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-08-02 15:45:41 -07:00
Adeeb Shihadeh
433c9241f3 we have routes for these now 2020-08-02 15:25:09 -07:00
Adeeb Shihadeh
e89b2b8453 Test can valid in car unit tests (#1961)
* check can invalid

* remove bad lexus is route

* blacklist routes from before cam forwarding

* fix rav4 route with missing first segment
2020-08-01 22:38:19 -07:00
Adeeb Shihadeh
63e4aeac9f fail new car model unit tests if missing a test route 2020-07-28 23:37:53 -07:00
Adeeb Shihadeh
360cd7d8a8 kia stinger: use hyundaiLegacy safety mode and add test route 2020-07-26 14:09:49 -07:00
Adeeb Shihadeh
4bc90c578a add test route for HYUNDAI.KIA_SORENTO 2020-07-23 15:44:14 -07:00
Adeeb Shihadeh
f753ca14ad add HYUNDAI_GENESIS test route 2020-07-23 13:24:06 -07:00
martinl
b1abf17752 Support for 2019 Subaru Ascent (#1801)
* Add support for Subaru Ascent 2019

* remove duplicate safetyModel

* Add Ascent 2019 to README.md
2020-07-01 16:54:40 -07:00
Adeeb Shihadeh
57deb3a893 Hyundai Ioniq SE 2020 (#1786)
* Update values.py

* Update carcontroller.py

* Update values.py

* Update interface.py

* Update carcontroller.py

* add test route

* readme

Co-authored-by: baldwalker <insigniadesign@yahoo.co.uk>
2020-06-26 12:25:09 -07:00
martinl
09e7d4ab3a Subaru Forester 2019 (#1768)
* Add initial Forester 2019 support

* Add dgranger15 Forester 2019 FPv1

* fingerprint syntax fix

* FPv1 syntax fix 2

* Add Forester 2019 to CAR

* fix indent

* Add Forester 2019 to test_car_models ignore list

* Update Forester 2019 steering tuning (dgranger15)

* Add Forester 2019 to README.md

* Change lists to single value

* Add test route for Forester 2019

* Remove model year

* Remove Forester model year in test_car_models

* Remove usernames, add Forester ACC speed mph unit value
2020-06-23 16:07:46 -07:00
Adeeb Shihadeh
224672705c Hyundai Ioniq EV LTD (#1694)
* add ioniq

* bump panda

* test route

* bump pnada
2020-06-15 11:45:37 -07:00
Adeeb
367155168a Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
2020-06-03 16:13:34 -07:00
Willem Melching
843a64c72f Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
2020-06-02 16:29:32 -07:00
Adeeb Shihadeh
27754a277c enable E261 in flake8: two spaces before inline comment 2020-05-31 14:07:29 -07:00
Andre Volmensky
9fc826cb5c Added Rogue 2019/Leaf 2019 fingerprints (#1605)
* Added Rogue 2019/Leaf 2019 fingerprints

* Added Rogue as new car. Updated readme

* Added route to test_car_models.py. Fixed if statements to check against rogue/x-trail

* Fixed paste error

* Merged Leaf fingerprints

* Assume Rogue is MPH until we work out the mph/kph bit
2020-05-30 20:25:32 -07:00
Adeeb
d9bf9f0a40 Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
2020-05-30 20:14:58 -07:00
Jafar Al-Gharaibeh
34b9b5e849 Bounty: Mazda (#988)
* Mazda Port

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update checksum to account for steer angle signal used in some cars

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add test drive/segment ID to pass CI tests

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Process gear and brake signals, add new fingerprints

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor some car interface code

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop redundant call, use Ecu, move warning to carstate, fix cruise speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop unused variables, cleanup handsoff tracking

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update to steerError and steeringRate

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor parse gear, update lkas signals from the new dbc

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Better tracking of engage and warning events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* remove commented lines, update speed_kph to match panda

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Steer Error

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Set lkas enable speed to 52 kph

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop block signal use, fix LGTM alerts

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* When gas is pressed OP will disengage, sync local state with it

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Use car's speed signal instead of wheel speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Tidy up disengage events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Rebase/Refactor with upstream

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Sync stock ACC state with OP

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* mazda dbc file renamed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Improve acc stock and go by removing the 3 seconds limit

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Dashcam

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* PR Feedback

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Send ACC cancel only if we are sure cruise is enabled

Otherwise we run the risk of disabling main cruise

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* updated route

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* no process replay for now

* add to release files

* Revert "updated route"

This reverts commit 233db4f1bc2d8eefaa86488be4f6f88360d20793.

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-05-28 22:15:19 -07:00
Willem Melching
3d08dcc3b2 Run mypy commit hook (#1591)
* run mypy commit hook

* fix mypy errors
2020-05-28 15:05:04 -07:00
Adeeb
c78602e8cc Remove incomplete Hyundai Ioniq port (#1570) 2020-05-26 20:48:41 -07:00
Thaixican
dd16990952 Add 2020 Lexus RX Hybrid support (#1547)
* Add 2020 Lexus RX Hybrid support

* Add 2020 Lexus RX Hybrid to IGNORED_FINGERPRINTS and route to test_car_models per @pd0wm
2020-05-26 13:49:18 -07:00
Willem Melching
ef2ea14ecc add sonata 2019 to test_car_modelsg 2020-05-20 17:20:17 -07:00
Alice Knag
fde1a5e9af add support for Sonata 2019 (#1538)
* add sonata interface

update values.py

update values.py

* change sonata_1 to sonata_2019

* add sonata 2019 and forte 2019 to README

prettier fucked me up pretty hard at first
sdfsd

* update README.md

* mock test
2020-05-20 17:12:00 -07:00
Willem Melching
96605d0951 This one also needs to be fixed 2020-05-19 16:19:00 -07:00
Adeeb Shihadeh
8788ab36e4 remove those debug prints 2020-05-19 13:54:24 -07:00
Willem Melching
bb8bbdd9ee Hyundai fw query (#1540)
* hyundai fw query

* Change query

* this works

* That is not engine

* hyundai fw query

* Change query

* this works

* That is not engine

* Skip FW query in test_car_models

* Those routes don't fingerprint properly after speedup

* only send toyota queries to subaddresses

Co-authored-by: openpilot laptop <laptop@comma.ai>
2020-05-19 13:43:44 -07:00
Erich Moraga
009c32d516 Add HIGHLANDERH_TSS2 Support (#1425)
* exclude HIGHLANDERH_TSS2

* add HIGHLANDERH_TSS2 support

* Add HIGHLANDERH_TSS2 Support

* Add HIGHLANDERH_TSS2 Support

* Added to IGNORED_FINGERPRINTS per @pd0wm
2020-04-27 14:56:30 -07:00
cowanhmoore
1d6042c5f3 Honda HRV (#1404)
* PR - Honda HRV

values.py - incl. Class, FP, FW_VERSIONS, SPEED_FACTOR 1.025
carstate.py - incl. carFingerprint, doorOpen OVERRIDE (signal unknown)
Safety test concludes that removal of drivers seatbelt IMMEDIATELY disengages OP
interface.py - incl. HR-V vehicle parameters, tuning (tested for 100+ miles)
Longitudinal tuning parameters unchanged from CAR.FIT
test_car_models.py - added per request of review process
*5. honda_hrv_touring_2019_can_generated.dbc will be submitted to commaai/opendbc in next PR

Once *5 is approved, will need to update values.py to matching dbc

Thanks, Cowan Moore 330-701-3922

* Honda HRV Door Signal

BO_ 422 SCM_BUTTONS: 8 SCM
 SG_ DRIVERS_DOOR_OPEN : 63|1@0+ (1,0) [0|1] "" EON

* Update values.py

* Update test_car_models.py
2020-04-20 15:30:46 -07:00
Willem Melching
ed527dfd1e Add Palisade to test_car_models 2020-04-17 11:46:16 -07:00
Willem Melching
7d78cef34b Hyundai-Kia-Genesis (HKG) (#1362)
* hkg

* Cleanup

* Update readme

* more fixes and cleanup

* Old genesis

* Typoe

* Test car models

* Update comment

* Fix brake pressed

* Update release notes

* Fix vEgo

* Add sonata

* Add sonata values

* Temporarily remove doors check. It doesn't work

* Sonata uses crc8

* Fix tests

* Changes for LFA

* Add comment

* Does this improve the hud?

* Proper signal name

* Force the right value

* some ui stuff

* more comments

* Show lane lines on sonata

* cleanup dash

* fix last ui issues

* Fix doors

* update CI

Co-authored-by: Comma Device <device@comma.ai>
2020-04-15 19:33:24 -07:00
Adeeb
e22482eb31 Remove Cadillac CT6 port (#1359)
* remove CT6 port

* dont need this route

* extra char

* fix carcontroller params
2020-04-13 15:53:24 -07:00
Willem Melching
746f7ed9b1 2020 Chrysler Pacifica (#1297)
* 2020 pacifica support

* Update readme
2020-03-31 15:47:49 -07:00
Willem Melching
1df6b67511 Nissan leaf (#1275)
* split out leaf and xtrail

* Add brake pedal

* This should work

* Fix test car models + bump panda

* Combined cruise enabled detection in single message

* Proper frequency checks

* Add doors

* Blinkers and doors

* Seatbelt

* Gear

* Add cancel message

* Unify steering pressed

* Remove angle limit

* Add steer saturation alert for angle based control

* Add set speed

* Change wheel speed factor

* Fix offset in set speed

* Timeout on engage for steer saturated

* Put counter back

* try cancel using seatbelt

* Try different cancel message

* Rename cancel signal

* Add LKAS alert

* Add missing fingerprint values

* Update test car models

* Add some comments
2020-03-27 21:44:59 -07:00
Chris Souers
035397cd31 Adds 2016 CR-V Executive (Euro version of Touring trim) (#1097)
Co-authored-by: Ted Slesinski <ted_slesinski@epam.com>
2020-03-13 11:48:08 -07:00
Willem Melching
768f08e129 add honda pilot 2019 to test car models 2020-03-11 16:51:45 -07:00
Willem Melching
fbac82ea21 add accord 1.5L to test_car_models 2020-03-07 11:05:46 -08:00
Willem Melching
82f77e379b add crv5g and optima to test_car_models 2020-03-06 17:33:30 -08:00
Willem Melching
3d15eb39d5 Add 2017 Pacifica Hybrid to test_car_models 2020-03-06 17:13:09 -08:00
Willem Melching
a25acaae07 More public routes in test car models (#1208)
* remove non public routes

* Fix linter

* add rav4h

* add odyssey

* add pilot and civic_bosch

* cth and camry

* add regal
2020-03-06 13:44:34 -08:00
Willem Melching
6db044c86c Nissan port - dashcam only (#1203)
* Nissan port

* add x-trail to release notes

* update readme and model

* remove from releases until tested

* Don't test Nissan for now

* Forced dashcam in test_car_models
2020-03-05 15:40:07 -08:00
theantihero
c8c4708f21 Add 2019 Honda Insight (#1166)
* add 2019 Honda Insight + fw fp

* add actual fp and add to ignored, but still required for ECU detection

* add Insight dirty route for now

* update README.md, was wrong mph for each

* update test_car_models

* remove dbc extension
2020-02-27 14:56:36 -08:00
Chris Souers
ba6f555ede Add support for 2019 Civic Sedan 1.6L Diesel with CVT (#1091)
add car

Update test_car_models.py

Update test_car_models.py

add firmware

Update README.md

Update test_car_models.py
2020-02-21 11:03:10 -08:00
Willem Melching
fdbe289e71 Add HONDA.ACCORDH to test_car_models (#1143)
Co-authored-by: Arne Schwarck <arneschwarck@gmail.com>
2020-02-20 16:23:29 -08:00
Willem Melching
85e8bb90d4 Merge 2019 and 2020 Chrysler Pacifica Hybrid (#1142)
* Merge 2019 and 2020 Chrysler Pacifica Hybrid

* fix carcontroller
2020-02-20 16:23:10 -08:00
Willem Melching
9e6e1cba56 Fingerprint rav4 hybrid tss2 only using firmware versions (#1084)
* fingerprint rav4 hybrid tsss only using firmware

* remove print statement
2020-02-12 12:59:38 -08:00
Patipat Susumpow
576317ad10 Add support for Lexus NX 300h 2018 (#1077)
* Add support for Lexus NX 300h 2018

* Add Lexus NX 300h 2018 to README.md

* Fix a misplaced value CAR.LEXUS_NXH in the values.py
2020-02-11 19:27:17 -08:00