Commit Graph

260 Commits

Author SHA1 Message Date
Shane Smiskol
f12a1c2584 car intrfaces: no test deadline (#29720)
set deadline to None
2023-08-30 15:30:37 -07:00
Jason Wen
7bc2667ab6 Hyundai: Car Port for Ioniq 6 2023 (HDA2) (#29486)
* Hyundai: Car Port for Ioniq 6 2023

* Update docs

* bump panda

* Attempt to block laneline information to suppress LFA

* Try 0x364

* Block 0x364|BYTE7

* Attempt to block LFA on 0x364

* Block all bus 2/6 messages

* Lowercase to match DBC

* Aight

* we don't use this

* Final test to block LFA

* No byte 7

* Fix

* Fix tx

* This platform does SCC from radar

* Generate CARS.md

* cleanup

* Fix

* Fix 2

* bump submodules

* add test route for HDA2

* Support non-HDA2 trims in future PR

* segment 6

* bump opendbc

* Update username

* Check for new LKAS addr instead

* Update comment

* sync with dbc

* Combine LFA suppress can sends

* Add new tx to unit test

* bump opendbc

* we'd need a new DBC for that

* update docs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-30 01:10:28 -07:00
Jason Wen
fafca0e44d Hyundai: Car Port for Kona EV 2nd Generation (HDA2, 2023 Korean Ver.) (#28725)
* Hyundai: Car Port for Kona EV 2nd Generation (2023 Korean Ver.)

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* gate with flag

* new blinker signals for 2nd Gen Kona

* add test route

* Update CARS.md

* bump opendbc

* match opendbc definition

* Attempt to block laneline information to suppress LFA

* Try 0x364

* Block 0x364|BYTE7

* Block all bus 2/6 messages

* Lowercase to match DBC

* Aight

* we don't use this

* Final test to block LFA

* No byte 7

* Fix

* Fix tx

* cleanup

* HDA2 support

* Update RELEASES.md

* bump opendbc

* from `liveTorqueParameters`

* add test route

* bump panda

* official spec

* Check for new LKAS addr instead

* Update comment

* sync with dbc

* Combine LFA suppress can sends

* bump opendbc

* Add new tx to unit test

* linter

* Consolidate

* rename and update torque params

* add note for blinker weirdness

* bump

* bump

* clean up block msg

* it uses LFA if long

* not used in multiple places

* bump panda

* correct name

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-30 00:02:19 -07:00
Kacper Rączy
97865d751f radard: radar fault test (#29673)
* Radar fault test

* Remove i

* Add radar fault case for car interfaces

* Removed empty whitespace

* Fix typo
2023-08-28 22:34:47 -07:00
Shane Smiskol
3cc328163b FW query timing test: fix refs (#29692)
* fix refs

* don't round added values

* fix
2023-08-28 17:52:49 -07:00
martinl
a1bf66a0d2 Subaru: Ascent 2023 dashcam mode (#27583)
* Subaru: Add support for 2023 Ascent

* Update supported cars list

* Remove tester present from fw query

* merge master

* fix merge issues

* minimize diff

* add comment about 23 ascent

* add comment

* correct spot

* fix name

* nocap

---------

Co-authored-by: Justin Newberry <justin@comma.ai>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-25 20:55:21 -07:00
Shane Smiskol
3b69187b67 Kia: add test route for Optima Hybrid (#29520)
* add Optima H FW

* undashcam

* add to routes, but keep in dashcam mode for now

* rearrange
2023-08-25 20:12:57 -07:00
Justin Newberry
1ee6ed4b16 Linter: remove pylint (#29611)
remove pylint
2023-08-24 16:30:54 -07:00
Shane Smiskol
821cfff56d car interfaces: long running fuzzy test (#29592)
* draft

* draft 2

* increase deadline and run

* imports

* run -> use
2023-08-24 10:45:50 -07:00
Shane Smiskol
d58cb9994f car interface test: pick from possible ECUs (#29593)
pick from possible ecus
2023-08-24 05:27:58 -07:00
Shane Smiskol
e38ce6087f car interfaces test: don't sleep (#29589)
don't sleep in test_car_interfaces
2023-08-24 04:24:22 -07:00
Shane Smiskol
3719be8b76 Subaru: Forester Hybrid 2020 dashcam (#24770)
* Add support for Forester Hybrid 2020

Co-authored-by: martinl <martin@mlp.ee>

* it's a param now

* make it work

* fix

* merge and cleanup

* remove duplicate

* should be forester

* bump submodules

* should be abs

* add missing params

* still need a test route

* still need a test route

* consitent

* here too

* todo

* more

* Update selfdrive/car/tests/routes.py

* clean up

---------

Co-authored-by: martinl <martin@mlp.ee>
Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
2023-08-23 21:30:12 -07:00
Adeeb Shihadeh
973d90be77 Subaru: Crosstrek Hybrid dashcam mode (#25378)
* Subaru: Crosstrek Hybrid support

* hybrid cars in dashcam only

* revert that

* just dashcam

* tah should be abs

* remove unused import

* use the old dbc for now

* hybrid car exceptions in carstate

* need dashstatus until we get a proper cruiseactivated bit

* missing CP

* merge conflicts

* lets be consistent about extend

* cleanup

* fix and comments

* preglobal fix

* and the rest

* and this

* added hybrid to release

---------

Co-authored-by: Justin Newberry <justin@comma.ai>
2023-08-23 18:50:55 -07:00
Shane Smiskol
365bdd3422 Revert "FW query: query one sub-address in parallel" (#29550)
Revert "FW query: query one sub-address in parallel (#28675)"

This reverts commit 861ceb2fee.
2023-08-23 01:41:28 -07:00
Shane Smiskol
861ceb2fee FW query: query one sub-address in parallel (#28675)
* put one subaddr in parallel_addrs

* p

* remove print

* update test refs

* test

* revert test changes

* do same in present ECU query, lower threshold to catch (~0.82 to ~0.72 right within bounds)

* type

* clean up

* update test ref
2023-08-23 01:31:04 -07:00
Shane Smiskol
1ea310b202 Update FW query total time 2023-08-22 23:58:29 -07:00
Shane Smiskol
7de9842245 FW Query: test noOBD queries on aux panda (#29547)
* huh, this test just works!

* fix

* Update selfdrive/car/tests/test_fw_fingerprint.py
2023-08-22 23:43:52 -07:00
Jason Wen
bfa714ef3b HKG: Car Port for Kia Sorento Hybrid 2023 (#29322)
* HKG: Car Port for Kia Sorento Hybrid 2023

* Update CARS.md

* Oops

* add test route

* specify segment

* all packages

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-21 14:34:53 -07:00
Adeeb Shihadeh
a9626f95b6 add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
2023-08-20 20:49:55 -07:00
Shane Smiskol
ac07c205ed Nissan: add alt request for engine on Rogue (#29477)
* get engine

* \xda should work

* fix issue

* Update selfdrive/car/nissan/values.py

* bump ref

* other ref
2023-08-18 23:47:58 -07:00
Shane Smiskol
6253dca9eb CAN fingerprint: timing test (#29461)
* test fingerprint frames (timing)

* guess not needed

* it checks both buses

* use case list

* this is safe since we call current test only in the current loop, never after

* prof

* test this too
2023-08-18 14:33:13 -07:00
Shane Smiskol
19767da668 CAN fingerprint: test fingerprint response (#29462)
* test finger

* split up
2023-08-18 00:37:32 -07:00
Shane Smiskol
3563292e65 test_models: remove body standstill exception (#29453)
* remove body exception

* bump to master
2023-08-17 16:26:30 -07:00
Shane Smiskol
fd8f8d8785 CAN fingerprinting test (#29427)
* timing test

* test

* fix

* print

* loop

* clean up

* wider range

* Update selfdrive/car/tests/test_models.py

* Apply suggestions from code review

* run many times

* Update selfdrive/car/tests/test_models.py

* run for many its

* run with unittest and print as list

* Update .github/workflows/selfdrive_tests.yaml

* Update .github/workflows/selfdrive_tests.yaml

* total time is super inconsistent (body)

* Update selfdrive/car/tests/test_models.py

* clean up

* clean up

* clean up

* this works!

* draft

* test suite not as modular

* try something like this

* can do kb, but not too representative

* clean up

* remove kb? it depends on signals

* clean up

* more clean up

* rename

* just measure all CANParsers

* can do all this manually

* but this is way simpler

* comment

* stash

* draft

* draft

* remove old script

* clean up

* revert

* use it

* remove test

* opt

* no partial

* remove

* revert test_models

* test can fingerprinting

* so much simpler!

* fix dict resizing

* simplify

* need to do this

* fix

* move to new file

* rename

* comment

* ignore function-uses-loop-variable
2023-08-17 00:57:12 -07:00
Shane Smiskol
9d0d59ac9b Hyundai: match panda standstill check (#29442)
* bump panda

* clean up

* common?

* Revert "common?" (not now)

This reverts commit 197af7cdbb6a8c8e58fcbccca94f7db004ce91e4.

* fix

* no failures!

* remove time

* bump

* bump

* undo
2023-08-17 00:06:38 -07:00
Shane Smiskol
2d636deb4e test_models: check panda cruise state (#29423)
* cruise state test

* add todo

* rename

* clean up

* remove
2023-08-15 23:55:53 -07:00
Shane Smiskol
4073ffb02b test_models: add full internal segment list (#29425)
full internal test models seg list

remove avalon and sienna

volt with ascm on

another volt with ascm on

9bc2ee633c361c3d|2023-07-28--20-17-51--2

dashcam mode

c4e21532b6fe3847|2023-07-05--08-34-05--1

can invalid (missing PSCMStatus)

cf6ba99592c48848|2023-07-01--11-36-56--20
2023-08-15 23:33:52 -07:00
Shane Smiskol
e2910d0720 CANParser: perf benchmark on route script (#29324)
* timing test

* test

* fix

* print

* loop

* clean up

* wider range

* Update selfdrive/car/tests/test_models.py

* Apply suggestions from code review

* run many times

* Update selfdrive/car/tests/test_models.py

* run for many its

* run with unittest and print as list

* Update .github/workflows/selfdrive_tests.yaml

* Update .github/workflows/selfdrive_tests.yaml

* total time is super inconsistent (body)

* Update selfdrive/car/tests/test_models.py

* clean up

* clean up

* clean up

* this works!

* draft

* test suite not as modular

* try something like this

* can do kb, but not too representative

* clean up

* remove kb? it depends on signals

* clean up

* more clean up

* rename

* just measure all CANParsers

* can do all this manually

* but this is way simpler

* comment

* fix mypy

* this is correct too

* 3 seconds instead of 1.5
2023-08-15 20:06:15 -07:00
Shane Smiskol
6ec00f5ee2 test_models: more typing (#29420)
* not type checked, but we set this in test_car_model

* type this
2023-08-15 20:01:33 -07:00
Shane Smiskol
936f8b9817 test_models: some typing (#29413)
* type

* also type check this func

* unused
2023-08-15 15:25:36 -07:00
Shane Smiskol
fb235238ad jenkins: re-enable test_models (#29394)
* re-enable test_models

* now?

* Remove bad Volt segment

* Update Jenkinsfile

* use first n segments
2023-08-14 16:08:34 -07:00
Shane Smiskol
001d4e8729 test_models: match online fingerprinting behavior (#29306)
* draft

* 1x

* clean up

* final clean up

* fix

* self explan

* space

* space
2023-08-11 18:33:11 -07:00
Shane Smiskol
1099b3486a test_models: check relay malfunction (#29270)
* check relay malfunction in test_models

* draft

* actual relay malfunction (or ASCM was turned on)

* rav4: not dashcam and op enabled, but we're not sending anything

* clean up

* spaces

* more space

* flip

* better?

* combine

* for

* move up
2023-08-11 18:10:27 -07:00
Justin Newberry
62c1e65924 Ruff: enable most of bugbear (#29320)
* added mutable default args

* most of the Bs

* add comment about lrucache
2023-08-11 15:33:49 -07:00
Justin Newberry
8793cbff40 Ruff: enable flake8-builtins (#29315)
* enable flake8-builtins

* replace any with contains

* fix typo in pack

* fix type

* format is from the parent module, has to be enabled

* item_id

* fix item_id

* disable for id since that's what the remote server returns
2023-08-10 18:58:22 -07:00
Justin Newberry
4a9afd7554 Ruff: comprehensions conventions (#29317)
ignore c408
2023-08-10 16:40:30 -07:00
Shane Smiskol
70b1e9dd75 test_models: run on route list (#26226)
* move to openpilot

* draft

* support internal urls

* not used

* update seg list

* regen segment list

* regen seg list

* regen

* regen

* regen

* no dirty segments

* regen seg list with no fuzzy or fixed fp

* regen segments with hda2 exception

* regen with added filters

* regen without bad dongle

* regen

* regenerate!

* regenerate, only OP enabled

* regen

* regenerate!

* regenerate!

* stash

* use SegmentName

* new route list

* add temp comment

* remove comment

* let's see if this works

* comment out other tests to speed up

* fix agent

* ?

* hmm

* oh whoops...

* add matrix

* fix

* how many levels do we need?

* fix values

* matrix can't be in parallel

* how about this

* try this

* Revert matrix

Revert "try this"

This reverts commit 8d0d91fd70c467c1fbb4e4e9aed511d15b2a30ef.

Revert "how about this"

This reverts commit a8e4fc53234824e77cbfb1e471277bc033e9dea1.

Revert "matrix can't be in parallel"

This reverts commit daaa6fcc3c75c74cbb90e97c565099a94123994c.

Revert "fix values"

This reverts commit df554b6a3371d124a574eb8d26bc51ef5b5b8fde.

Revert "how many levels do we need?"

This reverts commit 1a17320fa1c5e7220ef60e29981bbb3bb7da16c6.

Revert "fix"

This reverts commit e7eb6e404358fbd2eac3fea1901a8d30ea92d729.

Revert "add matrix"

This reverts commit a1b57e5725417d3c2f639f8edfc0c889b84b6753.

* use pytest instead! (5 jobs is ~150 mins)

* split lines, uncomment

* This Sienna seg has a fault SDSU that stopped forwarding/sending msgs

* picked a route with no PSCMStatus and no panda errors, recent routes are working

* this cadillac was dashcammed (no radar)

* opened an issue for this, it's 'expected' right now

* small clean up

* small clean up

* i don't think that worked

* is this needed?

* add to new PC tests

* cache

* draft

* Revert "draft"

This reverts commit 3b7f740dd4883118747300bc3687074c2d3c2116.

* probably should be function

* draft

* clean up

* add todo

* 600 random segments

* debug

* does this fix pythonpath issues?

fix

* try this

* mount?

* pytest again!

* no need for PYTHONPATH now

* Update Jenkinsfile

* ?

* convention

* clean up

* would be even more complex (have to unset ci which is class level)

* track

* is lfs pulled at all?

* ah no it's not
2023-08-10 00:45:23 -07:00
Shane Smiskol
225ed2ed5a interfaces: test interface attributes (#29301)
* test

* draft

* draft

* clean up

* clean up

* better test

* clean up

* check car info

* uncomment

* rm space

* no loop

* use dbc

* more clear

* one line
2023-08-09 17:01:38 -07:00
Adeeb Shihadeh
51831d03a3 Revert "interfaces: test interface attributes (#29297)"
This reverts commit 6a678cde6c.
2023-08-09 16:28:12 -07:00
Shane Smiskol
6a678cde6c interfaces: test interface attributes (#29297)
* test

* draft

* draft

* clean up

* clean up

* better test

* clean up

* check car info

* uncomment

* rm space

* no loop

* use dbc

* more clear

* one line
2023-08-09 16:10:30 -07:00
Justin Newberry
cf64b27168 Linter: Fix >160 line length test (#29287)
* test

* fix line length

* fix line length

* fix file size

* revert poetry

* cleanup for PR
2023-08-08 17:13:35 -07:00
LC
5ace930c5c Toyota: Lexus IS 2023 port (#29257)
* added LEXUS_IS_TSS2 to values.py

* added LEXUS_IS_TSS2 to interface.py

* Apply suggestions from code review

* add torque params

* add test route

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-08 16:34:37 -07:00
Shane Smiskol
328bfefb5a FW query timing test: fix total time ref 2023-07-31 22:18:06 -07:00
Justin Newberry
38954418f0 Subaru: New LKAS Angle based cars in dashcam only (#29190)
* dashcam mode only

* fix name

* added those cars in dashcam mode only
2023-07-31 13:58:33 -07:00
Shane Smiskol
80bbba14f7 test_models: panda safety tx test (#28949)
* draft

* assertrue

* this is way too complicated, even with unittest discover

* works

* test we can send resume button

* nice catches this

* fix

* fixed

* not needed

* draft

* works

* comment out to let catch

* clean up into a function

* clean ups

* final clean up

* no this is final

* bump

* simplify

* simplify

* pass

* bump

* globals don't work inside methods

* space
2023-07-20 23:16:43 -07:00
Shane Smiskol
18cf253c62 test_car_interfaces: use DT_CTRL 2023-07-18 20:01:22 -07:00
Shane Smiskol
c9f80e89b7 test car interface: fuzzy CarParams (#28931)
* bump

* should be bytes

* draft fuzzy car params

* stash

* bump

* bump

* this is explored!

* some clean up

* more clean up

* clean up

* can't easily

* clean up

* no import

* Apply suggestions from code review

* move into a function

* Update selfdrive/car/tests/test_car_interfaces.py

* Update selfdrive/car/tests/test_car_interfaces.py

* Update selfdrive/car/tests/test_car_interfaces.py

* come onn

* we know it will return a dict here
2023-07-18 01:49:01 -07:00
Shane Smiskol
44f7b312a0 test car interfaces: more GM coverage (#28954)
* Update test_car_interfaces.py

* Update selfdrive/car/tests/test_car_interfaces.py

* make it fail

* catches crashed, not blocked
2023-07-18 01:42:51 -07:00
Shane Smiskol
35aaf90587 Nissan FPv2: use default diagnostic session (#28634)
* Revert "Nissan FPv2: log different diagnostic session types (#28585)"

This reverts commit 2f2b94758b.

* switch to standard KWP2000 diagnostic session type

* we're speedy again
2023-07-17 18:21:18 -07:00
Shane Smiskol
047bb46d3a Ford: fix CAN FD fingerprinting (#28995)
* fix CAN FD fingerprinting for now

* comment

* this is the simplest for now

* revert

* cmt

* todo and fixme!
2023-07-17 16:56:13 -07:00