Commit Graph

11 Commits

Author SHA1 Message Date
Jason Young
5d699a578c Clean up timers on receipt of a non-0x78 UDS error (#25398)
* clean up timers on receipt of a non-0x78 UDS error

* Update selfdrive/car/isotp_parallel_query.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-08-11 15:24:23 -07:00
Shane Smiskol
3a8f17111c Log VIN response address (#25148)
* log vin rx addr

* clean up
2022-07-13 01:10:56 -07:00
Adeeb Shihadeh
0fce5d9045 Move a bunch of stuff to system/ part 3 (#24829)
* move swaglog.py

* timezoned

* logmessaged

* version.py

* fix linter
2022-06-11 23:19:27 -07:00
Shane Smiskol
30e1f28213 IsoTpParallelQuery: handle response pending (#24724)
* handle response pending

* match commit

* remove total timeout, just keep track of individual response timeouts

* fix

* add back total timeout

* this isn't reliable enough

* keep track of pending responses to print warning

* tx_addr is (addr, subaddr)

* debug

only query hyundai

import time

reponse pending

no cache

all cars

no timeout to test before

* Revert "debug"

This reverts commit abe9cfc1b668034d7fa5ca5cbe9efe8834db3e7b.

* always print pending

always debug

* Only debug

* Update selfdrive/car/isotp_parallel_query.py

* remove variable only for debugging
2022-06-07 17:49:07 -07:00
Shane Smiskol
124f3f02d5 FPv2: log query request and response address (#24733)
* log fw query response offset

* one line still

* log request bytes as well

* bump cereal

* prettier order

* bump cereal

* I wonder if the radar sends a response pending...

debug

dont cache

fix

debug

* Revert "I wonder if the radar sends a response pending..."

This reverts commit 12a9552c27ac427c161c27f916fb4fd1a8e4b44c.

* log addr too

* bump cereal
2022-06-03 12:05:13 -07:00
Willem Melching
95957bc188 FW query: catch asserts from uds.py (#22456) 2021-10-07 10:34:59 +02:00
Willem Melching
2d7d8fba99 Improve Hyundai FW query stability (#22344)
* extend timeout on valid response

* extend total timeout in fw query

* redundant query

* cleanup

* add 2 new sonata fw

* add cloudlog

* total timeout always 10x

* update ref

* time.monotonic()

* more logging
2021-09-24 17:32:09 -07:00
Josh Smith
77321dbac4 Add type hints, small cleanups (#21080)
* improve tools.lib.kbhit and tools.sim.lib.keyboard_ctrl

* unpack more efficiently

* minor improvements

* agnos.py match spec better

* manual_ctrl test missing queue arg

* fix incorrect type annotation

* queues are generic

* varname reuse resulting in incorrect type inference

* bytes().hex() rather than bytes.hex(bytes())

* a bit of type hinting stuff
2021-06-03 12:21:04 +02:00
Jason Young
e7fc11c7fb VW MQB: UDS fingerprinting support (#20271)
* FPv2 support for MQB

* Comment touch-ups

* Trim extra newlines

* Add Atlas and Tiguan

* Update submodule ref

* Revert "Add Atlas and Tiguan"

This reverts commit a47bc1bca7a5b72df44578051379859eefa5fb39.

* Curb my enthusiasm

* Drop ABS/ESP from UDS fingerprinting for now

* Use multi-query to grab SW build ID and parameterization

* Resolve merge oops

* Resolve merge conflicts

* Make Ecu.fwdCamera optional for VW

* Where'd that come from?

* Propitiate process replay checks until ready for model dump

* FW values for Audi A3 Prestige

* Revert "Make Ecu.fwdCamera optional for VW"

This reverts commit 56852b99

* Don't try to FP fwdCamera for VW

* Remove FW comments

* Simplify RX offset handling

* Corrected scoping for MQB trans detection

* Add default response_offset

* Remove explicit list of MQB vehicles for now

* Deal with pylint warning

* Clarify and simplify comments

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-03-25 16:06:59 -07:00
Adeeb
367155168a Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
2020-06-03 16:13:34 -07:00
George Hotz
71ead9adea selfdrive/car 2020-01-17 10:58:43 -08:00