Commit Graph

47 Commits

Author SHA1 Message Date
Dean Lee
2d1078ee5b cabana: some improvements (#32161)
some improvements
2024-04-24 15:56:25 -07:00
Dean Lee
a6396be53e cabana: improve DBCFile::parse() (#32160)
improve parse()
2024-04-24 15:55:58 -07:00
Dean Lee
5e61775561 cabana: refactor HistoryLog for simplification and enhancements (#32284) 2024-04-23 09:53:50 -07:00
Cameron Clough
d09e77d1af cabana(DBCFile): handle escaped quotes (#31889)
* cabana(DBCFile): VAL_ allow empty description

Even though this doesn't make much sense, we should still be able to
parse it.

* cabana(DBCFile): allow escaped quotemarks in signal comment

* also message comments

* escape/unescape quotes

* test empty val desc

* test generating DBC with escaped quotes in comment

* seperate test case

* fix trailing space

* remove empty val

* trailing whitespace again
2024-04-03 19:19:55 -07:00
Justin Newberry
1c0161589b migrate lowercase mock (#32074)
* add mock migration

* fix

* this
2024-04-01 15:27:29 -07:00
Shane Smiskol
d6d8e45931 Simplify cabana dbc dict (#32041)
* so needlessly complex!

* inside generate_dbc_json

* this is good

* clean up!

* spaces

* so much clean up
2024-03-28 16:26:16 -07:00
Justin Newberry
1f424bf7dc cabana: migrate dbc map (#31920)
* fix cabana

* within platform map
2024-03-20 10:57:41 -07:00
thenhnn
489528dcae PlatformConfig: automatically get platform_str from the enum name (#31868)
* get platform_str from the enum name

* fix tests

* add migration table

* remove impossible todo

* Add link to PR in MIGRATION table

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Remove useless brand name comments and rename RAM_1500 to RAM_1500_5TH_GEN

* rename RAM_HD to RAM_HD_5TH_GEN

* rename references to RAM_HD and RAM_1500

* change "mock" to "MOCK" and rename torque data of Nissan Leaf 2018 IC

* remove MOCK from fingerprints.py

* change hard-coded car model in test_can_fingerprint.py/test_timing

* migration

* update ref

* space

* prius

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: justin newberry <justin@comma.ai>
Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
2024-03-19 11:16:02 -07:00
Cameron Clough
5a805df340 cabana(DBCFile): preserve original header (#31900)
* cabana(DBCFile): preserve original header

* add trailing space
2024-03-18 22:37:45 -07:00
Cameron Clough
3e816e7df8 cabana(DBCFile): interleave msg and signal comments (#31899)
This matches the behaviour of CANdb++
2024-03-17 11:17:29 -07:00
Justin Newberry
25ccb2426c cars: remove CAR_INFO map (#31739)
* no carinfo map

* smaller diff

* not on mock
2024-03-06 11:22:12 -08:00
Dean Lee
5f04517677 cabana: add csv export (#30800)
export csv
2023-12-19 11:50:16 -08:00
Dean Lee
aa744e8437 cabana: cleanp code (#30666) 2023-12-09 08:12:11 -08:00
Dean Lee
bf932c6277 cabana: remove dependence on opendbc (#30329)
* remove dependence on opendbc

* move into function
2023-11-02 22:37:56 -07:00
Dean Lee
01610128bb cabana: support suppress highlighted bits (#30336)
* support suppress highlighted bits

d

* faster filtering and sorting

* improve livestream

* specify the context in the connections

* remove inline
2023-10-30 09:47:23 -07:00
Dean Lee
29f10fd2aa cabana: fix parsing multiple line comment (#30178)
fix parse error
2023-10-05 01:48:56 -07:00
Dean Lee
c4df40a04a cabana: support ECU node names (#29897)
* support display&edit node name

* cleanup

* set validator for Node name

* modify validator to support multiple receivers

* set default to XXX in updateMsg

* add DEFAULT_NODE_NAME

* Update tools/cabana/commands.h

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-09-15 00:27:44 -07:00
Dean Lee
2d99521e75 cpplint: build/include_what_you_use (#29556)
* include_what_you_use

* remove comments

* include <memory>

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2023-08-23 13:25:17 -07:00
Adeeb Shihadeh
a9626f95b6 add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
2023-08-20 20:49:55 -07:00
Dean Lee
940609956d cabana: preserve msg transmitter & signal receiver when saving DBC (#28825)
preserve transmitter&receiver_name
2023-07-06 12:39:58 -07:00
Dean Lee
6cc600e84f cabana: fixed the issue of parsing multiplexed signals (#28660) 2023-06-23 13:14:11 -07:00
Dean Lee
3c398b2e2f cabana: simplifying endian conversion (#28601) 2023-06-20 10:56:40 -07:00
Dean Lee
e80440dc5d cabana: fixed the multi-threading issues of AbstractStream (#28590)
* fix multi-threading issues

* protect masks with mutex
2023-06-19 10:21:16 -07:00
Cameron Clough
e57f3ab4da cabana: round signal raw value for value description 2023-06-15 12:46:08 +01:00
Dean Lee
6f54ebe110 cabana: use raw signal value to match value descriptions (#28554) 2023-06-15 11:50:14 +01:00
Dean Lee
e08569b0f3 cabana: support multiplexed signals (#28309)
* support muxed signals

* write multiplexor in generateDBC

* edit multiplex_switch_value in signalView

* no overlapping warning for mux signals

* group signals by multiplexer indicator

* display freq for each multiplexed signals

* remove all multiplexed signals after switch deleted

* disable switch value

* cleanup

* historyView: use getValue

* sort by switch value

* check address

* rename variables

* rename signale type

* parse multiplexed signals in dbcmanater

* cache signal color in member variable

* cleanup num_decimals

* remove sources from dbcmanager and cleanup code

* fix sort

* check mltiplex in operator==

* fix sizehint

* convert multipledxed to normal after changing multiplxor to normal

* throw error on multiple 'M' signals

* add comment

* parse multipled signals in test case

* cleanup

* change order

* cleanup open

* display multiplexed/overlapping signals in binaryview

* sort overlapped signals by size

* refactor dbcmanager

* trimmed

* parse multiplexed signals in test case

* cleanup

* merge master

* space

* use pointer for sigs

* alldbcFiles

* cleanup

* cleanup sparkline

* use std::vector

* skip draw sparkline if isnull

* bigger capacity
2023-06-13 13:22:03 -07:00
Dean Lee
ff4aae85fe cabana: refactor dbc manager (#28445)
* rafactor signal

* cleanup

* refacto dbcmanager

* refactor dbcmanger
2023-06-08 13:41:55 -07:00
Angus Gratton
f659d4d44b cabana dbc: Sort signals by name if start bits are equal (#28399) 2023-06-04 14:04:09 -07:00
Dean Lee
4e738e64e4 cabana: add a test case for dbc parsing (#28383)
test case for dbc parsing
2023-06-02 22:34:37 -07:00
Dean Lee
99398176df cabana: Support parsing of multi-line comments (#28345) 2023-06-01 20:52:08 -07:00
Dean Lee
2a6458b44e cabana: improve dbc parsing (#28321) 2023-05-27 15:43:42 -07:00
Dean Lee
54506774f0 cabana: support editing comments for messages (#28299) 2023-05-25 13:38:58 -07:00
Dean Lee
d5d1ca11d4 cabana: support editing dbc files without a stream (#28294)
* no stream mode

* disable tools menu if no stream

* disable splitter

* cleanup

* refactor matchMessage
2023-05-25 10:51:28 -07:00
Dean Lee
36dd49e542 cabana: use double for minimum value & maximum value (#28252) 2023-05-21 12:35:45 -07:00
Dean Lee
ac2c87246a cabana: use the same double precision as the dbc file (#28234) 2023-05-19 12:36:11 -07:00
Dean Lee
5b54f0938f cabana: add #include <QObject> in dbcfile.h (#28219) 2023-05-17 00:08:10 -07:00
Dean Lee
720df4d150 cabana: cleanup DBCFile (#28160) 2023-05-10 13:57:55 -07:00
Dean Lee
f7e024f2f2 cabana: show and edit all messages present in DBC files (#28108)
* show all messages present in DBC files

* set last section stretch

* user can't resize data section

* re-fetch if filtering freq|count|data

* reserve set space

* use contains

* emit signalAdded for all related sources
2023-05-07 16:48:47 -07:00
Willem Melching
b53f748a1a cabana: add option to suppress already known signals (#28106)
* suppress using static mask

* use mask in updateLastMsgsTo

* store mask in cabana::Msg

* update mask in the right places

* actually build mask

* restore setting

* less diff
2023-05-04 10:50:28 -07:00
Dean Lee
45f1f764ea cabana: display current time & values in chart (#28042)
* display current time&value in chart

* cleanup

* use macro

* use BrightText

* use x-square

* tiplabel: set point size 9

* add 1 point offset

* change Light color

* lighter color

* use const iterator to avoid implict sharing detachs
2023-04-29 13:27:37 -07:00
Willem Melching
7f5cda00b5 cabana: more advanced DBC management features (#27968)
* cabana: improve menu to manage individual DBCs

* remove from single bus

* comments

* close explicitly

* new before open

* whitespace

* remove old code

* clipboard actions

* cleanup actions

* sections instead of nested menu

* consistent bus format
2023-04-19 10:49:30 -07:00
Willem Melching
1016c3f97c cabana: refactor new msg/signal name generation (#27931) 2023-04-17 15:37:41 -07:00
Willem Melching
d8e9c44c76 cabana: do not try to save empty wildcard DBC (#27898)
* cabana: do not try to save empty wildcard DBC

* use reference
2023-04-13 11:09:14 -07:00
Dean Lee
deeb7cff9f cabana: fix valgrind warnings related to uninitialized values (#27851)
fix valgrind warnings related to uninitialized values
2023-04-10 19:07:05 -07:00
Dean Lee
493d20994a cabana: do not emit DBCFileChanged if no file changes (#27800) 2023-04-04 10:47:54 -07:00
Willem Melching
e0afaa4eee cabana: fix merging sources for already open DBC file (#27715)
* fix build

* fix merging sources
2023-03-29 13:17:46 -07:00
Dean Lee
8903e03c88 cabana: move dbc related files to dbc/ (#27712)
* move dbc related files to dbc/

* move generate_dbc_json.py to dbc/
2023-03-28 11:52:28 -07:00