Commit Graph

235 Commits

Author SHA1 Message Date
Alexandre Nobuharu Sato
17ec4ad24e Honda: Brazilian HR-V 2023 fingerprint (#32243)
* fingerprint Honda HR-V 2023, brazilian market

* update routes

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-04-21 02:29:43 -07:00
Shane Smiskol
3d44edb348 Honda HR-V 3G: allow fingerprinting without the comma power (#32231)
* from 147613502316e718/00000001--ce406cf8a7

* honda hrv 3g obd-less

* rm

* good test

* add back
2024-04-16 21:52:14 -07:00
Shane Smiskol
a076c1e78f FwQueryConfig: test non-essential ecus aren't needless (#32232)
* good test

* remove :D

* typo
2024-04-16 21:49:30 -07:00
Shane Smiskol
5352d6c7ab Honda: remove combination meter (#32127)
remove combination meter
2024-04-08 14:18:36 -07:00
Shane Smiskol
90a59de144 [bot] Car docs: update model years from new users (#32060)
Update car docs
2024-03-30 10:16:40 -07:00
Shane Smiskol
ceaff0d963 Honda Civic 2022: allow fingerprinting without comma power (#31967)
* do civic 2022

* new lines
2024-03-21 20:00:15 -07:00
Shane Smiskol
d5cd457f82 Honda Civic 2022: fix spotty camera query (#31963)
* no extra ecu

* cmt

* documentation

* update refs

* nice

* for testing

* byebye

* Update launch_openpilot.sh
2024-03-21 18:49:18 -07:00
Shane Smiskol
2be012aa39 Honda: allow fingerprinting without comma power (#31926)
* pending

* acura ilx

* do odyssey

* clean up
2024-03-20 21:31:53 -07:00
Shane Smiskol
0a30af327d Honda Pilot: allow fingerprinting without comma power (#31945)
* pilot

* pilot

* clean up
2024-03-20 20:08:12 -07:00
Shane Smiskol
1a03da9df3 Honda Ridgeline and Insight: allow fingerprinting without comma power (#31938)
* Ridgeline and Insight

* ridgeline

* Insight
2024-03-20 16:19:18 -07:00
Shane Smiskol
a0b589eda9 Honda: allow fingerprinting without comma power for more platforms (#31935)
* 4 more platforms

* only the first is missing srs?!

* vsa didn't respond on these 8 routes

* acura is good!

* do CRV Hybrid

* CRV is already done

* new line

* Revert "new line"

This reverts commit 411c92c77b695d3df716f84b6f302fa0f791d555.
2024-03-20 15:35:19 -07:00
Shane Smiskol
1b930ae616 Honda E: allow fingerprinting without comma power (#31934)
HONDA_E
2024-03-19 22:47:08 -07:00
Shane Smiskol
6d8534758f Honda: allow fingerprinting without comma power for some platforms (#31933)
* pending

* notes

* these are ready!

* do odyssey

* Freed

* ACURA_RDX_3G

* HONDA_HRV

* new lines

* sort

* clean up

* comment new line

comment new line
2024-03-19 22:39:30 -07:00
Justin Newberry
b0eb3ba4f4 cars: platform enums -> prepend brand name (#31927)
* with brand name

* migrate

* Fix

* fixes

* more

* passes

* fix

* fix the doc

* collects

* these too

* more stuff

* body exception :/

* more

* hardcode i guess

* update ref

* toyota

* more toyota

* and here

* final!

* fix notebooks and ccs

* move this here
2024-03-19 17:29:50 -07:00
thenhnn
489528dcae PlatformConfig: automatically get platform_str from the enum name (#31868)
* get platform_str from the enum name

* fix tests

* add migration table

* remove impossible todo

* Add link to PR in MIGRATION table

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Remove useless brand name comments and rename RAM_1500 to RAM_1500_5TH_GEN

* rename RAM_HD to RAM_HD_5TH_GEN

* rename references to RAM_HD and RAM_1500

* change "mock" to "MOCK" and rename torque data of Nissan Leaf 2018 IC

* remove MOCK from fingerprints.py

* change hard-coded car model in test_can_fingerprint.py/test_timing

* migration

* update ref

* space

* prius

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: justin newberry <justin@comma.ai>
Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
2024-03-19 11:16:02 -07:00
Justin Newberry
655e5f7c3e rename CarInfo to CarDocs (#31879)
car info to car docs
2024-03-15 11:45:44 -07:00
Shane Smiskol
bdae188c6f docs: don't support multi-type car info (#31875)
don't support multi-type car info
2024-03-15 00:11:41 -07:00
Jason Wen
32c0bcec3a Honda: Parse distance button from steering wheel (#31763) 2024-03-11 21:49:07 -07:00
Shane Smiskol
99610c8819 Revert "common PlatformFlags base class + test for < 32 bits" (#31793)
Revert "common PlatformFlags base class + test for < 32 bits (#31779)"

This reverts commit 8ba5d660f3.
2024-03-08 00:15:21 -08:00
Justin Newberry
8ba5d660f3 common PlatformFlags base class + test for < 32 bits (#31779)
* add 32 bit check

* space

* this is not required

* jk yes we do
2024-03-07 14:01:28 -08:00
Justin Newberry
25ccb2426c cars: remove CAR_INFO map (#31739)
* no carinfo map

* smaller diff

* not on mock
2024-03-06 11:22:12 -08:00
Shane Smiskol
638aaa9e53 Platform configs: move tire stiffness into config (#31678)
* first one to open PR

* mazda

* oh it is

* fix gm car specs and create MazdaCarSpecs

* fix

* do honda

* ruff
2024-03-05 15:10:58 -08:00
Shane Smiskol
77d896eb89 Honda: two base platform configs (#31676)
* subclass bosch and nidec

* end with comma

* one line

* remove unused flags

* as a test see what happens if we exceeed CP.flags

* Revert "as a test see what happens if we exceeed CP.flags"

This reverts commit f57a346df5e6f3c6ab19875b843633c0571d16e3.

* Update ref_commit
2024-03-01 17:16:46 -08:00
Shane Smiskol
81bed0aad8 Honda Bosch: fix detection for alternate brake signal bug (#31675)
statically set alt brake for platforms where we don't need detection yet
2024-03-01 16:37:09 -08:00
Justin Newberry
b0eae8c1b7 platformconfig and carspecs are now required, carspecs no longer kwarg (#31667)
* required

* mock can be a platform!

* default is mock

* fix that

* and that one
2024-03-01 11:31:51 -08:00
Justin Newberry
a6a6f7bb50 Honda: move carspecs to platformconfig (#31657)
* first pass

* fix
2024-02-29 19:14:31 -08:00
Justin Newberry
5734d7c2bf Honda: move to platformconfig (#31637)
* first

* Fixes

* not

* not

* Fixes

* fix

* cleanup + use sets for now

* update ref

* update ref
2024-02-29 11:29:40 -08:00
Shane Smiskol
2c247ea2c6 Honda Civic (Nidec): allow fingerprinting without comma power (#31501)
* civic: FP with no OBD port

* non essential ecus
2024-02-27 22:12:00 -08:00
Shane Smiskol
ce6637cd8f Honda Accord: allow fingerprinting without comma power (#31477)
* Do Accord

* add comment

* good test

* this catches the accord/accordh issue!

* as expected, only if both radar&camera have in common FW does the test fail

* cmt

* clean up

* better

* Use HondaFlags

* detect alt brake

* for test

* hypothesis isn't installed

* test failure

* works

* Revert " works"

This reverts commit bfc0d808abe548630e6507431f13b01e8a1316cb.

* Revert "test failure"

This reverts commit 10ab6eb63ccd411740751b742f31fd610397fe8e.

* Revert "hypothesis isn't installed"

This reverts commit d474cc3f0ed7e84fe8bd24f452b3315fd2b8d47c.

* Revert "for test"

This reverts commit 98e039f4fc0189ccb57c1dae6b344209ef15eb1c.

* this is important too

* clean up

* merge accord fingerprints, test

* remove duplicates

* accordh doesn't have these

* rm

* no unknown

* start over, merge platforms

* add cmt

* note non-essential ecus

* add non essential obd ecus

* combine FW

* format fingerprints (remove dups)

* migrate test models segs

* cmt

* Update ref_commit

* clean up
2024-02-27 20:09:02 -08:00
Shane Smiskol
56e343b3f1 Honda Accord: label non-essential ECUs (#31624)
* note non-essential ecus

* do accordh
2024-02-27 17:41:52 -08:00
Cameron Clough
995250ae49 use pyupgrade to update to new typing syntax (#31580)
* add pyupgrade hook

* run pyupgrade (pre-commit run -a)

* ruff --fix

* Revert "add pyupgrade hook"

This reverts commit 56ec18bb6b8602a0b612f3803d96cdad14b52066.

* revert changes to third_party/

* manual type fixes

* explicit Optional wrapping capnp objects
2024-02-24 16:41:23 -08:00
Shane Smiskol
2e8c62358c Honda Bosch: detect alternate brake signal (#31500)
* Do Accord

* add comment

* good test

* this catches the accord/accordh issue!

* as expected, only if both radar&camera have in common FW does the test fail

* cmt

* clean up

* better

* Use HondaFlags

* detect alt brake

* for test

* hypothesis isn't installed

* test failure

* works

* Revert " works"

This reverts commit bfc0d808abe548630e6507431f13b01e8a1316cb.

* Revert "test failure"

This reverts commit 10ab6eb63ccd411740751b742f31fd610397fe8e.

* Revert "hypothesis isn't installed"

This reverts commit d474cc3f0ed7e84fe8bd24f452b3315fd2b8d47c.

* Revert "for test"

This reverts commit 98e039f4fc0189ccb57c1dae6b344209ef15eb1c.

* this is important too

* clean up

* more clean up

* Update ref_commit
2024-02-17 04:03:12 -08:00
Shane Smiskol
e02ec88b1c Honda Civic & CR-V Bosch: allow fingerprinting without comma power (#31259)
* Honda Civic Bosch: remove OBD-reliant ECUs from fingerprinting

* eligible to fingerprint with these responses now

* same for CRV bosch

* add back all FW to test fingerprinting diff on data

* set these ECUs as non essential instead

* comment

* compare old fingerprinting with non essential fingerprinting

* clean up

* cmt
2024-02-09 17:23:47 -08:00
Shane Smiskol
d61b8c90b6 [bot] Fingerprints: add missing FW versions from new users (#31372)
Export fingerprints
2024-02-08 10:43:06 -08:00
Shane Smiskol
36d6bb3bda Car docs: update model years from users for Toyota, Honda, Chrysler [bot] (#31203)
Update car docs
2024-01-28 19:23:53 -08:00
Shane Smiskol
52d7cfa689 Honda: add logging request for radarless Civic 2022+ camera (#31176)
* try tester present

* radar

* rm whitelist

* refs
2024-01-25 23:58:27 -08:00
Justin Newberry
28eed156e0 Move all fingerprints to fingerprints.py (#30790)
* move fingerpints

* fix circular imports

* fix circular imports

* fix auto fingerprint

* fix those tests

* and controlsd

* add labeler rule

* no defaultdict
2023-12-18 14:04:27 -08:00
Madnevil
82291a247f Honda: add FW for Civic Sport 2023 (#30316)
* Update values.py

* Update values.py

* Update values.py

* removing duplicate

* Update values.py

* Update values.py

* this is from a logging request

* Add missing FW

* bump MY

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-10-25 14:57:08 -07:00
Justin Newberry
6ae465e4af Use StrEnum for car classes (#30114)
* str enum

* import sort

* fix car helpers

* fix that

* fix static analysis
2023-09-30 17:15:34 -07:00
Shane Smiskol
16f0829404 Honda: add missing Ridgeline 2021 FW version (#29991)
add missing combo meter
2023-09-20 02:18:57 -07:00
Adeeb Shihadeh
a9626f95b6 add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
2023-08-20 20:49:55 -07:00
Justin Newberry
cf64b27168 Linter: Fix >160 line length test (#29287)
* test

* fix line length

* fix line length

* fix file size

* revert poetry

* cleanup for PR
2023-08-08 17:13:35 -07:00
Jason Young
deb4b11d11 Honda: Add FW for 2023 Honda Passport (#28343)
* Honda: Add FW for 2023 Honda Pilot/Passport

* push update
2023-06-02 16:41:48 -07:00
Shane Smiskol
024abe6455 car docs: document parts of parts (#28292)
* more stuff

* even more

* all parts func

* start to use it

* include self in parts

* use car_parts_new

* not used

* more usages

* remove get_parts

* remove more commented stuff

* remove iter

* clean up some more stuff

* more

more

* ford

* optional

optional

* nissan

* use new classes

* fix tests

* fix

* order

* no more required

* connector

* CARS.md

---------

Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
2023-05-31 21:30:50 -07:00
Maxime Desroches
9f5f8b603c car docs: list all needed hardware (#28212)
* generic car parts

* better carparts

* add part type

* more tests

* multiple enums

* unit tests

* just check isinstance

* better name

* remove _connector suffix

* remove those hyundai lines

* remove default arg

* Revert "remove default arg"

This reverts commit 139650a3b6b94358c3b9b12bb5fbe0a326d7abad.

* cleaner code structure

* use fingerprint

* review

* abstrac data class + common

* no more dataclass

* conflict

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-22 10:17:33 -07:00
Maxime Desroches
70677fe5fc add harness kit content to the doc (#28139)
* add harness kit content to the doc

* parts as enum

* nissan

* merge column

* rename column

* scaling

* scaling again

* 500px

* align text

* more px

* add style

* more width

* more

* more

* smaller text

* make all text smaller

* prev width

* default list

* remove hidden a ref

* try to remove again

* revert

* replace harness with harness_kit

* try fix

* cleaner

* center everything

* make pylint happy

* allow more than 1 of each parts

* use copy module

* review

* testing spacing

* revert

* bigger text

* formating

* split harness col lines

* remove print

* resolve

* rename to view

* keep formating in template

* simplify

* add unit test

* more generic way

* better

* harness connector only

* comment

* review

* put back harness parts

* missing dash

* too much space

* don't reload when clicking

* shorter comment

* only last line

* generate

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-15 15:33:54 -07:00
ecaslak
c293cb71c7 Add fingerprint for 2022 Honda Passport (#28175)
* Update CARS.md for 2022 Honda Passport

Changed latest supported model year from 21 to 22

* Update values.py: 2022 Honda Passport Fingerprint

Added ECU fingerprints for 2022 Honda Passport

* add missing fw

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-15 13:57:33 -07:00
Shane Smiskol
b9149795f1 Honda: Ridgeline 2023 is supported (#27979)
* Update values.py

* update docs
2023-04-19 20:40:30 -07:00
AlexandreSato
93c1810522 Honda: HR-V 2023 port (#27731)
* initial commit

* HR-V is diff enought to split from Civic22

* Add US HR-V 2023

* update CARS.md

* Update RELEASES.md

* Use a alternative brake signal

* US HR-V have a weird noise in the BrakeSwitch

* Shane tunning

* this is added automatically

* sorry jyoung

* civic22_stop_faster

limit stopAccel to current safety model

* relax calib temporarily (12 deg)

relax calib temporarily (10 deg)

* compute accel (car overshoots requests at low speed)

* revert brake pressed caused controls mismatches

* fix crash

* cause a cruise fault

* Revert "cause a cruise fault"

This reverts commit 09a6469ac6fc38ebd38dd1c5d464712a15d0fde1.

* no brake error

* use alt brake

* Update selfdrive/car/honda/carcontroller.py

* change HONDA_BOSCH_ALT_BRAKE_SIGNAL to CP.flags

* Revert "change HONDA_BOSCH_ALT_BRAKE_SIGNAL to CP.flags"

This reverts commit e0f8123b33db3218f27c4b64a7b2a0b1f740860f.

* remove FPv2 from brazilian HR-V

* bump panda

* fix a bug

* revert calib threshold

* new test route

* separate pr

* update

* update that

* thought i removed this

* revert steer ratio

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-04-14 03:12:10 -07:00
royjr
eb6112e94e Honda: add 2022 civic video link (#27821) 2023-04-07 11:20:32 -07:00