Commit Graph

74 Commits

Author SHA1 Message Date
Justin Newberry
1e1cc638d8 Car Docs: (optionally) Display a list of tools (#28782)
* display tools

* 5/16 also works

* cleanup

* static fix

* fix static analysis

* merge

* just use basepart

* use filter
2023-08-01 00:06:21 -07:00
Justin Newberry
38954418f0 Subaru: New LKAS Angle based cars in dashcam only (#29190)
* dashcam mode only

* fix name

* added those cars in dashcam mode only
2023-07-31 13:58:33 -07:00
Marcus Millspaugh
d7e8577301 Update Car/Subaru values.py to support 2022 Crosstrek (#29177)
* Update Car/Subaru values.py to support 2022 Crosstrek

Tested via SP, just want support via stock OP

* remove duplicates

---------

Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
2023-07-30 10:05:21 -07:00
JeanPierre Rousseau
b349a8c940 Subaru: add footnote to docs for international models (#26381)
* Update Cars.md

Updated Subaru required specs

* Update values.py

* update docs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-07-08 05:17:10 -07:00
Maxime Desroches
e85acfa365 car: use default_factory for mutable fields in dataclasses (#28669)
* call me

* copy
2023-06-27 16:48:43 -07:00
Justin Newberry
803c077dc1 Subaru: Signals Cleanup (#28602)
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2023-06-23 21:24:27 +01:00
Shane Smiskol
024abe6455 car docs: document parts of parts (#28292)
* more stuff

* even more

* all parts func

* start to use it

* include self in parts

* use car_parts_new

* not used

* more usages

* remove get_parts

* remove more commented stuff

* remove iter

* clean up some more stuff

* more

more

* ford

* optional

optional

* nissan

* use new classes

* fix tests

* fix

* order

* no more required

* connector

* CARS.md

---------

Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
2023-05-31 21:30:50 -07:00
Maxime Desroches
9f5f8b603c car docs: list all needed hardware (#28212)
* generic car parts

* better carparts

* add part type

* more tests

* multiple enums

* unit tests

* just check isinstance

* better name

* remove _connector suffix

* remove those hyundai lines

* remove default arg

* Revert "remove default arg"

This reverts commit 139650a3b6b94358c3b9b12bb5fbe0a326d7abad.

* cleaner code structure

* use fingerprint

* review

* abstrac data class + common

* no more dataclass

* conflict

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-22 10:17:33 -07:00
Kyle Greenlaw
7a684da47f Subaru: Add fw for 2020 Subaru Outback (#28240)
Route: a4e8e925930fce2c|2023-05-19--20-47-32
2023-05-19 22:49:46 -07:00
Maxime Desroches
70677fe5fc add harness kit content to the doc (#28139)
* add harness kit content to the doc

* parts as enum

* nissan

* merge column

* rename column

* scaling

* scaling again

* 500px

* align text

* more px

* add style

* more width

* more

* more

* smaller text

* make all text smaller

* prev width

* default list

* remove hidden a ref

* try to remove again

* revert

* replace harness with harness_kit

* try fix

* cleaner

* center everything

* make pylint happy

* allow more than 1 of each parts

* use copy module

* review

* testing spacing

* revert

* bigger text

* formating

* split harness col lines

* remove print

* resolve

* rename to view

* keep formating in template

* simplify

* add unit test

* more generic way

* better

* harness connector only

* comment

* review

* put back harness parts

* missing dash

* too much space

* don't reload when clicking

* shorter comment

* only last line

* generate

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-15 15:33:54 -07:00
martinl
2ad352d299 Subaru: FPv2: Add Crosstrek Limited 2023 missing FW values (#28014)
* Subaru: FPv2: Add Crosstrek Limited 2023

* trailing comma

* remove duplicate

* prefer hex

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2023-04-26 20:21:50 -07:00
goatstalker
a5d0d7b069 Add additional fingerprints for Subaru Outback 2022 model (#27995)
* Fingerprint Subaru outback 2022

Add fingerprint for carFw abs, engine, transmission, and fwdCamera.

* fingerprint two more values

* order values properly before submitting a PR

* remove hyundai fw responses

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2023-04-21 19:24:24 -07:00
Chase Bolt
f7e02c28d7 Add missing IMPREZA engine & fwdCamera f/w (#27985)
adding fingerprints for 2019 subaru impreza sport
2023-04-20 21:59:49 -07:00
Justin Newberry
d59bfa5519 Subaru: infotainment status intercept and rewrite (#27829)
* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* remove compiler flag stuff

* force error for testing

* bump panda and fix mistake

* wip

* bump panda

* wip

* wip

* forgot checksum and stuff

* add to signals

* rename

* test

* test

* bump panda and opendbc

* bump cereal

* add blank filler

* test

* add steer required to infotainment

* fix missing bit

* fix missing bit

* cleanup for PR

* cleanup for PR

* bump submodules

* wip

* wip

* i wonder what 1 is

* seemed to also be obstacle detected?

* bumppanda

* only if global

* only global gen 2

* fix order

* detect and send

* detect in rest of places

* update refs

* bumpopendbc

* copy whole message (camera sometimes sets these signals)

* bumppanda

* update refs!

* bumppanda

* let's not change this

* same as all the other functions

* Revert "same as all the other functions"

This reverts commit e86dbb695ef84a18f3123720fed37a6b81391cc4.

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-04-17 19:05:16 -07:00
martinl
cd3a72e8f3 Add FPv2: Subaru Forester 2020 (#27854)
* Add FPv2: Subaru Forester 2020

* missing FW

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-04-10 20:03:21 -07:00
seven121-ym
61e718fe5f Subaru: add FW for 2019 Subaru Impreza (#27771)
* Update values.py

* Update values.py

* Update values.py

* Update values.py

* Add missing engine

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-04-03 13:40:02 -07:00
martinl
0d1e272b91 Subaru: Add 2019 Forester FPv2 (#27500)
* Subaru: Add 2019 Forester FPv2

* Update selfdrive/car/subaru/values.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-03-16 14:32:22 -07:00
N0VA-DKW
cb0522379d Subaru: add Crosstrek 2022 FW versions (#27222)
* Update values.py

* Revert "Update values.py"

This reverts commit cd9f841c7a97ca800564605e68ea15d611abb3bc.

* do clean up later

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-02-09 14:16:07 -08:00
martinl
10085d1e3f Subaru: add missing fw values for 2023 Crosstrek Limited (#26678)
* Add FPv2: 2023 Crosstrek Limited / @JWynegar

* update docs

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-12-02 15:35:44 -08:00
martinl
62ad278829 Add FPv2: 2022 Subaru Outback Wilderness (#26540)
Add FPv2: 2022 Outback Wilderness / @valtou
2022-11-21 15:34:20 -08:00
brownspaceman
ea813a9a7d Subaru: add missing engine FW for 2019 Impreza (#26385)
added fw for 2019 subaru impreza
2022-11-07 16:48:54 -08:00
Shane Smiskol
685533a3a1 Subaru: Add missing FW for 2021 Legacy (#25914)
Add missing 2021 Legacy FW from 9936b4bbf75a5fe4|2022-09-26--20-29-47
2022-09-28 14:06:34 -07:00
Brandon Bennett
56b05d55eb Subaru: Add missing 2020 Ascent f/w (#25725)
* add missing ascent fw version

Ascent had recall service for transmission ecu. New values added.

* Update selfdrive/car/subaru/values.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-09-12 22:24:11 -07:00
Shane Smiskol
0ef6bb48df FPv2: move car-specific configuration into interfaces (#25711)
* Add VMCU address for EV6

* Rename vmcu

* add to tests

add to tests

* rename to more generic name

* more explicit

* remove print

* Like this much better, removes subtle fingerprinting problems

* clean up

* add test and clean up

* remove hyundai stuffs

* global

* Fpv2Config class

* fix missing fw versions from import order

* unused

* revert for now

* test for fpv2 configs with subtests

* subtests don't work that way

* do toyota as an example

* revert

revert

* do chrysler

* do rest

* stash

* much smaller of a diff than the alternative

* remove unused test

* fix tests

* remove brand from Request

* Make StandardQueries class

* add missing_ecus

clean up

* rename file

* unused

* test implemented

* add comment and rename

add comment and rename

add comment and rename

* should be impossible now

* this is a fixme

* rename to fw_query

* rename this too

* and this

* move vin queries to class

* order

* can use p16!

* formatting

* whoops, this wasn't gated on not len(found_versions)

* make this clear

* Standardize manufacturer software version query
2022-09-09 16:24:29 -07:00
Cameron Clough
e9c87daef6 rename esp ECU to abs (#25640)
* rename esp ecu to abs

* bump cereal
2022-09-07 14:25:57 -07:00
Justin Newberry
98484697cb Subaru Legacy 22 fingerprint (#25665) 2022-09-05 13:24:17 -07:00
Adeeb Shihadeh
a21780dbea Subaru: Legacy 2020-22 support (#25313)
* Subaru: Legacy 2020 support

* clean that up

* force for now

* update years

* test route
2022-08-18 09:02:33 -07:00
Shane Smiskol
5f5d944368 Subaru: add missing Impreza 2017 FW versions (#25424)
* this is from hyundai query

* These are also from Hyundai

* Add missing FW versions from 5c3a4dc9bd0b2eaa|2022-08-12--18-01-46

* more FW
2022-08-12 19:53:44 -07:00
Adeeb Shihadeh
96e8d5c9fe Subaru: new harness is on the shop (#25406)
* Subaru: new harness is on the shop

* subaru a
2022-08-11 17:23:51 -07:00
martinl
09800b623e Subaru: Add missing Forester 2021 engine fw (#25322)
FPv2: Add Forester 2021 engine fw
2022-08-01 14:32:42 -07:00
Shane Smiskol
c8a90ef586 Prepare for new supported vehicles webpage (#25021)
* add well maintained footnote

* stash

* some updates for the website

* one extensible sort function, pass sort function into template, continue to use "openpilot ACC"

* use items

same

* return a final dict

* Fix descriptions

* Required

* Add detail sentence

* Make string packages into namedtuple

* add temp year parsing

* revert this

* one unified class like harness

* fix static analysis

* Fix body

Fix body

* Make specifics strong

* remove years

* Make Camry footnote more clear

* Revert this too

* Add notCar text, fix steer speed > enable speed (remove comma, no speed mention)

* fix missing years

* group_by_make

* Use full package text

* Only use full package text

* Check car name if notCar, fix imports

* add_years no longer needed, remove 'with Stop and Go'

* fix that

fix that

fix that

* Exception for Nissan and Subaru

* Adjust DSU footnote text

* Fix speed overrides in sentence, CR-V package imp

* init() was being called multiple times, only need to run once to set row
2022-08-01 13:26:24 -07:00
Adeeb Shihadeh
e076b2bd34 outback harness isn't on the site yet 2022-07-31 12:47:17 -07:00
Adeeb Shihadeh
efa326e208 Subaru: 2020 Outback support (#25248)
* Subaru: 2020 Outback support

* bump panda

* bump panda

* update refs

* update refs
2022-07-31 12:43:27 -07:00
chengyu-k
063cd137ef Impreza 2017: add missing eps FW (#24892)
* Update carFw for Impreza 2017

* Update selfdrive/car/subaru/values.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-07-21 14:05:02 -07:00
Shane Smiskol
af1c8e5412 Subaru Forester: 2022 requires new harness (#25229)
* Revert to 2021

* update docs
2022-07-20 21:15:33 -07:00
Adeeb Shihadeh
ecac734160 update compatibility docs with VIN data (#25134)
* start with genesis

* chrysler

* honda

* toyota

* subaru
2022-07-12 13:51:25 -07:00
martinl
eaa8b08510 Subaru: XV is supported (#25034)
* Subaru: add XV to supported models

* Update docs
2022-07-05 16:42:53 -07:00
Shane Smiskol
e11bb76a64 car docs: remove steering torque hard-coding (#25019)
remove good torque hardcoding
2022-07-01 19:11:28 -07:00
Shane Smiskol
789f2d195c compatibility docs: fixup steering torque star (#24940)
* Ascent has good torque, hard code Toyota, print all unexpected torque star cars

* update docs

* Use subtests

* hardcode CHR for now

generate

* Hard code Impreza

* update refs
2022-06-22 01:03:29 -07:00
George Hotz
8c101c61a8 EyeSight standard on all 2019+ Ascent and Forester (#24799)
* on all 2019+ Ascent Forester

* update docs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-06-09 15:11:32 -07:00
Shane Smiskol
c6bc03311c Car documentation: set steering torque star using car interface (#24709)
* Set good torque using torque controller tuning

* should be equal to

* save lateral accel to car params

* use maxLateralAccel

* always

* same convention

* nan will always evaluate to false

* The great good torque purge

* adjust default friction

* Add data for more cars

* adjust name

* Welcome back, guys. Only adjust good torque if maxLatAccel is set

* Update refs (1.7 is 1.7000001...)
2022-06-03 17:41:20 -07:00
Shane Smiskol
433fcc0c71 CarInfo: Add harness information (#24085)
* Add harness information

* test harness enum

* add harness info for tucson

* update Tucson harness

* get rid of development

* make global enum

* fix

* add harness info

* add harness info to CARS.md (since we need multiple lines per HKG platform)

* revert this

* Actively Maintained means something! (aka, to bronze with select VW)

* fix caravelle

* add harness tooltip on maintained column

fix

* lol tubaru

* always assume harness

* update honda harnesses

* add Ioniq hybrid 2017-19 harness, todo: not sure

* unused import

* hmm, did they really switch to the C for 1 year??

* add comment

* add comments

* adding tooltips should be fine

* fix santa fe harness

* welcome back, vw

* no need for two harness strings

* seems fine

* fix 19-20 Niro EV harness

* these were taking from old database, so assume correct

* could be d

* pass all car info into template

* no more tool tips

* these use j533 harnesses

* accidentally got removed in merge

* also merge issue

* don't need these

* make harness non-optional
2022-05-11 18:02:21 -07:00
Shane Smiskol
24b5164ce6 Subaru: Add fwdCamera FW for 2018 Crosstrek (#24377) 2022-04-29 18:23:47 -07:00
martinl
df13b26971 Subaru: Add missing FW versions for Forester 2019 and Impreza 2020 (#24225)
* Add FPv2: Subaru Crosstrek 2020 Sport (Canada), a2af7643da1d4017|2022-04-14--12-00-31

* Add FPv2: 2021 Subaru Forester Sport, c2f528d49fe19d53|2022-04-13--20-11-17

* Add FPv2: 2020 Subaru Crosstrek Limited, 0f33f7a9d1949fa6|2022-04-13--14-44-02

* Update FPv2: 2019 Subaru Forester Sport, f6e178e18ba27ca1|2022-04-08--18-22-50

* Update FPv2: 2021 Subaru Forester Touring, 6fcb17b9ef924548|2022-04-14--05-37-28

* Add FPv2: 2019 Subaru Forester Limited, a447729c1d15ff89|2022-04-13--17-54-27

* Add fw for a2af7643da1d4017|2022-04-14--18-21-57 for IMPREZA SPORT 2020

* Add fw for a447729c1d15ff89|2021-12-27--15-35-46 for FORESTER 2019

* Add fw from c2f528d49fe19d53|2022-02-19--13-44-43 for FORESTER 2019

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-04-26 20:34:41 -07:00
martinl
599b1ab3ff Subaru: remove A/C fw version (#24224)
* Subaru: remove A/C fw version

* add test to ensure the ecu isn't added again

* check CP.carName

* clean up

one line

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-04-25 16:41:34 -07:00
David Peterson
ce74bd4143 docs: add video link for 2019 Subaru Crosstrek (#24251)
* Update values.py

Add video_link :     SubaruCarInfo("Subaru Crosstrek 2018-19", good_torque=True),video_link="https://youtu.be/Agww7oE1k-s"),

* fix syntax

* timestamp to start of openpilot use

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-04-19 13:25:56 -07:00
Adeeb Shihadeh
c810198815 Subaru: remove rest of CAN fingerprints (#24195) 2022-04-13 11:48:14 -07:00
Shane Smiskol
3ff14adbd6 Subaru: add missing Impreza fw versions (#24194)
* add missing impreza fw versions

* these are duplicate

* this fw version flipped on the 5th for michael and never switched back
2022-04-12 17:15:27 -07:00
martinl
5e1095e881 Subaru: update supported model years and steering torque (#24118)
* Subaru: update carinfo supported model years and good steering torque

* update torque

* model year 2020 was added to IMPREZA_2020, split out

update docs

* order

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-04-05 13:04:46 -07:00
Shane Smiskol
31a6b141d6 Docs: auto-generate supported cars documentation (#23762)
* make CAR class enum, and values.py formatting

* Revert "make CAR class enum, and values.py formatting"

This reverts commit 04d9817e9d5d6ab5c027754018fc445f2cd3067a.

* stash

* add supported packages and model years

* don't change model years in fps

* move Lexus to info dict and make int enum

* remove sometimes wrong model years from name string

* use enum names

* convert Honda's values

* nice names

* use name

* GM

* Mazda, Ford

* Hyundai: WIP

* finish Hyundai

* fix

* Nissan

* Subaru

* Tesla

* formatting is for another PR

* Chrysler: todo: unify the Pacificas?

* do volkswagen

* this isn't a zoo

* skip enums for now

* Update selfdrive/car/volkswagen/values.py

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>

* set All

* temp cars

* auto-generate CARS.md

* update type hinting

* add generated file

* add longitudinal star to cars that support disabling radar

* add TODO

* add notes

* add min_steer_speed exception for hatchback

* add minimum steering speeds

* Add exceptions and run generator

* Missing Telluride

* fix Prius v

* missing Prius Prime

generate

* start to convert years to strings

* Fixup Hyundai

* convert year sets to strings

* handle this

* missing S3

* Fix and add all missing cars (verified with script

* Supported Package fixes

* add get_tiered_cars

* Check radarOffCan for removing most Honda from op long

* Update for Avalon stop and go update on master

* Fix missing car params

* add my temporary script i'm using to verify new generated DBC

add my temporary script i'm using to verify new generated DBC

* generate with jinja template

* add header and footer

* clean up

* rename

rename

* add exceptions. jinja is nice, but why are its loop indexes starting at 1?

* add list of known car videos

* See how these look

* Add nice table formatting for column description

Add nice table formatting for column description

* generate

* consisten br tag

* small clean up

* temp

* Move car videos into CarInfo

* add new copy and rename to footnotes

* Revert "temp"

This reverts commit 93c3fce1d3ab406f80cbfb9c00c2237d109c7846.

clean up

* generate

* replace with svg

* simplify a bit

* add footnotes to CarInfo

* move some variables to docs.py

* Add video link for Acadia

* Make Footnote an enum so we don't use random ints

* static analysis fixes

* move to CARS.md

* fix last missing footnote

* add to release files

* rm test file

* use svg

generate

* fix sorting

* not needed

* not sure how this got here

* remove Sedan/Couple and add Diesel footnote

* finish todos

* move make specific footnotes to selfdrive/car/*/values.py

rename

* change to zeros

* align bottom to center

* Apply some suggestions

* Update selfdrive/car/mock/values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update copy

* Try headers + bullet points

* somehow better

somehow better

* finish updating copy

* move template and add links to sups

* stars shouldn't be clickable

that didn't work

try this

try this

this is better

* add type hints to CarInfo

add more type hinting

* optional needs a type and any covers all (?)

* move good steering torque to */values.py

* dataclasses are much nicer than attr

* use tuple

* Update docs/cars.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* suggestions

* suggestions

* suggestions

remove

* clean up a bit

* add more type hints

* center stars and remove hardcoding from template

* update copy

* Add test

* Fix types

Fix types

* add supported cars documentation test

* clean up

* replace with docs_definitions

* Add back Footnote enums

* Ah so these are like fstrings!

* Update selfdrive/car/CARS_template.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update year from master merge

* Fix longitudinal star from merge

* sort properly stars by Column enum

* clean up

* HKG: Sorry guys

* Prius V gets FSR star, like others

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update comment

* No Prius docs change for now

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-16 21:27:05 -07:00