Commit Graph

162 Commits

Author SHA1 Message Date
Justin Newberry
1e1cc638d8 Car Docs: (optionally) Display a list of tools (#28782)
* display tools

* 5/16 also works

* cleanup

* static fix

* fix static analysis

* merge

* just use basepart

* use filter
2023-08-01 00:06:21 -07:00
Justin Newberry
38954418f0 Subaru: New LKAS Angle based cars in dashcam only (#29190)
* dashcam mode only

* fix name

* added those cars in dashcam mode only
2023-07-31 13:58:33 -07:00
Marcus Millspaugh
d7e8577301 Update Car/Subaru values.py to support 2022 Crosstrek (#29177)
* Update Car/Subaru values.py to support 2022 Crosstrek

Tested via SP, just want support via stock OP

* remove duplicates

---------

Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
2023-07-30 10:05:21 -07:00
JeanPierre Rousseau
b349a8c940 Subaru: add footnote to docs for international models (#26381)
* Update Cars.md

Updated Subaru required specs

* Update values.py

* update docs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-07-08 05:17:10 -07:00
Maxime Desroches
e85acfa365 car: use default_factory for mutable fields in dataclasses (#28669)
* call me

* copy
2023-06-27 16:48:43 -07:00
Justin Newberry
803c077dc1 Subaru: Signals Cleanup (#28602)
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2023-06-23 21:24:27 +01:00
martinl
5cb9360fa0 Subaru: log stock AEB (#28052)
* Subaru: log stock AEB

* Remove stockFcw from stockAeb

* Subaru: Add FCW_Cont_Beep to stockFcw signals

* add ES_Brake

* use actuation bit

* bump opendbc

* remove aeb from UI

fix

* Update selfdrive/car/subaru/carstate.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-06-16 22:48:09 -07:00
Shane Smiskol
bce19bf187 Subaru: use latActive for steer request bit (#28453)
* subaru: use latactive

* Update ref_commit
2023-06-12 23:03:04 -07:00
Shane Smiskol
024abe6455 car docs: document parts of parts (#28292)
* more stuff

* even more

* all parts func

* start to use it

* include self in parts

* use car_parts_new

* not used

* more usages

* remove get_parts

* remove more commented stuff

* remove iter

* clean up some more stuff

* more

more

* ford

* optional

optional

* nissan

* use new classes

* fix tests

* fix

* order

* no more required

* connector

* CARS.md

---------

Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
2023-05-31 21:30:50 -07:00
Shane Smiskol
439a30aae4 cars: explicitly add counter/checksum messages (#28341)
* hkg canfd: add counter/checksum

* add explicitly to subaru

* same for ES_LKAS_State

* and ES_DashStatus

* aaand INFOTAINMENT_STATUS

* and preglobal ES_Distance

* Revert "and preglobal ES_Distance"

This reverts commit 68d98307703a24296ff7aafd99503ea6af4b231b.
2023-05-30 15:33:02 -07:00
Shane Smiskol
54e6d4c402 Subaru: explicitly copy signals to forward (#28304)
* do subaru

* add missing checksum

* more missing checksums
2023-05-25 22:59:52 -07:00
Justin Newberry
c1909df437 Subaru: frequency based messaging (#28066)
* frequency based messaging

* frequency based messaging

* frequency based messaging

* frequency based messaging

* rename better

* use frame in if statement

* syntax

* remove extra space

* put all behind one if statement

* update refs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-25 22:33:04 -07:00
Maxime Desroches
9f5f8b603c car docs: list all needed hardware (#28212)
* generic car parts

* better carparts

* add part type

* more tests

* multiple enums

* unit tests

* just check isinstance

* better name

* remove _connector suffix

* remove those hyundai lines

* remove default arg

* Revert "remove default arg"

This reverts commit 139650a3b6b94358c3b9b12bb5fbe0a326d7abad.

* cleaner code structure

* use fingerprint

* review

* abstrac data class + common

* no more dataclass

* conflict

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-22 10:17:33 -07:00
Kyle Greenlaw
7a684da47f Subaru: Add fw for 2020 Subaru Outback (#28240)
Route: a4e8e925930fce2c|2023-05-19--20-47-32
2023-05-19 22:49:46 -07:00
Justin Newberry
f327053ac0 Subaru: rename legacy to preglobal (#28204)
* rename

* submodules too

* missed some variables

* fix find/replace error

* revert modules

* bump submodules

* bump cereal
2023-05-15 19:12:47 -07:00
Maxime Desroches
70677fe5fc add harness kit content to the doc (#28139)
* add harness kit content to the doc

* parts as enum

* nissan

* merge column

* rename column

* scaling

* scaling again

* 500px

* align text

* more px

* add style

* more width

* more

* more

* smaller text

* make all text smaller

* prev width

* default list

* remove hidden a ref

* try to remove again

* revert

* replace harness with harness_kit

* try fix

* cleaner

* center everything

* make pylint happy

* allow more than 1 of each parts

* use copy module

* review

* testing spacing

* revert

* bigger text

* formating

* split harness col lines

* remove print

* resolve

* rename to view

* keep formating in template

* simplify

* add unit test

* more generic way

* better

* harness connector only

* comment

* review

* put back harness parts

* missing dash

* too much space

* don't reload when clicking

* shorter comment

* only last line

* generate

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-15 15:33:54 -07:00
martinl
2ad352d299 Subaru: FPv2: Add Crosstrek Limited 2023 missing FW values (#28014)
* Subaru: FPv2: Add Crosstrek Limited 2023

* trailing comma

* remove duplicate

* prefer hex

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2023-04-26 20:21:50 -07:00
Shane Smiskol
9689e9c567 cars: various small cleanups (#28031)
* finally fix subarucan formatting

* no need for intermediate variables

* make this check explicit
2023-04-26 01:43:07 -07:00
Shane Smiskol
045db2f235 Subaru: fix forwarded signal name (#28030)
actually Cruise_Status_Msg
2023-04-26 00:19:01 -07:00
goatstalker
a5d0d7b069 Add additional fingerprints for Subaru Outback 2022 model (#27995)
* Fingerprint Subaru outback 2022

Add fingerprint for carFw abs, engine, transmission, and fwdCamera.

* fingerprint two more values

* order values properly before submitting a PR

* remove hyundai fw responses

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2023-04-21 19:24:24 -07:00
Chase Bolt
f7e02c28d7 Add missing IMPREZA engine & fwdCamera f/w (#27985)
adding fingerprints for 2019 subaru impreza sport
2023-04-20 21:59:49 -07:00
Shane Smiskol
5aebdb0ad0 Car docs: pass docs flag to car interfaces (#27311)
* docs

* docs

* docs

* docs

* use docs in gm
2023-04-18 12:22:22 -07:00
martinl
13c75dc138 Subaru: signals cleanup (#27946)
* Update counter in carstate checks

* Rename es_lkas to es_lkas_state to match signal

* formatting

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-04-17 22:54:27 -07:00
Shane Smiskol
8f1e67f625 Subaru: always show LKAS active (#27945)
subaru always shows lines if LKAS is enabled (not active), more clear what we're sending
2023-04-17 22:31:59 -07:00
Justin Newberry
d59bfa5519 Subaru: infotainment status intercept and rewrite (#27829)
* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* remove compiler flag stuff

* force error for testing

* bump panda and fix mistake

* wip

* bump panda

* wip

* wip

* forgot checksum and stuff

* add to signals

* rename

* test

* test

* bump panda and opendbc

* bump cereal

* add blank filler

* test

* add steer required to infotainment

* fix missing bit

* fix missing bit

* cleanup for PR

* cleanup for PR

* bump submodules

* wip

* wip

* i wonder what 1 is

* seemed to also be obstacle detected?

* bumppanda

* only if global

* only global gen 2

* fix order

* detect and send

* detect in rest of places

* update refs

* bumpopendbc

* copy whole message (camera sometimes sets these signals)

* bumppanda

* update refs!

* bumppanda

* let's not change this

* same as all the other functions

* Revert "same as all the other functions"

This reverts commit e86dbb695ef84a18f3123720fed37a6b81391cc4.

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-04-17 19:05:16 -07:00
martinl
cd3a72e8f3 Add FPv2: Subaru Forester 2020 (#27854)
* Add FPv2: Subaru Forester 2020

* missing FW

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-04-10 20:03:21 -07:00
seven121-ym
61e718fe5f Subaru: add FW for 2019 Subaru Impreza (#27771)
* Update values.py

* Update values.py

* Update values.py

* Update values.py

* Add missing engine

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-04-03 13:40:02 -07:00
martinl
0d1e272b91 Subaru: Add 2019 Forester FPv2 (#27500)
* Subaru: Add 2019 Forester FPv2

* Update selfdrive/car/subaru/values.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-03-16 14:32:22 -07:00
Shane Smiskol
581fd62d26 steer limits: rename common dist to meas function (#27453)
* rename function

* make a wrapper function (ford uses dynamic up/down limits

* make two functions consistent

* make torque function convert to int
2023-02-26 17:32:52 -08:00
Shane Smiskol
8f5057ff2d GM: enforce steering command message timing (#27250)
* draft

* bump opendbc

* still draft

* that's not right

* superset of the changes, 33hz

* cleanup

* this should work

* remove line

* pass it in again

* actually no need to check updated now

* now_nanos

* consistent name

* fix replay

* one line isn't that bad

switch

switch

* fix CarController tests

* Update ref_commit
2023-02-09 15:37:39 -08:00
N0VA-DKW
cb0522379d Subaru: add Crosstrek 2022 FW versions (#27222)
* Update values.py

* Revert "Update values.py"

This reverts commit cd9f841c7a97ca800564605e68ea15d611abb3bc.

* do clean up later

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-02-09 14:16:07 -08:00
Adeeb Shihadeh
6fa9b555a4 rename carState.radarOffCan to radarUnavailable (#27187)
* rename carState.radarOffCan to radarUnavailable

* bump cereal
2023-02-02 11:38:09 -08:00
Shane Smiskol
f36a3664b0 CarController: log steer sent to the car (#26743)
* log value sent to the car

* rename

* bump

* Update ref_commit
2022-12-10 02:03:40 -08:00
martinl
10085d1e3f Subaru: add missing fw values for 2023 Crosstrek Limited (#26678)
* Add FPv2: 2023 Crosstrek Limited / @JWynegar

* update docs

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-12-02 15:35:44 -08:00
Shane Smiskol
712b9014d7 Car interface: set tire stiffness in common function (#26625)
* common stiffness

* GM uses factors
2022-11-29 12:50:27 -08:00
Shane Smiskol
860f441e2f Car interface: set common params after port (#26613)
* remove pylint exception, _get_params takes no defaults

* clean up

* mock uses it too

* unused

* unused

* fix that

* bump

* Update selfdrive/car/interfaces.py
2022-11-29 11:49:13 -08:00
martinl
62ad278829 Add FPv2: 2022 Subaru Outback Wilderness (#26540)
Add FPv2: 2022 Outback Wilderness / @valtou
2022-11-21 15:34:20 -08:00
brownspaceman
ea813a9a7d Subaru: add missing engine FW for 2019 Impreza (#26385)
added fw for 2019 subaru impreza
2022-11-07 16:48:54 -08:00
Shane Smiskol
f31aa68533 Subaru: log stock FCW (#26012)
* log stock FCW

* Update selfdrive/car/subaru/carstate.py

* never seen 1 (could be aeb?)
2022-10-08 23:28:33 -07:00
Shane Smiskol
685533a3a1 Subaru: Add missing FW for 2021 Legacy (#25914)
Add missing 2021 Legacy FW from 9936b4bbf75a5fe4|2022-09-26--20-29-47
2022-09-28 14:06:34 -07:00
Shane Smiskol
86062fee6b Subaru: match panda standstill (#25789)
* subaru: match panda standstill

* subaru: match panda standstill

* actually test standstill

* bump panda to master
2022-09-14 19:11:49 -07:00
Brandon Bennett
56b05d55eb Subaru: Add missing 2020 Ascent f/w (#25725)
* add missing ascent fw version

Ascent had recall service for transmission ecu. New values added.

* Update selfdrive/car/subaru/values.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-09-12 22:24:11 -07:00
Shane Smiskol
0ef6bb48df FPv2: move car-specific configuration into interfaces (#25711)
* Add VMCU address for EV6

* Rename vmcu

* add to tests

add to tests

* rename to more generic name

* more explicit

* remove print

* Like this much better, removes subtle fingerprinting problems

* clean up

* add test and clean up

* remove hyundai stuffs

* global

* Fpv2Config class

* fix missing fw versions from import order

* unused

* revert for now

* test for fpv2 configs with subtests

* subtests don't work that way

* do toyota as an example

* revert

revert

* do chrysler

* do rest

* stash

* much smaller of a diff than the alternative

* remove unused test

* fix tests

* remove brand from Request

* Make StandardQueries class

* add missing_ecus

clean up

* rename file

* unused

* test implemented

* add comment and rename

add comment and rename

add comment and rename

* should be impossible now

* this is a fixme

* rename to fw_query

* rename this too

* and this

* move vin queries to class

* order

* can use p16!

* formatting

* whoops, this wasn't gated on not len(found_versions)

* make this clear

* Standardize manufacturer software version query
2022-09-09 16:24:29 -07:00
Adeeb Shihadeh
655a64b603 single longitudinal toggle for e2e and disable radar (#25688)
* single longitudinal toggle for e2e and disable radar

* write disable radar param

* rename

* better param name

* clean that up

* update refs

* update translations

* not live for experimental

* write it out

* vanish
2022-09-07 17:12:49 -07:00
Cameron Clough
e9c87daef6 rename esp ECU to abs (#25640)
* rename esp ecu to abs

* bump cereal
2022-09-07 14:25:57 -07:00
Justin Newberry
98484697cb Subaru Legacy 22 fingerprint (#25665) 2022-09-05 13:24:17 -07:00
Shane Smiskol
452d5e42ec Car docs: add auto-resume column (#25572)
* Move auto resume in sng to car interface

* Update docs

* shorter name, star

* order

* resumes?

* add hidden detail sentence

* good to know this works, but revert

* VW auto resume

* bump cereal to master

* Update ref_commit

* match cereal

* try this

* ?

?

* like this
2022-08-30 17:54:40 -07:00
Adeeb Shihadeh
a21780dbea Subaru: Legacy 2020-22 support (#25313)
* Subaru: Legacy 2020 support

* clean that up

* force for now

* update years

* test route
2022-08-18 09:02:33 -07:00
Shane Smiskol
5f5d944368 Subaru: add missing Impreza 2017 FW versions (#25424)
* this is from hyundai query

* These are also from Hyundai

* Add missing FW versions from 5c3a4dc9bd0b2eaa|2022-08-12--18-01-46

* more FW
2022-08-12 19:53:44 -07:00
Adeeb Shihadeh
96e8d5c9fe Subaru: new harness is on the shop (#25406)
* Subaru: new harness is on the shop

* subaru a
2022-08-11 17:23:51 -07:00