Commit Graph

193 Commits

Author SHA1 Message Date
Jason Young
deb4b11d11 Honda: Add FW for 2023 Honda Passport (#28343)
* Honda: Add FW for 2023 Honda Pilot/Passport

* push update
2023-06-02 16:41:48 -07:00
Shane Smiskol
024abe6455 car docs: document parts of parts (#28292)
* more stuff

* even more

* all parts func

* start to use it

* include self in parts

* use car_parts_new

* not used

* more usages

* remove get_parts

* remove more commented stuff

* remove iter

* clean up some more stuff

* more

more

* ford

* optional

optional

* nissan

* use new classes

* fix tests

* fix

* order

* no more required

* connector

* CARS.md

---------

Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
2023-05-31 21:30:50 -07:00
Maxime Desroches
9f5f8b603c car docs: list all needed hardware (#28212)
* generic car parts

* better carparts

* add part type

* more tests

* multiple enums

* unit tests

* just check isinstance

* better name

* remove _connector suffix

* remove those hyundai lines

* remove default arg

* Revert "remove default arg"

This reverts commit 139650a3b6b94358c3b9b12bb5fbe0a326d7abad.

* cleaner code structure

* use fingerprint

* review

* abstrac data class + common

* no more dataclass

* conflict

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-22 10:17:33 -07:00
Maxime Desroches
70677fe5fc add harness kit content to the doc (#28139)
* add harness kit content to the doc

* parts as enum

* nissan

* merge column

* rename column

* scaling

* scaling again

* 500px

* align text

* more px

* add style

* more width

* more

* more

* smaller text

* make all text smaller

* prev width

* default list

* remove hidden a ref

* try to remove again

* revert

* replace harness with harness_kit

* try fix

* cleaner

* center everything

* make pylint happy

* allow more than 1 of each parts

* use copy module

* review

* testing spacing

* revert

* bigger text

* formating

* split harness col lines

* remove print

* resolve

* rename to view

* keep formating in template

* simplify

* add unit test

* more generic way

* better

* harness connector only

* comment

* review

* put back harness parts

* missing dash

* too much space

* don't reload when clicking

* shorter comment

* only last line

* generate

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-15 15:33:54 -07:00
ecaslak
c293cb71c7 Add fingerprint for 2022 Honda Passport (#28175)
* Update CARS.md for 2022 Honda Passport

Changed latest supported model year from 21 to 22

* Update values.py: 2022 Honda Passport Fingerprint

Added ECU fingerprints for 2022 Honda Passport

* add missing fw

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-15 13:57:33 -07:00
Shane Smiskol
b9149795f1 Honda: Ridgeline 2023 is supported (#27979)
* Update values.py

* update docs
2023-04-19 20:40:30 -07:00
AlexandreSato
93c1810522 Honda: HR-V 2023 port (#27731)
* initial commit

* HR-V is diff enought to split from Civic22

* Add US HR-V 2023

* update CARS.md

* Update RELEASES.md

* Use a alternative brake signal

* US HR-V have a weird noise in the BrakeSwitch

* Shane tunning

* this is added automatically

* sorry jyoung

* civic22_stop_faster

limit stopAccel to current safety model

* relax calib temporarily (12 deg)

relax calib temporarily (10 deg)

* compute accel (car overshoots requests at low speed)

* revert brake pressed caused controls mismatches

* fix crash

* cause a cruise fault

* Revert "cause a cruise fault"

This reverts commit 09a6469ac6fc38ebd38dd1c5d464712a15d0fde1.

* no brake error

* use alt brake

* Update selfdrive/car/honda/carcontroller.py

* change HONDA_BOSCH_ALT_BRAKE_SIGNAL to CP.flags

* Revert "change HONDA_BOSCH_ALT_BRAKE_SIGNAL to CP.flags"

This reverts commit e0f8123b33db3218f27c4b64a7b2a0b1f740860f.

* remove FPv2 from brazilian HR-V

* bump panda

* fix a bug

* revert calib threshold

* new test route

* separate pr

* update

* update that

* thought i removed this

* revert steer ratio

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-04-14 03:12:10 -07:00
royjr
eb6112e94e Honda: add 2022 civic video link (#27821) 2023-04-07 11:20:32 -07:00
royjr
6381546075 Honda: Added fingerprints for a 2022 Acura RDX (#27812)
* Added fingerprints for a 2022 Acura RDX

* whoops
2023-04-06 21:38:13 -07:00
Adeeb Shihadeh
088cbfc9d5 car docs: add field for min compatibility requirements (#27805) 2023-04-04 17:47:49 -07:00
Shane Smiskol
42449b482d boardd: ability to switch between ELM safety params (#27656)
* indecisive

* rename to generic FW query

* remove code and update comment

* we need this to start off, unless we set multiplexing immediately

* draft

* draft 2

* try that

* can't do this either, boardd might read Enabled after removing, but before setting new Request param

* this should work

* use one less param

* fix params

* match behavior (set all pandas to safety param of 1, disabling multiplexing for fingerprinting

* clean up (some tests may temp break)

* fix param name and sort

* time it

* yes it does matter

* add to hyundai's bus 5 query

* remove hyundai for now

* this should work

* clean up

* clean up

* flip argument around, clean up

* fix test_startup

* some clean up

* rm line

* comment makes more sense

* required typing

* clean up common type

* comments

* Update selfdrive/car/car_helpers.py

* line

* whoops, need to set before vin!

* fix debug

* annoying

* more debugging

* bug fix (needs both keys always)

* debuGG

debuGG

* Revert "debuGG"

This reverts commit 55b2f429324c0b92d5cfb2cabf8b20db1e166248.

* Revert "more debugging"

This reverts commit 02934c3403ad5270f03093508b704c151d1ccb2a.

* Revert "annoying"

This reverts commit 8b4e5e09989f9a0217e3ec1c0ba68735929b7366.

* clean that up

* bumpback

* bumpback

* every second write param

* flip

* stuff

* move up?

* fix timing out in CI

* rm
2023-03-23 00:14:31 -07:00
javenzy
d50d8de637 Add China HONDA ACCORD HYBRID 2018 finger (#27462)
* Add China HONDA ACCORD HYBRID 2018 finger

Add finger to support China HONDA ACCORD HYBRID 2018,use ACCORDH model.

* remove FW for logging

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-03-01 16:00:08 -08:00
Shane Smiskol
c4b84783a0 Honda Bosch: gather available ECUs from camera (#27180)
* add flag

* actually use in fw_versions.py

* simpler

* not here

* Comment

* better name

* add param and block

* keys

keys

* block

* with a value

with a value

* add query for bosch PT bus

* different name

* fix

* .

* fix test

fix test

* add cloulogs

* mark as logging
2023-02-14 17:55:41 -08:00
Shane Smiskol
f29e19cf42 FPv2: log responses from data collection queries (#27345)
* log responses from logging/debugging queries

* don't add logging FW to FW dict for fingerprinting

* flip?

* fine before

* log if extra in debug ecus

* clean up

* test extra ecus too

* Revert "test extra ecus too"

This reverts commit 8f7867844db95f48631348551551148bf504e37b.

* bump to master
2023-02-14 16:59:20 -08:00
jayvin100
603e03116e Add support for Malaysian Civic 2022 (#27126)
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-02-02 23:16:43 -08:00
Shane Smiskol
f2966e9ef4 Honda FPv2: log extra UDS identifier (#27076)
* Add debugging uds ID

* add comment

* remove spaces

* try chaining the queries (temp debug)

this works

* works! - Revert "try chaining the queries (temp debug)"

This reverts commit c53d0f64aecdbd6224b0fd524f96637d29320cd1.
2023-01-24 22:30:29 -08:00
Shane Smiskol
95d45a8d64 Honda Civic 2022: gather FW versions for unknown ECU (#27074)
* Add unknown civic 2022 extra ecu

* Update selfdrive/car/honda/values.py
2023-01-24 21:24:33 -08:00
Shane Smiskol
a68633283f Civic 2022: add camera versions (#27073)
* Add fwdRadar for Honda Civic 2022

* remove debug cmt
2023-01-24 20:36:44 -08:00
Shane Smiskol
1e9ac45221 Honda Nidec: gather available ECUs from camera (#27071)
Query bus 0 for Nidec data collection
2023-01-24 18:37:00 -08:00
Shane Smiskol
b2c6d5d34a Honda: merge Passport platform into Pilot (#27061)
* Move Passport FW versions to Pilot

* lol, all duplicates already in pilot

* No Passport

* Better params for both
2023-01-23 20:16:50 -08:00
lucentheart
f75b640cf5 Add missing FW versions for 2019 Honda Passport (#26815)
Update values.py
2022-12-20 17:57:07 -08:00
royjr
17e06bdc93 Honda: Add missing modified firmware comment (#26648)
Update values.py
2022-11-30 22:21:48 -08:00
Shane Smiskol
997b2e11ae Honda Nidec: put max PCM gas into CarControllerParams (#26645)
* limit gas

* bump panda

* not sure why it was represented like this
2022-11-30 20:36:19 -08:00
Shane Smiskol
1367f84425 Car docs: add a make-specific init function (#26565)
* add a hook function for makes to implement custom docs logic

* don't need this

* use the pre-defined list for honda's harnesses

* one line 😎

* Update selfdrive/car/docs_definitions.py

* i didn't know you didn't need a pass!

* don't change docs order
2022-11-21 18:01:08 -08:00
FAN HANGYU
131263a75b Honda: add Chinese Odyssey FW versions (#25943)
* Update values.py

add a carFW of odyssey_chn

* move after odyssey

* common carparams

* just ignore

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-10-31 13:13:57 -07:00
Shane Smiskol
e9fcef99e1 FPv2 tests: test all addrs map to one ECU (#26151)
* add test

* fix mapping
2022-10-24 19:08:20 -07:00
Shane Smiskol
972951f5f4 Fix pass by keyword 2022-10-18 14:07:54 -07:00
Shane Smiskol
03d259a517 Honda docs: remove global min steer speed (#26138)
* remove global min_steer_speed so we can define in carparams

* remove 0 defaults
2022-10-18 13:52:05 -07:00
Cameron Clough
89768376c0 docs: remove redundant keyword args (#25899)
remove unnecessary keyword args, unnecessary package
2022-09-27 14:00:08 -07:00
Shane Smiskol
0ef6bb48df FPv2: move car-specific configuration into interfaces (#25711)
* Add VMCU address for EV6

* Rename vmcu

* add to tests

add to tests

* rename to more generic name

* more explicit

* remove print

* Like this much better, removes subtle fingerprinting problems

* clean up

* add test and clean up

* remove hyundai stuffs

* global

* Fpv2Config class

* fix missing fw versions from import order

* unused

* revert for now

* test for fpv2 configs with subtests

* subtests don't work that way

* do toyota as an example

* revert

revert

* do chrysler

* do rest

* stash

* much smaller of a diff than the alternative

* remove unused test

* fix tests

* remove brand from Request

* Make StandardQueries class

* add missing_ecus

clean up

* rename file

* unused

* test implemented

* add comment and rename

add comment and rename

add comment and rename

* should be impossible now

* this is a fixme

* rename to fw_query

* rename this too

* and this

* move vin queries to class

* order

* can use p16!

* formatting

* whoops, this wasn't gated on not len(found_versions)

* make this clear

* Standardize manufacturer software version query
2022-09-09 16:24:29 -07:00
Shane Smiskol
a0af3a998d Car docs: add more videos (#25494)
* Add Civic video

* add mazda cx-9 2022 video link
2022-08-19 13:34:23 -07:00
Shane Smiskol
4dbad71171 Car docs: update Odyssey supported model years (#25410)
* Revert Odyssey MY

* update docs
2022-08-12 01:58:49 -07:00
royjr
7aa563dc89 Civic 2022: Add missing srs fw version (#25314)
Add fingerprint from a7f4cd3bd223a19e
2022-08-01 19:05:00 -07:00
Shane Smiskol
c8a90ef586 Prepare for new supported vehicles webpage (#25021)
* add well maintained footnote

* stash

* some updates for the website

* one extensible sort function, pass sort function into template, continue to use "openpilot ACC"

* use items

same

* return a final dict

* Fix descriptions

* Required

* Add detail sentence

* Make string packages into namedtuple

* add temp year parsing

* revert this

* one unified class like harness

* fix static analysis

* Fix body

Fix body

* Make specifics strong

* remove years

* Make Camry footnote more clear

* Revert this too

* Add notCar text, fix steer speed > enable speed (remove comma, no speed mention)

* fix missing years

* group_by_make

* Use full package text

* Only use full package text

* Check car name if notCar, fix imports

* add_years no longer needed, remove 'with Stop and Go'

* fix that

fix that

fix that

* Exception for Nissan and Subaru

* Adjust DSU footnote text

* Fix speed overrides in sentence, CR-V package imp

* init() was being called multiple times, only need to run once to set row
2022-08-01 13:26:24 -07:00
Shane Smiskol
444de299b6 FW versions dump (#25203)
* hyundai dump

* dump

* optima (good, it doesn't get rid of previous segment values)

* add these comments back for now

* add another from release3 today
2022-07-20 22:02:22 -07:00
Shane Smiskol
54e168fce2 Honda Civic 2022: add missing FW versions (#25206)
Add missing 2022 Civic FW versions
2022-07-18 17:19:33 -07:00
Shane Smiskol
c8051154d2 Civic 2022: Add missing fw versions (#25164)
Add fingerprints from a918d2895b3210a1
2022-07-13 20:03:55 -07:00
Adeeb Shihadeh
ee6dc03118 fix accord years 2022-07-12 17:25:54 -07:00
Adeeb Shihadeh
ecac734160 update compatibility docs with VIN data (#25134)
* start with genesis

* chrysler

* honda

* toyota

* subaru
2022-07-12 13:51:25 -07:00
Adeeb Shihadeh
59055724d6 22 civic hatcback is supported 2022-06-20 20:20:24 -07:00
Shane Smiskol
abcc7338d4 Car Port: 2022 Honda Civic (#24535)
* master 2022 Civic

* bump panda

* bump

* bump cereal

* fix

* needed

* try for now

* maybe

* revert for now

* move to Cam parser

* fix

* move to cam

* need AEB_STATUS too

* bump for debug prints

* bump opendbc and add cruise_params

* bump opendbc and update cruise_params

* bump

* test route

* update ref

* Revert "update ref"

This reverts commit 28345dab63d1919865ccb510265222a4cd4252f4.

* cleanup

* just to test

* bump

* revert

* need to send val 12 too?

* change bus

* not needed

* update bus

* syntax

* move this to other bus too

* Revert "move this to other bus too"

This reverts commit 770bf4745ee244c8426ac108f44b67777198d0a7.

* test new lane line signal

* needed too

* maybe need both?

* Test new LKAS hud message

* bump

* missing comma

* missing

* maybe

* add frame and idx

* add in hud_lanes

* switch this too

* bump panda

* add this

* I guess need this too

* to match

* also

* wasnt correct

* bump opendbc

* bump panda

* move to cam parser

* missing

* add here too

* bump

* remove from cam parser

* bump

* back to cam parser

* its 5hz

* bump for new checksum function

* bump for correct frequency

* update frame and idx

* bump

* bump and update

* send set me bit

* bump

* pass these values through

* silly atom

* ret

* fix this

* use copy instead

* add these too

* to check keyerror

* switch

* bump submodules

* send too

* proper

* Replace HUD with BOH

* add dashed lanes

* small fix

* clean up

* not needed anymore

* remove and change

* this too

* dont always set

* remove additional LKAS message

* bump

* add

* to test

* add frame

* bump

* rebase

* remove default values

* rename

* clean up some carstate logic

* regenerate docs

* spacing

* simplify more logic

* bump opendbc

* bump opendbc

* only if radarless

* panda at least builds now

* add comment

* bump

* fixes

* bump opendbc

* bump opendbc

fix for new DBC

* bump opendbc

* bump opendbc

* carstate: fix bus, parser signals

* Set safety param

* pt bus is 0, not 1

* Fix SCM_BUTTONS and bump panda and opendbc

* fixes for ACC_CONTROL

* bump opendbc

* bump opendbc

* convert from MPH on HONDA_BOSCH_RADARLESS

move is_metric

* make sure we don't disable if radarless

* don't show incorrect harness on website

don't show incorrect harness on website

* bump panda

* remove/update comments

* bump panda

* Fix harnesses

* one line check

* bump opendbc

* remove this

* Some carstate cleanup

We removed STANDSTILL->WHEELS_MOVING

we don't use CRUISE_PARAMS

add back

add back

* more cleanup

* update docs

* marketing says it has TJA and ACC with low speed follow

* send buttons on bus 0

bump panda

* comment

* camera needs to see buttons on bus 2

comment

* bump panda

* add to releases

* remove comments

* comment

* we don't use stock hud yet

Co-authored-by: vanillagorillaa <ntmccoy@yahoo.com>
Co-authored-by: vanillagorillaa <31773928+vanillagorillaa@users.noreply.github.com>
Co-authored-by: kevinharbin <76784413+kevinharbin@users.noreply.github.com>
2022-06-19 00:06:23 -07:00
Shane Smiskol
b73d7cf3a5 CarInfo: Add test for missing platform info (#24607)
* Add test for missing car info

* Make optional
2022-05-23 14:22:10 -07:00
Shane Smiskol
433fcc0c71 CarInfo: Add harness information (#24085)
* Add harness information

* test harness enum

* add harness info for tucson

* update Tucson harness

* get rid of development

* make global enum

* fix

* add harness info

* add harness info to CARS.md (since we need multiple lines per HKG platform)

* revert this

* Actively Maintained means something! (aka, to bronze with select VW)

* fix caravelle

* add harness tooltip on maintained column

fix

* lol tubaru

* always assume harness

* update honda harnesses

* add Ioniq hybrid 2017-19 harness, todo: not sure

* unused import

* hmm, did they really switch to the C for 1 year??

* add comment

* add comments

* adding tooltips should be fine

* fix santa fe harness

* welcome back, vw

* no need for two harness strings

* seems fine

* fix 19-20 Niro EV harness

* these were taking from old database, so assume correct

* could be d

* pass all car info into template

* no more tool tips

* these use j533 harnesses

* accidentally got removed in merge

* also merge issue

* don't need these

* make harness non-optional
2022-05-11 18:02:21 -07:00
Shane Smiskol
f9af3ddf4c CARS.md: update Honda Ridgeline supported years (#24484)
* update supported ridgeline years

* update supported ridgeline years
2022-05-09 22:00:31 -07:00
Shane Smiskol
ac1566b4c4 cars: move common car info to subclass (#24481)
* clean up values a bit and make HondaCarInfo for package

* also move min_steer_speed which had 12 occurrences

* odyssey has ALC down to 0

* do Nissan, Mazda, and Chrysler
2022-05-09 18:50:10 -07:00
Jackson Smith
6e789fae70 Honda: Add FW for 2021 Honda Passport Elite (#24255) 2022-04-26 21:00:31 -07:00
Chris Souers
12ff38196d More Accord 2021 FW (#24154) 2022-04-06 22:06:26 -07:00
Shane Smiskol
31a6b141d6 Docs: auto-generate supported cars documentation (#23762)
* make CAR class enum, and values.py formatting

* Revert "make CAR class enum, and values.py formatting"

This reverts commit 04d9817e9d5d6ab5c027754018fc445f2cd3067a.

* stash

* add supported packages and model years

* don't change model years in fps

* move Lexus to info dict and make int enum

* remove sometimes wrong model years from name string

* use enum names

* convert Honda's values

* nice names

* use name

* GM

* Mazda, Ford

* Hyundai: WIP

* finish Hyundai

* fix

* Nissan

* Subaru

* Tesla

* formatting is for another PR

* Chrysler: todo: unify the Pacificas?

* do volkswagen

* this isn't a zoo

* skip enums for now

* Update selfdrive/car/volkswagen/values.py

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>

* set All

* temp cars

* auto-generate CARS.md

* update type hinting

* add generated file

* add longitudinal star to cars that support disabling radar

* add TODO

* add notes

* add min_steer_speed exception for hatchback

* add minimum steering speeds

* Add exceptions and run generator

* Missing Telluride

* fix Prius v

* missing Prius Prime

generate

* start to convert years to strings

* Fixup Hyundai

* convert year sets to strings

* handle this

* missing S3

* Fix and add all missing cars (verified with script

* Supported Package fixes

* add get_tiered_cars

* Check radarOffCan for removing most Honda from op long

* Update for Avalon stop and go update on master

* Fix missing car params

* add my temporary script i'm using to verify new generated DBC

add my temporary script i'm using to verify new generated DBC

* generate with jinja template

* add header and footer

* clean up

* rename

rename

* add exceptions. jinja is nice, but why are its loop indexes starting at 1?

* add list of known car videos

* See how these look

* Add nice table formatting for column description

Add nice table formatting for column description

* generate

* consisten br tag

* small clean up

* temp

* Move car videos into CarInfo

* add new copy and rename to footnotes

* Revert "temp"

This reverts commit 93c3fce1d3ab406f80cbfb9c00c2237d109c7846.

clean up

* generate

* replace with svg

* simplify a bit

* add footnotes to CarInfo

* move some variables to docs.py

* Add video link for Acadia

* Make Footnote an enum so we don't use random ints

* static analysis fixes

* move to CARS.md

* fix last missing footnote

* add to release files

* rm test file

* use svg

generate

* fix sorting

* not needed

* not sure how this got here

* remove Sedan/Couple and add Diesel footnote

* finish todos

* move make specific footnotes to selfdrive/car/*/values.py

rename

* change to zeros

* align bottom to center

* Apply some suggestions

* Update selfdrive/car/mock/values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update copy

* Try headers + bullet points

* somehow better

somehow better

* finish updating copy

* move template and add links to sups

* stars shouldn't be clickable

that didn't work

try this

try this

this is better

* add type hints to CarInfo

add more type hinting

* optional needs a type and any covers all (?)

* move good steering torque to */values.py

* dataclasses are much nicer than attr

* use tuple

* Update docs/cars.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* suggestions

* suggestions

* suggestions

remove

* clean up a bit

* add more type hints

* center stars and remove hardcoding from template

* update copy

* Add test

* Fix types

Fix types

* add supported cars documentation test

* clean up

* replace with docs_definitions

* Add back Footnote enums

* Ah so these are like fstrings!

* Update selfdrive/car/CARS_template.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update year from master merge

* Fix longitudinal star from merge

* sort properly stars by Column enum

* clean up

* HKG: Sorry guys

* Prius V gets FSR star, like others

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update comment

* No Prius docs change for now

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-16 21:27:05 -07:00
Shane Smiskol
31228ce560 Honda: use common DBC for CRV H and Accord Diesel (#23743)
* bump

* use Accord DBC for CRVH, Civic Diesel

* bump

* bump opendbc
2022-02-12 16:28:53 -08:00
Adeeb Shihadeh
d2735d73fc test car models: fix all panda safety mismatches (#23616)
* remove tolerance

* fix nissan mismatches

* warm up

* remove additional bosch check

* another honda exception

* little more

* Update selfdrive/test/test_models.py
2022-01-29 22:14:27 -08:00